From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B1A3CEDD89 for ; Wed, 9 Oct 2024 12:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=ddgzihC/v7zzxGuksHSfH6I/6M LCJZomahB1dWLZj3TwnwYwvuw/j7m0ASvWwqwmcgYOoehEaUaARKVO8jcgKmorawqJzWpGMk6y70T xwCZ9KJY0Grd8yBDWbpQ0YWD0C/lSAnfnWdmI19+RpLOEte9jXDjh6OmHrhlG274kDrb5M/DqHLQj zuxPIxVnMGKxYd+pXVP+ku4BTxOI8jMxFvp8K00m5MQ0n8ZN5vttETPXDL0R92smdSD7c1f/VH09S Z7cI48SL9oqO56uvlPRTXquZJjXyEzhqT0cGjzEN9b/BO+3R+MZIAmy8167G32Q1Wq9evvRN2RQNH AyXlsq/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syVTA-00000009A9D-2Sfm; Wed, 09 Oct 2024 12:07:08 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syVEI-000000096pX-0vGq for linux-arm-kernel@lists.infradead.org; Wed, 09 Oct 2024 11:51:47 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5c924667851so389508a12.3 for ; Wed, 09 Oct 2024 04:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728474704; x=1729079504; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=wwmk/9DY027iCPD4DZIZwXWCOPX9Li8S9nP9TeIw1rBj/207hBfg1ROqIALFCRa/m0 Tuiu3W8Z/trlYk9FdPMtbGAJpkbMFoeEmi5hsOs9DzCuals9pihRQrlwXbswRbS7IGDj 1qJ2LeQoPPex2rj3hfGjl9kQFzUKFt4Fyl265P0bgRsoOOOWmXmO3vlHo9jHXw0+0v/Q 1DitYURBLInwPbL0oV8rDJ+caNt8BppYdqe92JOjYnOxgzh7mrm15sqsbWEX8fNbS92v I92meDG8hkUgwwFkjCjHe68JB+qzsstxWjWwhmxnyLOFUR4QxNNrxrvfisIb6kEd7i4c +rcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728474704; x=1729079504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=l0ASUdw1eWVfSr4uUHrsTbYTA110CtZ4fPW8Xqnw3xptUPOXaeZoMSk+czaRRWE29x 9kMtS8qf8qmJR0qHqRT2bjlu9h1jvcaypbc+K21NWEqOHfDdJ0OorfRPM23y7wxpwtI9 A9Jn47JYr5zdcpRmZdFEecCfDKGno+Lu3yWE7l38foQs31aeUHsOIEYWQtJYokqeM5N8 ZXRNYYAnwCSZ7f+843IhIZG264YuYhtbF+6LqpH9nJaaGx2Uw3jcXm1RPLfS9EUumJQQ eDztLFvoGndTnoNY/TIFsJKerG0kOgAcwfgMggJ1r++Xx6/jegTatPfaZgRGCwSU4ZGJ 5h1g== X-Forwarded-Encrypted: i=1; AJvYcCU5zUmWQ1FdoKg3BUa0VF6ahMF2f2w2vOPaYf1DzU2XKb+GdWAAmYtOL+YoMoG4GK6Lnc07JCy8gywBmUH2TMq4@lists.infradead.org X-Gm-Message-State: AOJu0Yxm4fiY3uLwE/nMJuoQVB0cjVAEBuK1JMvLHQ3JWT2kwcuYuzoE 4ViuWmtjH+fe3QGiyrrtna2nE6dpILbTfOmE7uHgTSCcKMfDzjH1U73x3VNWIvk= X-Google-Smtp-Source: AGHT+IGKpe5RJdRvKaNKGeWlJU8yuhUR86qwyFDbVPAhlwFfcx+fGtxwpK017I4wKqBnPOdRSWgB4w== X-Received: by 2002:a17:907:3da7:b0:a99:451b:38fe with SMTP id a640c23a62f3a-a998d174df2mr179992766b.26.1728474703666; Wed, 09 Oct 2024 04:51:43 -0700 (PDT) Received: from linaro.org ([82.77.84.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a995668f4b6sm396323966b.48.2024.10.09.04.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:51:43 -0700 (PDT) Date: Wed, 9 Oct 2024 14:51:41 +0300 From: Abel Vesa To: Pengfei Li Cc: krzk+dt@kernel.org, robh@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, ping.bai@nxp.com, ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver Message-ID: References: <20240627082426.394937-1-pengfei.li_1@nxp.com> <20240627082426.394937-2-pengfei.li_1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627082426.394937-2-pengfei.li_1@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_045146_297541_D9ACB45D X-CRM114-Status: GOOD ( 20.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-06-27 16:24:25, Pengfei Li wrote: > IMX93_CLK_END was previously defined in imx93-clock.h to indicate > the number of clocks, but it is not part of the ABI, so it should > be moved to clk driver. > > Signed-off-by: Pengfei Li > --- > > Notes: > Change for v2: > - Use pre-processor define to simplify code. > > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index c6a9bc8ecc1f..c8b65146e76e 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -15,6 +15,8 @@ > > #include "clk.h" > > +#define IMX93_CLK_END 202 > + TBH, I don't like this. And I still don't understand the reason. Where are the clocks you want to add ? And why wouldn't it be OK to just keep this in the bindings header even if you need to add more clocks ? For the moment, I don't see the value of this change. Sorry, but NACK. > enum clk_sel { > LOW_SPEED_IO_SEL, > NON_IO_SEL, > -- > 2.34.1 >