From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED6C4D2A538 for ; Wed, 16 Oct 2024 17:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l9SQ56aoPQ3Opte4b/+MnMyJMB/paFHV8dl8gEVuNds=; b=qBfQqU+u/+RibooepHNf9PuPRl Ye1yS7zbnD390W+Zh4/mvaqv7gO+GoypcZLMdQTqm6k7Xebs0AMeaF8nXzxcJBqrNDBJod4dHVWRm EllecMIzNWcoXxjzQ5lZT9upM3sKUGLBxiDroTST7X85d00H2to5UbC353+l2jvz9+b8To9FqpMRH 9MPmp2r23bVpMxqMztlp92q4f6sO0DYaDPyO0rRCZDwAS2v3shWj7GHjxKRSPzXD0A9E+aVzBsMLS nl2FY38GYtx59rtDrigc8+j24yKsWOJLgCkauaf4sXfQux5wQrPxZy6h1HfVVYN4HOBL6aw8k8JlC rxHwx+tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t18DB-0000000CbYE-35HI; Wed, 16 Oct 2024 17:53:29 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t18Bm-0000000CbQW-3C8M for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Oct 2024 17:52:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l9SQ56aoPQ3Opte4b/+MnMyJMB/paFHV8dl8gEVuNds=; b=j/AUjlxSgDGzTCZVIVbOW5cuqk KssA15hJTzju31ytw5/pnpv0H+ihr5Pz+gkEuv2a6Yd0hKy/1pKylihJVADDxDawfuVpmlY8w1W3M FI3pAbSEB5tLYiqBMcqRuitanTxEI4p0BbWQFuNtLvxWfwtTDM09nmXLnvVHwXq7YcoqvA75Gs1wI +FaKZdQ9yLIQAHBGnokPCH9FzE7vAE3eTPHQ8rFhKMMPNp7xulwYWEe08jg4kvsnDfN96Ja/VVgvX nAo8M44pZVLlYVRcAFLfZ1XxtKPMx9jF5NFK/z46uTsFgzEobxQxOwCl2KbB2IXQhRTZ4M7mT5TIs H/NQbwYw==; Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t18Bj-00000006ria-2VcZ for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 17:52:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A39E6A40E0B; Wed, 16 Oct 2024 17:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12F58C4CEC5; Wed, 16 Oct 2024 17:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729101114; bh=Q/rMGnUiexOywnQsnS70I2iihXeyPYW5rsx865r2iTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rLdhG/3e7pb2KU5XrNDBrK7GRfbIWXXRVJ+JcD+G4rSAmvXIgjBh/d/zOt1w8e8e3 2mn8Aohvan/5kUM0uV0zArl5yXY8zU78PLf/nGSd5uv+iY+JnNWMY5BB7WTvfxw2+z DLvw9CnEn9NTcBf8gHLWIcfITKK2NIniXIpJ9gOQKlLdevqWZM1X97UjoGeowHnoaQ YSFYftfZMnOYQdqHBatH169Z7ytsEnrHIpOX35XWH+51s4RagpYg0xdgDTeLfqDLb1 QaoTXj0Hw7MnwJl7Rq+t+UQkNXA1jy+EA+eKZnmQrvhbcdTxssl3NhM97joGFYuRl6 CC7ts1XTh3NaA== Date: Wed, 16 Oct 2024 10:51:52 -0700 From: Namhyung Kim To: Steve Clevenger , leo.yan@arm.com Cc: james.clark@linaro.org, mike.leach@linaro.org, suzuki.poulose@arm.com, ilkka@os.amperecomputing.com, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V9 0/2] arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_185159_854779_9C95529A X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Fri, Oct 11, 2024 at 11:17:10AM -0600, Steve Clevenger wrote: > Changes in V9: > - Removed V8 patch files 1/4 and 2/4. > - Modified set_sym_in_dict (trace-event-python.c) to add map_pgoff > in dictionary as-is without regard to MAPPING_IDENTITY. This patch > file is now patch 2/2. I think the previous version had Leo's Reviewed-by tag. Leo, can you confirm if it still holds? Thanks, Namhyung > > Changes in V8: > - in arm-cs-trace-disasm.py, ensure map_pgoff is not converted to > string. > - Remove map_pgoff integer conversion in dso not found print > message. > > Changes in V7: > - In arm-cs-trace-disasm.py, fix print message core dump resulting > from mixed type arithmetic. > - Modify CS_ETM_TRACE_ON filter to filter zero start_addr. The > CS_ETM_TRACE_ON message is changed to print only in verbose mode. > - Removed verbose mode only notification for start_addr/stop_addr > outside of dso address range. > > Changes in V6: > - In arm-cs-trace-disasm.py, zero map_pgoff for kernel files. Add > map_pgoff to start/end address for dso not found message. > - Added "Reviewed-by" trailer for patches 1-3 previously reviewed > by Leo Yan in V4 and V5. > > Changes in V5: > - In symbol-elf.c, branch to exit_close label if open file. > - In trace_event_python.c, correct indentation. set_sym_in_dict > call parameter "map_pgoff" renamed as "addr_map_pgoff" to > match local naming. > > Changes in V4: > - In trace-event-python.c, fixed perf-tools-next merge problem. > > Changes in V3: > - Rebased to linux-perf-tools branch. > - Squash symbol-elf.c and symbol.h into same commit. > - In map.c, merge dso__is_pie() call into existing if statement. > - In arm-cs-trace-disasm.py, remove debug artifacts. > > Changes in V2: > - In dso__is_pie() (symbol-elf.c), Decrease indentation, add null pointer > checks per Leo Yan review. > - Updated mailing list distribution. > > Steve Clevenger (2): > Add map_pgoff to python dictionary > Adjust objdump start/end address per map_pgoff parameter > > tools/perf/scripts/python/arm-cs-trace-disasm.py | 16 +++++++++++----- > .../util/scripting-engines/trace-event-python.c | 9 ++++++--- > 2 files changed, 17 insertions(+), 8 deletions(-) > > -- > 2.44.0 >