From: Frank Li <Frank.li@nxp.com>
To: Marek Vasut <marex@denx.de>
Cc: u.kleine-koenig@baylibre.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
francesco@dolcini.it, imx@lists.linux.dev, jun.li@nxp.com,
kernel@pengutronix.de, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
p.zabel@pengutronix.de, pratikmanvar09@gmail.com,
robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
xiaoning.wang@nxp.com
Subject: Re: [PATCH v8 1/1] pwm: imx27: workaround of the pwm output bug when decrease the duty cycle
Date: Wed, 9 Oct 2024 11:37:57 -0400 [thread overview]
Message-ID: <ZwajVXRwDLDg2rc7@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <41cc47bd-f18f-463b-a0dc-843088ecf91e@denx.de>
On Wed, Oct 09, 2024 at 03:55:35AM +0200, Marek Vasut wrote:
> On 10/8/24 9:41 PM, Frank Li wrote:
>
> [...]
>
> > + c = clkrate * 1500;
> > + do_div(c, NSEC_PER_SEC);
> > +
> > + local_irq_save(flags);
> > + val = FIELD_GET(MX3_PWMSR_FIFOAV, readl_relaxed(imx->mmio_base + MX3_PWMSR));
> > +
> > + if (duty_cycles < imx->duty_cycle && (cr & MX3_PWMCR_EN)) {
>
> I think you can use state->enabled instead of (cr & MX3_PWMCR_EN).
state->enabled is new state. Need check old state here. If old state is
disable, needn't this workaround at all.
Frank
next prev parent reply other threads:[~2024-10-09 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 19:41 [PATCH v8 1/1] pwm: imx27: workaround of the pwm output bug when decrease the duty cycle Frank Li
2024-10-09 1:55 ` Marek Vasut
2024-10-09 15:37 ` Frank Li [this message]
2024-10-10 1:18 ` Marek Vasut
2024-10-16 16:14 ` Frank Li
2024-10-17 6:58 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwajVXRwDLDg2rc7@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=pratikmanvar09@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox