From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C25E0CEE338 for ; Wed, 9 Oct 2024 17:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pZOzLCxv0AWavLvuY/XxXqAxMwjxNA9ySg9xJtqBH2A=; b=4TWLOxBrFVVCK7IujGvX6L1CHi jTvoceqyFz7ZSi1pTXPzdJ8HsVPBTaNKUAL8/CT3H9utffQm9Nk4RYfGs2+Dvp+T6MHd3z+aLCAL/ Gs2CQjkUg8EWVXAMvQEQzlHcXs8WQVGGuNzq8LPdZ9bSQ3DNd/xGzM+QEoh+qcrJYX0CAIdBPQfaE Xmk4p03ztq/FbRgVHA5gttrTLycHW930axwAyiPCAh3HnHqStoyUvzegkurYfs+DGSo6BKcNjaOgK jRTiv0Gum03HNhXWEnVpjky0+Q+x8T/MYBb+aKupjHLrQz+O4h8cPhqesiWokboS12kBeXrSyQGys qFIc+b7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syaWS-0000000ABAr-20p3; Wed, 09 Oct 2024 17:30:52 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syZ84-00000009qij-0xNP for linux-arm-kernel@lists.infradead.org; Wed, 09 Oct 2024 16:01:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 92F39A4420B; Wed, 9 Oct 2024 16:01:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D56CC4CEC3; Wed, 9 Oct 2024 16:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728489694; bh=aPf5UiYG1vsp/Il+DJSTs1K8163OCruXIBTQfDcJnk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UD980E8ANwBR8CV6W0r545AsFquNd6VQJLZAhzv03kH/2722yJVUfx2XR5s9jc9Wc AUV5IbyCzTe3Coa25RIdrCecLNl0dL1/4PhErHS0znpmrtwWfuAMeKgbM+GXln8oI9 wUmpInMKAAcNs4mTA6YGMM9+PyyOM6pz5XyU+lN2uzAffaKOG9V0OvZ3BjUvrIGGPU 3cs3lX6bGTBCIgzzCH/8c+ZJ22OzxMpevAA0YLfuVThtbrF1cAezHQ8WwvwisbXVg/ +7tZqaCl31FNmzpnYGWSPo/4SPE7bDk16U78rzvUaGoglXbgaUj8yNtEcg4w8M05r7 +lwC1rbHYVY2g== Date: Wed, 9 Oct 2024 18:01:27 +0200 From: Niklas Cassel To: Frank Li Cc: manivannan.sadhasivam@linaro.org, aisheng.dong@nxp.com, bhelgaas@google.com, devicetree@vger.kernel.org, festevam@gmail.com, imx@lists.linux.dev, jdmason@kudzu.us, kernel@pengutronix.de, kishon@kernel.org, kw@linux.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, maz@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, tglx@linutronix.de, dlemoal@kernel.org Subject: Re: [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller Message-ID: References: <20230911220920.1817033-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230911220920.1817033-1-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_090136_505483_F7DCD114 X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 11, 2023 at 06:09:15PM -0400, Frank Li wrote: > ┌────────────┐ ┌───────────────────────────────────┐ ┌────────────────┐ > │ │ │ │ │ │ > │ │ │ PCI Endpoint │ │ PCI Host │ > │ │ │ │ │ │ > │ │◄──┤ 1.platform_msi_domain_alloc_irqs()│ │ │ > │ │ │ │ │ │ > │ MSI ├──►│ 2.write_msi_msg() ├──►├─BAR │ > │ Controller │ │ update doorbell register address│ │ │ > │ │ │ for BAR │ │ │ > │ │ │ │ │ 3. Write BAR│ > │ │◄──┼───────────────────────────────────┼───┤ │ > │ │ │ │ │ │ > │ ├──►│ 4.Irq Handle │ │ │ > │ │ │ │ │ │ > │ │ │ │ │ │ > └────────────┘ └───────────────────────────────────┘ └────────────────┘ > > This patches based on old https://lore.kernel.org/imx/20221124055036.1630573-1-Frank.Li@nxp.com/ > > Original patch only target to vntb driver. But actually it is common > method. > > This patches add new API to pci-epf-core, so any EP driver can use it. > > The key point is comments from Thomas Gleixner, who suggest use new > PCI/IMS. But arm platform change still not be merged yet. > > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-arm > > So I still use existed method implement RC to EP doorbell. > > If Thomas Gleixner want to continue work on devmsi-v2-arm, I can help test > and update this patch. > > Change from v1 to v2 > - Add missed patch for endpont/pci-epf-test.c > - Move alloc and free to epc driver from epf. > - Provide general help function for EPC driver to alloc platform msi irq. > - Fixed manivannan's comments. > > Frank Li (5): > PCI: endpoint: Add RC-to-EP doorbell support using platform MSI > controller > PCI: dwc: add doorbell support by use MSI controller > PCI: endpoint: pci-epf-test: add doorbell test > misc: pci_endpoint_test: Add doorbell test case > tools: PCI: Add 'B' option for test doorbell > > drivers/misc/pci_endpoint_test.c | 48 +++++ > .../pci/controller/dwc/pcie-designware-ep.c | 2 + > drivers/pci/endpoint/functions/pci-epf-test.c | 59 +++++- > drivers/pci/endpoint/pci-epc-core.c | 192 ++++++++++++++++++ > drivers/pci/endpoint/pci-epf-core.c | 44 ++++ > include/linux/pci-epc.h | 6 + > include/linux/pci-epf.h | 7 + > include/uapi/linux/pcitest.h | 1 + > tools/pci/pcitest.c | 16 +- > 9 files changed, 373 insertions(+), 2 deletions(-) > > -- > 2.34.1 > Hello Frank, Thank you for your work on this. This series is very interesting. As you probably know, IMS support was ripped out of the kernel a few months ago: b966b1102871 ("Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"") So this series seems as relevant as ever. Are you considering continuing work on this series any time soon? Kind regards, Niklas