From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81B93CF07BF for ; Thu, 10 Oct 2024 08:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+ZPf8gJqlrSlWlBTitKItaEuQMUuQitef5n6GBtWdWo=; b=zXn8DmC5zyiZsZXu3mM4gSxQxl 58utNdW2Y556e9mh3zJkNCUekVUb56fY9TvgEdl+FpshaHfSs4w1k31O09dxTSLZvHfWdFB4/+OFx uOqU3XGvksBtItGB3cQ6oIt4BAQ2xhg8XGXdTkXaMSnasyIfL2SJUb0o2xajF4EtvyRyaRkKE71/k 7ofLZjtcaF4g3fKv8VsOvN/qKkqS8EWhDdRyvQenzr9M2OQs3gf7O2ZPKhT5+P/eIGBEmXpOduyH8 amLmfqtzRPrHGWK1GCvJrkFIUKhmwYO5PPGiIKm+lolhEa2QYxxV99vXIeRYh5hCqXQXafQP63dVM xB4hWmqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syoIX-0000000Bvdj-3D3y; Thu, 10 Oct 2024 08:13:25 +0000 Received: from out-175.mta0.migadu.com ([91.218.175.175]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1synyp-0000000BsfA-3d4O for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2024 07:53:05 +0000 Date: Thu, 10 Oct 2024 00:52:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728546780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+ZPf8gJqlrSlWlBTitKItaEuQMUuQitef5n6GBtWdWo=; b=MtHHMJLZbjGSVLABFJUOta8yqdBuXJi4Yjg8/9a6OKwbX4IDUvljT7NttUYNzOG3VG8QhF mj5Mc0YdJv7g5M1/ssiXiM9ou28Ls2NOaiLj10BgAi2qMPgL7ApBsw32qYCzI1CSkbwa8T QHTbqotJ+Ta+3lTihyHtynjSacUWUa0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Joey Gouly , Suzuki K Poulose , Zenghui Yu , Alexandru Elisei , Mark Brown Subject: Re: [PATCH v4 27/36] KVM: arm64: Add a composite EL2 visibility helper Message-ID: References: <20241009190019.3222687-1-maz@kernel.org> <20241009190019.3222687-28-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009190019.3222687-28-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_005304_156778_C6A7EE23 X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2024 at 08:00:10PM +0100, Marc Zyngier wrote: > We are starting to have a bunch of visibility helpers checking > for EL2 + something else, and we are going to add more. > > Simplify things somehow by introducing a helper that implement > extractly that by taking a visibility helper as a parameter, > and convert the existing ones to that. > > Signed-off-by: Marc Zyngier nit: avoid churn and order this before introducing more open-coded instances of EL2 + FEAT_something checks. -- Thanks, Oliver