From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8911ACF11FC for ; Thu, 10 Oct 2024 15:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w5s9c0gsUyZAb1duuICYtgix8lgm5eDU7I4/CwJW6Kc=; b=hleBFnQag35RJQ5OtxVdDCxH5V MA0Ct92wL16UtZf2B4QQnPtgN/mZ786oupf5zPvD0d2ACvpek/rlK6OZkURKfo6j0MwOmae8TtFT8 +O0ETQoe2X4mTTNTD8+aKlv59TtI8UwmbvxnryxW/Lr11flCygswGwSXmnOXQ2iWL55olMg1DyI2t Vovu39yFEN/eYSaqi0h/afEIt51wRg3uytxucMguSRE7dvp4fgLdaIPlUR5pM8Peu1pEUs/Cwh+kt 239bsjOYNOdbPxdRbxaP2UyuoOCCfcTc6uvrmFVni4drek3ztZLjMzMO0qZuAoY1pT3Xao8bWhtEo IiuWwu9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syv0B-0000000DJEU-3JXs; Thu, 10 Oct 2024 15:22:55 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syuZs-0000000DDfM-3QQq for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2024 14:55:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8423F5C5C7C; Thu, 10 Oct 2024 14:55:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6876DC4CEC5; Thu, 10 Oct 2024 14:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728572143; bh=w5s9c0gsUyZAb1duuICYtgix8lgm5eDU7I4/CwJW6Kc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tvL4wljrUPmcLEINB9jWM9y3BseA1V5ZXHgtB69KejDi2iJg+PscHYMxEUjmE3p54 jSKKIQISe+YUh8Cm+isA+mVA9GsZaJbNTc4QuxEwdcRs9s2rPrxT4I1O8JPGqEmUTb 0gMk5Yk0Ah6UquDUsxZIapMSWe8cRDVlC9a2XSNbWKmhNL1+yIKG/jQY9j84e8JIJL 5d6lX6appzVPcDKIrTHzSZTNcX+Peb1CCUGgoSN9thX+nzNpNp3x0mlquCE+Q1EqnS zRI6CgCQK1mlC3KftfmnmI04vpcmm/OQgQ3JHvlxQCRGIP/zrp9cj6iuML0VM1HeSN +GghxeTXPDLew== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1syuZw-000000007yi-1IRM; Thu, 10 Oct 2024 16:55:48 +0200 Date: Thu, 10 Oct 2024 16:55:48 +0200 From: Johan Hovold To: Sibi Sankar Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, ulf.hansson@linaro.org, jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, konradybcio@kernel.org, linux-pm@vger.kernel.org, tstrudel@google.com, rafael@kernel.org, Johan Hovold Subject: Re: [PATCH V3 1/4] firmware: arm_scmi: Ensure that the message-id supports fastchannel Message-ID: References: <20241007060642.1978049-1-quic_sibis@quicinc.com> <20241007060642.1978049-2-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241007060642.1978049-2-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_075544_925500_E2FB88BF X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2024 at 11:36:39AM +0530, Sibi Sankar wrote: > Currently the perf and powercap protocol relies on the protocol domain > attributes, which just ensures that one fastchannel per domain, before > instantiating fastchannels for all possible message-ids. Fix this by > ensuring that each message-id supports fastchannel before initialization. Perhaps you could include the error message I reported here so that anyone searching for that error will find this fix more easily. > Reported-by: Johan Hovold > Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/ > Fixes: 6f9ea4dabd2d ("firmware: arm_scmi: Generalize the fast channel support") > Signed-off-by: Sibi Sankar Do we want this to be backported as well so that you should add a CC-stable tag? Either way, this does seem to address the FC errors I reported: Tested-by: Johan Hovold Johan