From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71C69CFD31D for ; Fri, 11 Oct 2024 10:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lrckGZYGXMMQfVDIiWUcEq9xwcsN6iS/X3DthnRZ3r4=; b=inxHIeXOnM1kZ0z5zdhHd2jK9k 2kIZXsMFb3mkfH+5qoYLMJ5b73OtmVO7HzLzktIXQofVPktVkGq/0chuIr4JZIrK3abHoDC8kb696 znpAmL+yblWezVKBs1rkWIKL6+jTgj0lIj1DSqsm586Kf4WE6yAhUEWzkfzj+AJT5iRXMOHGKBFzv 0HtDVpy8qGBoHGafnjmrcKSA1b/IfdH4XVqILW93q0Pr1iNB+AmwHNIm76jrEiCixejWXrQY9Ivqo 8P7s0kaTdbPpjZIQkw+BS2LN1k6SHXWU8Gf83SvyaV3KkydkY1ng/Nv6FXnOynLsHoZeqbaJ0ys9p GouEpKfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szDH4-0000000G3r8-41tf; Fri, 11 Oct 2024 10:53:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szDDs-0000000G3Ul-1nKj for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 10:50:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81118497; Fri, 11 Oct 2024 03:50:43 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 31CEF3F73F; Fri, 11 Oct 2024 03:50:13 -0700 (PDT) Date: Fri, 11 Oct 2024 11:50:08 +0100 From: Mark Rutland To: Luca Fancellu Cc: andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [boot-wrapper v3 1/4] Introduce --with-bw-arch for boot-wrapper compile arch Message-ID: References: <20240731141103.2559706-1-luca.fancellu@arm.com> <20240731141103.2559706-2-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731141103.2559706-2-luca.fancellu@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_035016_534075_2A29A797 X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 03:11:00PM +0100, Luca Fancellu wrote: > Introduce a new autoconf parameter --with-bw-arch that takes > 'aarch64-a' and 'aarch32-a' as compile architecture, the former > is selected by default when the parameter is not passed. > > This new parameter superseed --enable-aarch32-bw, its functionality > is now implemented by --with-bw-arch=aarch32-a. > > Signed-off-by: Luca Fancellu > --- > Changes from v2: > - Major rework, reason in the cover letter. > --- > configure.ac | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index ce41daebc378..bba42fa1dba8 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -9,9 +9,18 @@ AC_INIT([boot-wrapper], [v0.2]) > > AM_INIT_AUTOMAKE([foreign]) > > -AC_ARG_ENABLE([aarch32-bw], > - AS_HELP_STRING([--enable-aarch32-bw], [build a 32-bit boot-wrapper]), > - [BOOTWRAPPER_ES=32], [BOOTWRAPPER_ES=64]) > +# Allow a user to pass --with-bw-arch={aarch64-a,aarch32-a} > +AC_ARG_WITH([bw-arch], > + AS_HELP_STRING([--with-bw-arch], [aarch64-a selects AArch64-A (default), aarch32-a selects AArch32-A]), Could we we please make the help text: specify boot-wrapper architecture: aarch64-a (default) or aarch32-a That way ist says what the option does, and it avoids the repeition. With that change I think this looks good to go. Mark. > + [case "${withval}" in > + no|yes|aarch64-a) USE_ARCH=aarch64-a ;; > + aarch32-a) USE_ARCH=aarch32-a ;; > + *) AC_MSG_ERROR([Bad value "${withval}" for --with-bw-arch. Use "aarch64-a" or "aarch32-a"]) ;; > + esac]) > + > +AS_IF([test "x$USE_ARCH" = "xaarch32-a"], > + [BOOTWRAPPER_ES=32], [BOOTWRAPPER_ES=64] > +) > AM_CONDITIONAL([BOOTWRAPPER_32], [test "x$BOOTWRAPPER_ES" = "x32"]) > > AC_ARG_ENABLE([aarch32-kernel], > -- > 2.34.1 >