From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6954D0D78D for ; Fri, 11 Oct 2024 13:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CSAH6QuPyfc8q604OCmE809kqVdVDarsWKxTosXp2+A=; b=ZCSy7+N0YmP8Hs7CJpQqYZ9Wgu Veq3RDeqOCITEODoAErDJzdX1LYadOSUNf4Iq1wEKAFODVSWsqaUkyWQgbpCkoaOW0OTU36Ht4TWH 0x/EkXThuNbNWzOiU+SBz/pOTJS6ckhLE26zx+h5bA/+HqCKLNQGkA+mo5k2N5gg9KrcwCW59oabT bctvHw4WlAcP/WG/a2fZaCWkZ/f060slapJ+SGaCQGRtEklK4Nzlki7aQvTdZFr8QS/pZ1XQnqrHQ ubdJecLyFXlNwkBya3eA4J0EagwQtxz0vmhdV0N6Tkp899v7IdZ+p7OJiyH0QayU1rdR4HZ7EGTrC YLt6Mzfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szFTH-0000000GPng-3NiR; Fri, 11 Oct 2024 13:14:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szFRZ-0000000GPUV-3SHV for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 13:12:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E8F105C5679; Fri, 11 Oct 2024 13:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B56C4CEC3; Fri, 11 Oct 2024 13:12:29 +0000 (UTC) Date: Fri, 11 Oct 2024 14:12:27 +0100 From: Catalin Marinas To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Suzuki K Poulose , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" Subject: Re: [PATCH v6 02/11] arm64: Detect if in a realm and set RIPAS RAM Message-ID: References: <20241004144307.66199-1-steven.price@arm.com> <20241004144307.66199-3-steven.price@arm.com> <085896de-9a39-4f90-9a2d-3f8662c2e2a2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <085896de-9a39-4f90-9a2d-3f8662c2e2a2@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_061233_927415_7B18330D X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2024 at 04:05:17PM +0100, Steven Price wrote: > I should have reworded this commit message to something like: > > """ > Detect that the VM is a realm guest by the presence of the RSI > interface. This is done after PSCI has been initialised so that we can > check the SMCCC conduit before making any RSI calls. > > If in a realm then iterate over all memory ensuring that it is marked as > RIPAS RAM. The loader is required to do this for us, however if some > memory is missed this will cause the guest to receive a hard to debug > external abort at some random point in the future. So for a > belt-and-braces approach set all memory to RIPAS RAM. Any failure here > implies that the RAM regions passed to Linux are incorrect so panic() > promptly to make the situation clear. > """ With the updated commit description, the patch looks fine to me. Reviewed-by: Catalin Marinas