From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B33FAD1A435 for ; Sat, 12 Oct 2024 04:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+GrOwLyfIS97I8J5B6KE+GSTCG3rf3UHVkzsxHAKe84=; b=Qo6wI/3R8fgfF+Uc2tddppN96U vwLPOpwAPUT9k2fEO5NulHV5LKRrq5rRJ7g2eFzEja3gOj4JHH7nBQfS6JGMy/YQSCUJ/SVQDi80H js9zCBlh5mch5bHQ86K+4Kw60KFKkEXieR+vg6Mm/h2nsxa7VW2BqkYj/a96Ur7QMSObofHJECcrS 2YLUfK5uie5jPm+gc1HWm+jMwWgVbmTtX7AiCOUzoQLyo+x6zKZPJ6j+/mvv86GIFAaPS41J8gzph /uwUXkiBgQMUkHvmxfDstqhwkTNmLSj8Td2F4LiuWv7B96tNGUqJ0fvoL823jtGViP5NH0ULykA50 vRUsUxSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szUCf-00000000Xub-1m4B; Sat, 12 Oct 2024 04:58:09 +0000 Received: from mail-bn8nam12on20616.outbound.protection.outlook.com ([2a01:111:f403:2418::616] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szUBJ-00000000XpH-0EOj for linux-arm-kernel@lists.infradead.org; Sat, 12 Oct 2024 04:56:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CJhvhjUZUtTTpsx8C67kSM32ovIHEBw0i9mg6Q2KBs4/T9in2gjW9RmFGYQi3DbAgYFIYkkwayAi2WmMCxVvqMbqOpO8EI3azb2ZWC31rAo9hy4QxlZtr91UIaKBM1msEI5hts53osqYImd9BVpLMyjPLl23o24I8HPB9rmIy5aRt56sa6zvP5+8Me9IC1GPiX1k9sh4AG+JDDEvBfPLYMbRB+jNyVFgw0cy9WRKeVIxWSDGn9lYeqQVYiV958ZmRBDbk/weVW7i2JnNrVgcrs9qPT0PY/3qNkU/SPqE/gaypI79YfCiF60q0uCmbfdmXuuCBQsBtve2RVNn1uvTGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+GrOwLyfIS97I8J5B6KE+GSTCG3rf3UHVkzsxHAKe84=; b=zO2sD6GJOufI6I25KcrZi4A2UgMbVNDyrydVHzDJyRCuk0s08N7ySjSih2e7BVJ9PpI9PtkWLBdaFJ7KH/T2qCKPv3Z27JOCeYc3CLEou1Y4a7qEY7v8WvjKKjp7mjWXM/34t4S6zjKjyunvFIHl9ExOwOHjMEXGqGWKEnW1A6LEoEk/VZsVLZYBt3LAvV805ICz+EUcuOnt1CFwNBohLOGbkKOuCLldCwp09SCSnIf/XR5teQgGY13Nc49HQXhAn4nk9dBbiBDRrm6eZtWoLngJ49c63yccSsIBqneVfwZvu4KvpHKr9/br2DAlkDkSIxPImFQi8Y7wys3yhgsTRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=linaro.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+GrOwLyfIS97I8J5B6KE+GSTCG3rf3UHVkzsxHAKe84=; b=Rvh832T4kjtEzL3GZ2FfuvuMjg1QsqJY0uBQeCm6EDG5RbE6SjDOQ5SRTkNvYTrJC5ECMSErrS/Zlsibpa4PtBxtyAA7n8fY4mWimWfkwBYi1nb5ZqjpWEE6J8QYStt4XGKjF89csBKxaYfrQKfegJSxesDUR0vFsBJsD5DaZet/Xv6Qekn1oDRHN9+VNqYvktD0ra62jzdbPD+Pu4LGGdgjty8EaUvTAjLvS/F3gd+efjOG+8HLIJNUuwM6ajmpyUVjDTZN6OpTxHYoVKoxj2h5PbIlzNXXGkYgcyAtvKXpVj6OmHc6SxsYV52eQ+AveKY6D8i6IGepJWbDoivMeg== Received: from PH8PR07CA0041.namprd07.prod.outlook.com (2603:10b6:510:2cf::29) by DS0PR12MB8575.namprd12.prod.outlook.com (2603:10b6:8:164::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Sat, 12 Oct 2024 04:56:39 +0000 Received: from CY4PEPF0000EDD4.namprd03.prod.outlook.com (2603:10b6:510:2cf::4) by PH8PR07CA0041.outlook.office365.com (2603:10b6:510:2cf::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.20 via Frontend Transport; Sat, 12 Oct 2024 04:56:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EDD4.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.13 via Frontend Transport; Sat, 12 Oct 2024 04:56:38 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 11 Oct 2024 21:56:21 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 11 Oct 2024 21:56:21 -0700 Received: from Asurada-Nvidia (10.127.8.9) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Fri, 11 Oct 2024 21:56:19 -0700 Date: Fri, 11 Oct 2024 21:56:18 -0700 From: Nicolin Chen To: Zhangfei Gao CC: , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 14/16] iommu/arm-smmu-v3: Add arm_vsmmu_cache_invalidate Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD4:EE_|DS0PR12MB8575:EE_ X-MS-Office365-Filtering-Correlation-Id: 311e08ca-ea69-499c-cc5e-08dcea7a417f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8A2vgnW3O4ysfcmqzCA5Q8YPH51LWJCdrxAQHA0omOPl8Igywyd0bWbMJOwW?= =?us-ascii?Q?PCIZnGfUBjKoDkmIeP47KS6Q678pkub9ELrjjxgQ63c8KyggpZeOSrxCZLOW?= =?us-ascii?Q?qJbRn8oRvimohAk8y1hZ5ViaGD0zxXJwq5aGYawk44629ecuWQsG83oyBgVL?= =?us-ascii?Q?vSxa/atLPzFax3N9PsUs4Qp1Qkp0rGVBVlN5mxdxWcoki3XkfIaNdIWqE8RQ?= =?us-ascii?Q?np/Aezo8B9aAIdIsmTDXFPZywv+cVAvH2ICbMs+AFOPy1tPfsWA+Puae94aP?= =?us-ascii?Q?W9ie41hocP83rDI5g7emwr8f6DyxR4GaKRn/+kZUaWGFOf+yGg3J10+91JWm?= =?us-ascii?Q?vfRB2cUzk+Pbr9lbjucsnK7Zz9bnzvifP8edVPMb/o5xpa7jZAI2dWbhtNqi?= =?us-ascii?Q?CvX8i31c0gCQWbT7RklhmLqUMFZi8wEEBUoM1HXZ20re1jYadSp4udoxL65W?= =?us-ascii?Q?12q/BkNMpGgtUVf5sWkGUxkuaoo+ac+0a5pUDZM4UMlSa419VlDyMAzBCEsv?= =?us-ascii?Q?/BCzH/cMxQGTLnGTIu8HDUEL+Rn6WbulL7MPknptbgw88R7Zo8pSthRMw4La?= =?us-ascii?Q?nxO0waP2sEUUFrhjijmFM27294FPH7G9dIsp8u6VUrcluuLgsT3BBHr4aaB+?= =?us-ascii?Q?eho5FmhoitlkTSsmskGsDpAxoD3TSk+10MfEMydT7erh/ak+g2EEKMtgvywJ?= =?us-ascii?Q?cn1uQ/Fb+MiRZDPS/0Ww73pkK+g/ZL2p7w1PvUPaJHPNR/9DdE423tublMQS?= =?us-ascii?Q?9unNQl4rnGdFdmIlWPpD4zvcFXNSv+V5jE35Zyd9u0LH2R2ILT4sZXAz5zMi?= =?us-ascii?Q?IMH0JO4HAoHOYmK41Yg3M+UruawOuI2qRpcNH2pFp86J62hNIQHLP/RIOvcn?= =?us-ascii?Q?wstmHoLxaqRETECeaHlZcMSelNBNTlu/JzoWmPGO74jeWkJenz4rfYQGtZCj?= =?us-ascii?Q?H0cazL74Hs5i2rlcavWTHyEX9Ii5dROqxfNqVAf/YtCaKfFX7XWOF/JPyn2c?= =?us-ascii?Q?kq5VQKhdvE7vp98WOOZ2y8Z2U08bdeH96qJDpDkDTrnDmANj2b12+XmjnFfj?= =?us-ascii?Q?X0RFDlF3MD/FiH+kLbU3ZcqOr16gBpc9VR/cnIqzx9bSoDbwTSnzBKboJiz9?= =?us-ascii?Q?SCH/IGPdOTzR8bwfevHp/WogR8wXz/uf+rauS7VPIRWSd2ak/wD3/gRN+Vve?= =?us-ascii?Q?xO0KsK13v81Rm3C2QYeqBULUR49XPcd6HRmhcUWfg9l3kzLoxTI1x2bTSXvM?= =?us-ascii?Q?2gYCjr7p/SabQvtlkjxJbgVHsfNEW/ABWFh/axKAXshY8rVJOu1616K3tvaN?= =?us-ascii?Q?rMHW/hKXlWTTOUJ3Te4ymYsnFsTVE7WTM49NCp+lRWEsKE+7GbJQgra3W5IV?= =?us-ascii?Q?x9xxZO4=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2024 04:56:38.4165 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 311e08ca-ea69-499c-cc5e-08dcea7a417f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8575 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_215645_106691_0B3AAD04 X-CRM114-Status: UNSURE ( 8.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 12, 2024 at 11:12:09AM +0800, Zhangfei Gao wrote: > > + case CMDQ_OP_ATC_INV: > > + case CMDQ_OP_CFGI_CD: > > + case CMDQ_OP_CFGI_CD_ALL: > > + u32 sid, vsid = FIELD_GET(CMDQ_CFGI_0_SID, cmd->cmd[0]); > > Here got build error > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c:302:3: error: a > label can only be part of a statement and a declaration is not a > statement > 302 | u32 sid, vsid = FIELD_GET(CMDQ_CFGI_0_SID, cmd->cmd[0]); > | ^~~ > > Need {} to include. > case CMDQ_OP_CFGI_CD_ALL: { > ... > } Oh, yea. Will fix. Thanks! Nicolin