From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BB4ECFC52C for ; Mon, 14 Oct 2024 09:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2X9BKcyiJ150OFzE266PQZIFJHfiSEZtaVjJkyfQ3gM=; b=qDSc/tpOraqgN6SYaEU9QIpol9 qu7MLK+avwOLf70QBbQYgMhxyzte96MKvLG9rtvVuvBRBBmEOzcD7KH08d6Lk9WR5hF6qjHQvALBM UncGi8hCrMOb337AhUfO0RzEjn6i5MTflT9Iay1dsn8l+FJOxQtB6lsklXXiJLKXDCyu0ii4mO8zU kKE4eVK5NhOrGMEpk5D1C1ctPRkaDdfdLCczi/JU5AT+pmJ0yltiZEH8LelpUgTVJ6j+OlnUPpsLM 6XgHZW3oLbIQ14NLTmmexppl/sk3pjSkAalFm110gn1sE+sCUFL1xAQ2XkR6O7T6YwIGdi0xA4wfO 3+fVTHYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0Hct-00000004ZoO-1HBD; Mon, 14 Oct 2024 09:44:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0HEf-00000004U4n-3yt2 for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 09:19:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B27901007; Mon, 14 Oct 2024 02:19:56 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 375EA3F71E; Mon, 14 Oct 2024 02:19:26 -0700 (PDT) Date: Mon, 14 Oct 2024 10:19:23 +0100 From: Mark Rutland To: Ba Jing Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robin Murphy Subject: Re: [PATCH] perf: arm-ccn: remove unused macros Message-ID: References: <20241012091629.2369-1-bajing@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241012091629.2369-1-bajing@cmss.chinamobile.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_021930_060979_F5C18791 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 12, 2024 at 05:16:29PM +0800, Ba Jing wrote: > By reading the code, I found these marcos are never > referenced in the code. Just remove them. > > Signed-off-by: Ba Jing These are control bit values, so I don't see a strong reason to delete them unless we're certain we're not going to use them in future. Anyhow, Robin Murphy wrote this driver, so its up to him. Please Cc him for any changes to this driver in future. Mark. > --- > drivers/perf/arm-ccn.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c > index 5c66b9278862..ea878b025d32 100644 > --- a/drivers/perf/arm-ccn.c > +++ b/drivers/perf/arm-ccn.c > @@ -28,12 +28,7 @@ > > #define CCN_MN_ERRINT_STATUS 0x0008 > #define CCN_MN_ERRINT_STATUS__INTREQ__DESSERT 0x11 > -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__ENABLE 0x02 > -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLED 0x20 > #define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLE 0x22 > -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_ENABLE 0x04 > -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLED 0x40 > -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLE 0x44 > #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__ENABLE 0x08 > #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLED 0x80 > #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLE 0x88 > -- > 2.33.0 > > >