From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
james.quinlan@broadcom.com, f.fainelli@gmail.com,
vincent.guittot@linaro.org, etienne.carriere@st.com,
peng.fan@oss.nxp.com, michal.simek@amd.com,
quic_sibis@quicinc.com, quic_nkela@quicinc.com,
dan.carpenter@linaro.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v3 6/7] dt-bindings: firmware: arm,scmi: Add missing vendor string
Date: Mon, 28 Oct 2024 12:22:54 +0000 [thread overview]
Message-ID: <Zx-CHlAb61FWdzkA@bogus> (raw)
In-Reply-To: <20241028120151.1301177-7-cristian.marussi@arm.com>
On Mon, Oct 28, 2024 at 12:01:50PM +0000, Cristian Marussi wrote:
> Recently introduced max-rx-timeout-ms optionao property is missing a
> vendor prefix.
>
> Add the vendor prefix from the original committer.
>
It should be "arm," not "nxp," just because NXP happens to introduce that.
It just highlight that the property is X vendor specific and here it is
associated with SCMI and specifically Arm SCMI, so "arm,". If for some
reason nxp or any other vendor overrides this definition and need to add
additional property then they can add their own vendor name into that
property.
If there are no objections, I can fix it up when applying.
> Fixes: 3a5e6ab06eab ("dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-ms")
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> Note that this fixes a commit that has been merged in v6.12-rc1...so it
> should not present any backward compatibility issue.
> ---
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 9d6e1147f9e9..e331da4d606b 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -124,7 +124,7 @@ properties:
> atomic mode of operation, even if requested.
> default: 0
>
> - max-rx-timeout-ms:
> + nxp,max-rx-timeout-ms:
> description:
> An optional time value, expressed in milliseconds, representing the
> transport maximum timeout value for the receive channel. The value should
> --
> 2.47.0
>
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-10-28 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 12:01 [PATCH v3 0/7] Expose SCMI Transport properties Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 1/7] firmware: arm_scmi: Account for SHMEM memory overhead Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 2/7] firmware: arm_scmi: Calculate virtio PDU max size dynamically Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 3/7] dt-bindings: firmware: arm,scmi: Introduce more transport properties Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 4/7] firmware: arm_scmi: Use max_msg and max_msg_size devicetree properties Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 5/7] firmware: arm_scmi: Relocate atomic_threshold to scmi_desc Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 6/7] dt-bindings: firmware: arm,scmi: Add missing vendor string Cristian Marussi
2024-10-28 12:22 ` Sudeep Holla [this message]
2024-10-28 13:17 ` Cristian Marussi
2024-10-28 12:01 ` [PATCH v3 7/7] firmware: arm_scmi: Use vendor string in max-rx-timeout-ms Cristian Marussi
2024-11-06 7:26 ` [PATCH v3 0/7] Expose SCMI Transport properties Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zx-CHlAb61FWdzkA@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=etienne.carriere@st.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=quic_nkela@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox