Re: [PATCH v2 01/14] dt-bindings: clock: Add RaspberryPi RP1 clock bindings

Krzysztof Kozlowski
2024-10-08T06:38:16Z

On Mon, Oct 07, 2024 at 02:39:44PM +0200, Andrea della Porta wrote:
> Add device tree bindings for the clock generator found in RP1 multi
> function device, and relative entries in MAINTAINERS file.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> .../clock/raspberrypi,rp1-clocks.yaml | 62 +++++++++++++++++++
> MAINTAINERS | 6 ++
> .../clock/raspberrypi,rp1-clocks.h | 61 ++++++++++++++++++
> 3 files changed, 129 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
> create mode 100644 include/dt-bindings/clock/raspberrypi,rp1-clocks.h
>
> diff --git a/Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml b/Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
> new file mode 100644
> index 000000000000..5e2e98051bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RaspberryPi RP1 clock generator
> +
> +maintainers:
> + - Andrea della Porta <andrea.porta@suse.com>
> +
> +description: |
> + The RP1 contains a clock generator designed as three PLLs (CORE, AUDIO,
> + VIDEO), and each PLL output can be programmed though dividers to generate
> + the clocks to drive the sub-peripherals embedded inside the chipset.
> +
> + Link to datasheet:
> + https://datasheets.raspberrypi.com/rp1/rp1-peripherals.pdf
> +
> +properties:
> + compatible:
> + const: raspberrypi,rp1-clocks
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + description:
> + The index in the assigned-clocks is mapped to the output clock as per

How assigned-clocks is related to this? Drop.

> + definitions in dt-bindings/clock/raspberrypi,rp1-clocks.h.

Use full paths, so they can be validated. This applies to all your
patches.

> + const: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: rp1-xosc

Drop clock-names, redundant. Or just "xosc". Hyphens are not recommended
character and rp1 is redundant.

> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/raspberrypi,rp1-clocks.h>
> +
> + rp1 {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + rp1_clocks: clocks@c040018000 {

Drop unused label.

> + compatible = "raspberrypi,rp1-clocks";
> + reg = <0xc0 0x40018000 0x0 0x10038>;
> + #clock-cells = <1>;
> + clocks = <&clk_rp1_xosc>;
> + clock-names = "rp1-xosc";
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c27f3190737f..75a66e3e34c9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19380,6 +19380,12 @@ F: Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml
> F: drivers/media/platform/raspberrypi/pisp_be/
> F: include/uapi/linux/media/raspberrypi/
>
> +RASPBERRY PI RP1 PCI DRIVER
> +M: Andrea della Porta <andrea.porta@suse.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
> +F: include/dt-bindings/clock/rp1.h
> +
> RC-CORE / LIRC FRAMEWORK
> M: Sean Young <sean@mess.org>
> L: linux-media@vger.kernel.org
> diff --git a/include/dt-bindings/clock/raspberrypi,rp1-clocks.h b/include/dt-bindings/clock/raspberrypi,rp1-clocks.h
> new file mode 100644
> index 000000000000..b7c1eaa74eae
> --- /dev/null
> +++ b/include/dt-bindings/clock/raspberrypi,rp1-clocks.h
> @@ -0,0 +1,61 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */

Any reason for different license?

> +/*
> + * Copyright (C) 2021 Raspberry Pi Ltd.
> + */

Best regards,
Krzysztof