Re: [PATCH v2 09/14] pinctrl: rp1: Implement RaspberryPi RP1 gpio support

Stefan Wahren
2024-10-11T10:11:01Z

Am 11.10.24 um 11:03 schrieb Linus Walleij:
> On Mon, Oct 7, 2024 at 2:39 PM Andrea della Porta <andrea.porta@suse.com> wrote:
>
>> The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl.
>> Add minimum support for the gpio only portion. The driver is in
>> pinctrl folder since upcoming patches will add the pinmux/pinctrl
>> support where the gpio part can be seen as an addition.
>>
>> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> This is a nice driver and I find no issues with it, what causes
> an issue is gpiochip_set_names() as pointed out by Bartosz.
> If you can live without the names you can remove that part for
> now and we can merge the driver, then you can add the names
> later when we sorted out how to share that function.
I raised the concerns about missing gpio line names in the first version
of patch, without knowing the real efforts.

So I'm fine with Linus' suggestion, because I don't want to delay the
upstreaming effort unnecessarily.

Regards
>
> Yours,
> Linus Walleij