Re: [PATCH v2 11/14] misc: rp1: RaspberryPi RP1 misc driver

Andrea della Porta
2024-10-25T08:30:43Z

Hi Dave,

On 16:21 Thu 24 Oct , Dave Stevenson wrote:
> Hi Andrea
>
> On Mon, 7 Oct 2024 at 14:07, Andrea della Porta <andrea.porta@suse.com> wrote:
> >

...

> > +static const struct pci_device_id dev_id_table[] = {
> > + { PCI_DEVICE(PCI_VENDOR_ID_RPI, PCI_DEVICE_ID_RPI_RP1_C0), },
> > + { 0, }
> > +};
>
> You need a
>
> MODULE_DEVICE_TABLE(pci, dev_id_table);
>
> here in order to load the module for the cases where it isn't
> built-in. Otherwise you have to manually modprobe the module.

Sure, thanks for the heads up!

Regards,
Andrea

>
> Cheers.
> Dave

...