Re: [PATCH v2 08/14] clk: rp1: Add support for clocks provided by RP1

Herve Codina
2024-10-23T17:17:20Z

Hi Andrea,

On Wed, 23 Oct 2024 17:36:06 +0200
Andrea della Porta <andrea.porta@suse.com> wrote:

> Hi Stephen,
>
> On 15:08 Wed 09 Oct , Stephen Boyd wrote:
> > Quoting Andrea della Porta (2024-10-07 05:39:51)
> > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > > index 299bc678ed1b..537019987f0c 100644
> > > --- a/drivers/clk/Kconfig
> > > +++ b/drivers/clk/Kconfig
> > > @@ -88,6 +88,15 @@ config COMMON_CLK_RK808
> > > These multi-function devices have two fixed-rate oscillators, clocked at 32KHz each.
> > > Clkout1 is always on, Clkout2 can off by control register.
> > >
> > > +config COMMON_CLK_RP1
> > > + tristate "Raspberry Pi RP1-based clock support"
> > > + depends on PCI || COMPILE_TEST
> >
> > A better limit would be some ARCH_* config.
>
> I've avoided ARCH_BCM2835 since the original intention is for this driver
> to work (in the future) also for custom PCI cards with RP1 on-board, and not
> only for Rpi5.

Maybe depends on CONFIG_MISC_RP1 ?
CONFIG_MISC_RP1 enables the RP1 PCI driver

Best regards,
Hervé