Re: [PATCH v2 14/14] arm64: defconfig: Enable RP1 misc/clock/gpio drivers

Andrea della Porta
2024-10-28T10:42:35Z

Hi Krzysztof,

On 08:32 Tue 08 Oct , Krzysztof Kozlowski wrote:
> On Mon, Oct 07, 2024 at 02:39:57PM +0200, Andrea della Porta wrote:
> > Select the RP1 drivers needed to operate the PCI endpoint containing
> > several peripherals such as Ethernet and USB Controller. This chip is
> > present on RaspberryPi 5.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > arch/arm64/configs/defconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 5fdbfea7a5b2..5fcd9ae0d373 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -609,6 +609,7 @@ CONFIG_PINCTRL_QCM2290=y
> > CONFIG_PINCTRL_QCS404=y
> > CONFIG_PINCTRL_QDF2XXX=y
> > CONFIG_PINCTRL_QDU1000=y
> > +CONFIG_PINCTRL_RP1=y
>
> Module, that's not a SoC component.

This driver was born as a builtin only one, indeed it is bool and not
tristate in Kconfig and is registered through builtin_platform_driver().
Hence I've set it =y in defconfig. A quick check transforming it to be
dynamically loaded as a module confirm that something is not working, and
I agree with you that, in theory, this should also be a loadable module.
I need some investigation on that though...

Many thanks,
Andrea

>
> > CONFIG_PINCTRL_SA8775P=y
> > CONFIG_PINCTRL_SC7180=y
>
> Best regards,
> Krzysztof
>