linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Assign "media_isp" clock rate
@ 2024-09-24  7:12 Liu Ying
  2024-10-17  8:43 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Liu Ying @ 2024-09-24  7:12 UTC (permalink / raw)
  To: devicetree, imx, linux-arm-kernel, linux-kernel
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam

Commit 2d39b78e5716 ("arm64: dts: imx8mp: Add DT nodes for the two ISPs")
added a new phandle to the "assigned-clocks" property of media_blk_ctrl
node just before the phandle for "video_pll1" clock in i.MX8MP SoC device
tree so that "media_isp" clock rate is assigned to 500MHz by default.
However, it missed updating this relevant board device tree where the
relevant "assigned-clock-rates" property is changed to set a new rate
for "video_pll1" clock.  This causes the "media_isp" clock rate being
wrongly set to the "video_pll1" clock rate and the "video_pll1" clock
rate being untouched.  Fix this by assigning "media_isp" clock rate
explicitly to 500MHz in this board device tree.

Fixes: 2d39b78e5716 ("arm64: dts: imx8mp: Add DT nodes for the two ISPs")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 .../arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts
index 3c2efdc59bfa..30962922b361 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts
@@ -71,6 +71,7 @@ &media_blk_ctrl {
 	assigned-clock-rates = <500000000>, <200000000>, <0>,
 		/* IMX8MP_CLK_MEDIA_DISP2_PIX = pixelclk of lvds panel */
 		<68900000>,
+		<500000000>,
 		/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_LDB * 2 */
 		<964600000>;
 };
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Assign "media_isp" clock rate
  2024-09-24  7:12 [PATCH] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Assign "media_isp" clock rate Liu Ying
@ 2024-10-17  8:43 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2024-10-17  8:43 UTC (permalink / raw)
  To: Liu Ying
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
	conor+dt, shawnguo, s.hauer, kernel, festevam

On Tue, Sep 24, 2024 at 03:12:18PM +0800, Liu Ying wrote:
> Commit 2d39b78e5716 ("arm64: dts: imx8mp: Add DT nodes for the two ISPs")
> added a new phandle to the "assigned-clocks" property of media_blk_ctrl
> node just before the phandle for "video_pll1" clock in i.MX8MP SoC device
> tree so that "media_isp" clock rate is assigned to 500MHz by default.
> However, it missed updating this relevant board device tree where the
> relevant "assigned-clock-rates" property is changed to set a new rate
> for "video_pll1" clock.  This causes the "media_isp" clock rate being
> wrongly set to the "video_pll1" clock rate and the "video_pll1" clock
> rate being untouched.  Fix this by assigning "media_isp" clock rate
> explicitly to 500MHz in this board device tree.
> 
> Fixes: 2d39b78e5716 ("arm64: dts: imx8mp: Add DT nodes for the two ISPs")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>

Applied, thanks!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-17  8:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24  7:12 [PATCH] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Assign "media_isp" clock rate Liu Ying
2024-10-17  8:43 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).