From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EB79D21272 for ; Thu, 17 Oct 2024 11:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/5y0ypsfWq7EM2KRl4pjCSLN0M/AE8QUTI2X2N4U0hY=; b=VggmAYtmeqjwZlzFSs8x6vb2ry GqmXhgUy8EsFpRM5B+kzF0TAeZr0wHeXoNWGplU97JnsfT2BGjDHm/bTVOShQL4kYYzLrzY3DHTMj kAvafZfxt5YKq8C1TfR7VOChR5EIw/VT41qfKNQaB7M0W6uAOHPFYmPD6s6ghtdacG9EYR1xMkP2G uLu7dNabubvVP2Plzvd1KAxS8IVjnnz/eUEKZ68JyI2f+PEaKgvRen8XZ0s7bB401tcw/1sD10Z2n Il+QHNcZM7tptYdeV1w3zznQWYuyvtDAl4NohIoeIBO8VGyXA4DT7263R7GFlFA+S0bxPdp9vqElR GmcMk1EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1OG6-0000000EZfK-0B3B; Thu, 17 Oct 2024 11:01:34 +0000 Received: from zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1O0i-0000000EXqu-3C3w for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 10:45:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=/5y0 ypsfWq7EM2KRl4pjCSLN0M/AE8QUTI2X2N4U0hY=; b=HllfLsOiSWvJ6YQMcw05 CIZu/zpLjm9y9XdHu32UmKfmhK8yZ0Em61+QHu48vt/rReZqr2A75c5ebtWd1dVg +qJ/1W7fhiYtkhGUSuZXcGWmwV65cyFUHi157A4CORMXHIvEXajsv4VORx7S2Gra Mi73/ozkoDlc0AclHnKNLmLa3idXML51+6PumRav1ztPDMEkdPiHP8mZ8TSvWLGa 4Vrm5kh3kSxb/zShgpC5TNfSvb3OyTztIx9Vg8J1dpkcJUfCbYjr04kgmm//CDtG INmFzS/TKIZfb7PcisBuTDawK4sZxps95VIgqm8gX84sk6Z6qMytP+p0Vs2p9o6w hQ== Received: (qmail 3353394 invoked from network); 17 Oct 2024 12:45:34 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 17 Oct 2024 12:45:34 +0200 X-UD-Smtp-Session: l3s3148p1@t6/R4qkkC0BtKPEX Date: Thu, 17 Oct 2024 12:45:33 +0200 From: Wolfram Sang To: Claudiu Cc: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea , kernel test robot Subject: Re: [PATCH v3 06/12] rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S SoC Message-ID: Mail-Followup-To: Wolfram Sang , Claudiu , geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea , kernel test robot References: <20240830130218.3377060-1-claudiu.beznea.uj@bp.renesas.com> <20240830130218.3377060-7-claudiu.beznea.uj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y12kh0Tsg/wH5L1d" Content-Disposition: inline In-Reply-To: <20240830130218.3377060-7-claudiu.beznea.uj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_034541_702594_874269BC X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --y12kh0Tsg/wH5L1d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, sorry for being late to the game. I just noticed this series and wonder... > +/* Counter registers. */ > +#define RTCA3_RSECCNT 0x2 > +#define RTCA3_RSECCNT_SEC GENMASK(6, 0) > +#define RTCA3_RMINCNT 0x4 > +#define RTCA3_RMINCNT_MIN GENMASK(6, 0) > +#define RTCA3_RHRCNT 0x6 > +#define RTCA3_RHRCNT_HR GENMASK(5, 0) > +#define RTCA3_RHRCNT_PM BIT(6) > +#define RTCA3_RWKCNT 0x8 > +#define RTCA3_RWKCNT_WK GENMASK(2, 0) > +#define RTCA3_RDAYCNT 0xa > +#define RTCA3_RDAYCNT_DAY GENMASK(5, 0) > +#define RTCA3_RMONCNT 0xc > +#define RTCA3_RMONCNT_MONTH GENMASK(4, 0) > +#define RTCA3_RYRCNT 0xe > +#define RTCA3_RYRCNT_YEAR GENMASK(7, 0) ... if it has been considered to expand the existing rtc-sh driver? The register set looks identical up to RMONAR. From that on, it looks a different. Maybe the different offsets and bit positions could be abstracted away by some sh_rtc_{read|write} helper? Or is there some other new handling which makes re-using rtc-sh cumbersome? Thanks and happy hacking, Wolfram --y12kh0Tsg/wH5L1d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmcQ6skACgkQFA3kzBSg KbZzFhAAkxKvkdBgA6qdjGdJIVpKSuaZugMZFjvBRXw6WR7IP65QB6OP7P0GHUE1 OX2i57KUnQfkce0KYw5Ak+rFvPGkE/KbVTJcqno9UyiqhL7MjoRj0sAbOe7z/N3N NSZ+gOyAdCYkQ+yau/XhyWoFntbFKEbIknhN7agIm9eTqO5weEwC7hlIoX4JVq2t +lZ0uMjAhf/QNnNaEeiCWMnZ+ltJuO9gNdFIGwef4dox6LiNy1JSRIy6627N3gx/ 8Lc6ap6k7sKW/4FLxoKkL/7CDfNdx8LlJZH/RgQ1Cvy8kUZ5qUctssDX2sgYz3uL V8G/t5cNfjafZd1z5pPbQRpyBG6S8YLRF/TfpekvY/fFgKWsFKoZGSikMsxx3Wua 3c6dCIp4Bau60iWXCMxdpdP69k16KEgD8EkM4gap24Is14yoyq9VbZXej0pBQfne ak5w6P10ddga+AJu//ghA3ML1ZmY12f/jtDMiKDr7iFq0jLaKu9lBlAUbQeoOMQY eC4K555DNJYlTr5cFUa2obs9w/+9ATc+wiMYuetNccVnpmcdmoPcUBf2Zo3jSuqz hdo9kmzqcerK9YZHhYHCZwnBxl+h4ga9DGMFVJ6dbbiAD5x1Dk5LuOHd9X62b0+8 H6zskyMykGIuxTlkr0rNkUHDHLpu4XYafiCsyGKSetE2hW66Tu0= =bN8G -----END PGP SIGNATURE----- --y12kh0Tsg/wH5L1d--