From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D6DD3C526 for ; Thu, 17 Oct 2024 16:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y7jRaz87u+3UHHkX3f2TYygRKWgQGJMXvoAs9WJFmzE=; b=PTs8JjSKmWsvD3wMbU+fy/kgoA IeL86MuX+/5H0M2R0PrssYQYl0m1D+Y2d28CD53omU+kso0okLzEFesf3yZrHY11z00ojWS2yrBQM inZeaauVYkhLc5Ql7yLrWMzWViGSKIm268pdUx5fAGydCw2Nq8iY1fE+7hAONHASL9JcOQa4FCNfZ fVpAE/kZHuv5ofOQk6xhH7lB4LUNYnyXKqWl/dsSHYurXbw4NYKRruA2moecnl68BvOcUb8vDBQ1G foyvp17WSyf4fYybDa7OF57A2KG1CKfpcgrvBnudcrej5UQpEXBuXS515TCQrgpsuMAKQFIC0MNQ+ MvyhNlzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1TpD-0000000Fbvs-10Ma; Thu, 17 Oct 2024 16:58:11 +0000 Received: from mail-bn8nam11on2062c.outbound.protection.outlook.com ([2a01:111:f403:2414::62c] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1TgD-0000000FZow-4BQD for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 16:48:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PRyroLVHcOgH1MNQO99xhwZxmhb1ktKrornnRsijhjACOszfIzN4p59YcfZsZuUp4DIJbWNnRm9mv7O9fct5ULniaDN62ncVO3AdJlr2ModriNxWxvokLjKxLQTVj4tZBOHVprhQD7EPy9etlbt+V1ceoMoXntKNqrmQzh22/5RDuuhUIoG/uiB5n27ecA7CTQFHn4iU/s4jEhnupqaoGH6UZQHD/Pr7A3eftld0FlfTNl83LA/9DA1yz/gdb0kPAK4g/g8bs+8K8vzitJF9QtgQqGGigG8b53r33cxQ8p1knbPoSJwlluWxzIj2riaT69SZ92Vy2CcB2n926oIthA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y7jRaz87u+3UHHkX3f2TYygRKWgQGJMXvoAs9WJFmzE=; b=K4dviptUS8vRCs3vokVaoDi/2yiamXu2ekY1s8OXbf4fMsvQErQGLWGYP44V0HMIysEiGVLD4N+1ZfvyYQVhtmOKYHkvste6Ke5hBFGUxSCnsx0yrUbux71/TpN9DpJEINWR8+hPv8n6Dcxo5lOLUxCHU+ZrTYhHUx1HtzdvstngL9aWGnlSu7k9Js643gHcay71mMvi2OzmwR9KYDfgjnI47c1Ru25WZz0SBtamNf/RjvNRLZHRKFyak1dvFrItJRBpv3m1WOGEvoeCQxYKx2b3LdJRYKhARkczA0Q4jiuEDCfGChyHFHQ9rzixvpE5SInYDakei0qoXpA7u7kLRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y7jRaz87u+3UHHkX3f2TYygRKWgQGJMXvoAs9WJFmzE=; b=ozGWtMcCrA7/agEguckWbBKQ0hELMa2TC0BVEpZ5uzPe4fywQksEhu4gLycDhxlXc4VbJws8H1hDzwVKv8zrEsTK6/LKgGRrbanUurH3XMtkEJqcNtFdz0Ht42iDPTK6UQRbnOn3HCrSjtsON3WwV85wbazyPfjoc1vO+6hrZaimICPZvFav6NvGkJDVgaOg3rR0Fn2K3w1xA0HEimeHChQwqUmhjkewiQ1cLWoY80IOmNuWS3CW+l5iasIdwhMJ646D+4fDF5KBP5zwRKUvqRijShNwW90nWUp8W38mHZ8QmvnaDq9wmcHnQRmQlSGvHYDkLw7+/LCE15nwuwALJQ== Received: from BN8PR07CA0030.namprd07.prod.outlook.com (2603:10b6:408:ac::43) by CY8PR12MB7587.namprd12.prod.outlook.com (2603:10b6:930:9a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Thu, 17 Oct 2024 16:48:41 +0000 Received: from BL6PEPF0001AB57.namprd02.prod.outlook.com (2603:10b6:408:ac:cafe::4a) by BN8PR07CA0030.outlook.office365.com (2603:10b6:408:ac::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20 via Frontend Transport; Thu, 17 Oct 2024 16:48:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BL6PEPF0001AB57.mail.protection.outlook.com (10.167.241.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.17 via Frontend Transport; Thu, 17 Oct 2024 16:48:40 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Oct 2024 09:48:26 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Oct 2024 09:48:26 -0700 Received: from Asurada-Nvidia (10.127.8.11) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Thu, 17 Oct 2024 09:48:25 -0700 Date: Thu, 17 Oct 2024 09:48:23 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 02/11] iommufd: Rename _iommufd_object_alloc to iommufd_object_alloc_elm Message-ID: References: <20241017141416.GZ3559746@nvidia.com> <20241017153749.GA3559746@nvidia.com> <20241017163507.GC3559746@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241017163507.GC3559746@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB57:EE_|CY8PR12MB7587:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fa1ad08-6e81-4ee7-da49-08dceecb8e01 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|82310400026|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tGXmscu3gSRKWO3iq6VIk98XpdMfvYBLf/6qlNavIhlwFbTb0A+D0qeMElcX?= =?us-ascii?Q?Mf9UFkVS0rXnERPsbfpriQ7alwkZGDx0kKlA+rUR3TG45oe8PFWp0lk5VwpI?= =?us-ascii?Q?0GSyWc5kiRiJohpRtPOUW1HNbXhUtCNaPN1kgG2KFj6xPtpLaVlJwvBmV786?= =?us-ascii?Q?8t86LGwVvR9liwywQ3vMqI5CtfbwK9lc7LNRWcfx5LvRG2B4jH2hM76PqoEp?= =?us-ascii?Q?lGUoBYIfdVAYj1sBtNGYGD4+lWEr5IDRU+1nXv+RMQYCQddIEMcZIc3zqWb6?= =?us-ascii?Q?+HrdTtfoabHAkutiPdqdGCtpx6m6f90MIPFSxEDkmbwXi1XE5s1/v1ULJXwH?= =?us-ascii?Q?2kFTYJ6dpk6upEhGK5kgGKYdMo7zH0OZV/06u2u+zQLABd8IWvaHAm1NBk5w?= =?us-ascii?Q?kTUPJ5BRm6TkEVjQKK1q1eAeeYCh9EObmbC0mrj/JydAjesQ4MtYfjo+mkhp?= =?us-ascii?Q?qHkSdO6NJO3Fbs/LZLyFG25ywZQxo2ijPA1qYtAL3VxBzBsrEU7FIS4Ui9nK?= =?us-ascii?Q?cNzuU25SEuTU6hWqeFd3tggu/O+R7rKHLTOj4ikX79NFOEvdNGWVjyJrUDj9?= =?us-ascii?Q?I5RWMh9SC/GTnRkz9q0+cEac9nPAplobbGZ3KTaNtWlJtp1ojTn0y7++9spo?= =?us-ascii?Q?Wz7D6dyZmplqCBenO/1omfj1k+4IC3xyYXIqol/3MYa14br/UHvXXlsiTw3q?= =?us-ascii?Q?lgxW1XmDD5MhZu9EvvkfN9JaBO5bU9wFtBrYUULTT4JvfkMsgMCuUbDStAq2?= =?us-ascii?Q?/VUAnZx1o4/xdd6imS/WlrYWsJAPkVV1zVLM0WVfXA1+48/tLlLEEcoY1+B0?= =?us-ascii?Q?pyFS2xJeb2Xny+pgtZZZzqiWJbg1tp6tA7zqk4UJhE7ySxkWqOmYUbYgETgJ?= =?us-ascii?Q?jG5JEspB5Qd+GYdQ+DvSLRWD/eR3Csa7o3k4CSO14A5CKZo2Pm4U+rW6dIMw?= =?us-ascii?Q?N8hoRBqs8M8VHsqjVSDvvjxPfCs4z7ORgkQNGivzGlf2RJDUZ5u9OVjNt5St?= =?us-ascii?Q?RjJOpbGpNd6W1HGFkdFbUtVbYR1gxNHPgQiGj4Fef5/TXNsJW94Y/uttjcQz?= =?us-ascii?Q?E2s/IwzebHemwBRkk8CiB+zxSnlv3U9pNwJIJ+QU1aQjnrXHCgFJFsVWJcxQ?= =?us-ascii?Q?/DivQGRmHGe0V3Vh4YLT2+cGZavIs8InR+7guG8XqS1Y28s/iOovkvREV53+?= =?us-ascii?Q?HbxtgbhS9I3e5fOWQrUgJczmMx/w1aMPa6ozWSxi/i7oxIy6mBtC3qRpRCT+?= =?us-ascii?Q?muoOeAizfTuPuYgiGLPtapK9vB0HsdJJwlBPxbz167P9glx8Twb+icyzryxc?= =?us-ascii?Q?RAGn9ATISQ6EtSdSwTG+u7F85gRAj4nP2s/TGyfGZUpEOnKll3E7pp2MScIt?= =?us-ascii?Q?VCyO/sY0p8wJU6G1FPoju+scoTk9+XIIJpT8cx64UQHg+tIsJw=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(36860700013)(82310400026)(7416014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2024 16:48:40.6150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fa1ad08-6e81-4ee7-da49-08dceecb8e01 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB57.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7587 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_094854_047949_1349C9ED X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 01:35:07PM -0300, Jason Gunthorpe wrote: > On Thu, Oct 17, 2024 at 09:12:03AM -0700, Nicolin Chen wrote: > > > > Then you can keep the pattern of _ being the allocation function of > > > the macro > > > > If I get it correctly, the change would be > > [From] > > level-0: iommufd_object_alloc() > > level-1: __iommufd_object_alloc() > > level-2: _iommufd_object_alloc() > > [To] > > level-0: iommufd_object_alloc() > > level-1: iommufd_object_alloc_elm() > > level-2: _iommufd_object_alloc() > > > > i.e. change the level-1 only. > > You could also call it _iommufd_object_alloc_elm() to keep the pattern > > Maymbe "member" is a better word here than elm Ack. level-0: iommufd_object_alloc() level-1: _iommufd_object_alloc_member() level-2: _iommufd_object_alloc() Thanks Nicolin