Re: [RFC PATCH v1 17/57] kvm: Remove PAGE_SIZE compile-time constant assumption

Sean Christopherson
2024-10-14T21:38:54Z

Nit, "KVM:" for the scope.

On Mon, Oct 14, 2024, Ryan Roberts wrote:
> To prepare for supporting boot-time page size selection, refactor code
> to remove assumptions about PAGE_SIZE being compile-time constant. Code
> intended to be equivalent when compile-time page size is active.
>
> Modify BUILD_BUG_ON() to compare with page size limit.
>
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>
> ***NOTE***
> Any confused maintainers may want to read the cover note here for context:
> https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/

The patch should still stand on its own. Most people can probably suss out what
PAGE_SIZE_MIN is, but at the same time, it's quite easy to provide a more verbose
changelog that's tailored to the actual patch. E.g.

To prepare for supporting boot-time page size selection, refactor KVM's
check on the size of the kvm_run structure to assert that the size is less
than the smallest possible page size, i.e. that kvm_run won't overflow its
page regardless of what page size is chosen at boot time.

With something like the above,

Reviewed-by: Sean Christopherson <seanjc@google.com>