From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60A4ED374AE for ; Thu, 17 Oct 2024 16:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=blovz4XahmJ780u6GSrk6+xwpoU36JvN/WTpG0COjjU=; b=0xz9KXxqmmxjB42Issb0J8vUw9 i5a3m3cEt/bMZZ24gdgPd51tqNuGAeY+pSX4/rtGQ/WC5aaxAEZIQbhRh2izWNvVT8qrd3MkG41hp 7XxryfGVncfnLp2acEEHpkhQJPSjKubKt4a4901/2j2bp2ZHSdgcamIZgPd7RjUDtQCHl4nY3VvtU jft/GqtrXsKT2fg6f6MAtCZqfjEri1Q9OCDGvKTHbeH2Z/vpkPnUGDT/IoubN33AL4lt/8W6q+NW2 cu94SrD9sF4rgaPPm9ygxkgXyjsTCyX5lWy7qShlJbn/nh862xbjgojCplZk5zkJ3hopqclKOI76s P4s6ZXQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1SvT-0000000FOKT-17S8; Thu, 17 Oct 2024 16:00:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1Skp-0000000FMJd-0W5p for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 15:49:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51175FEC; Thu, 17 Oct 2024 08:50:04 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 565D93F71E; Thu, 17 Oct 2024 08:49:32 -0700 (PDT) Date: Thu, 17 Oct 2024 16:49:29 +0100 From: Dave Martin To: Kevin Brodsky Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, aruna.ramakrishna@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jeffxu@chromium.org, joey.gouly@arm.com, shuah@kernel.org, will@kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/5] arm64: signal: Remove unused macro Message-ID: References: <20241017133909.3837547-1-kevin.brodsky@arm.com> <20241017133909.3837547-2-kevin.brodsky@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017133909.3837547-2-kevin.brodsky@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_084935_434631_A1A692A1 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 02:39:05PM +0100, Kevin Brodsky wrote: > Commit 33f082614c34 ("arm64: signal: Allow expansion of the signal > frame") introduced the BASE_SIGFRAME_SIZE macro but it has > apparently never been used. Nit: Should there be a statement of what the patch does? Same throughout the series. (Yes, I know it's in the subject line, but Mutt doesn't think that's part of the message body, so I can't see it now that I'm replying... and submitting-patches.rst and e.g., maintainer-tip.rst seem to take the same policy, albeit without quite stating it explicitly.) > Signed-off-by: Kevin Brodsky Weird. Maybe there are places where this could have been used, but I guess we have managed fine without it. Or possibly some unmerged version of the SVE patches used this but it disappeared in refactoring. Either way: Reviewed-by: Dave Martin > --- > arch/arm64/kernel/signal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > index 561986947530..dc998326e24d 100644 > --- a/arch/arm64/kernel/signal.c > +++ b/arch/arm64/kernel/signal.c > @@ -66,7 +66,6 @@ struct rt_sigframe_user_layout { > unsigned long end_offset; > }; > > -#define BASE_SIGFRAME_SIZE round_up(sizeof(struct rt_sigframe), 16) > #define TERMINATOR_SIZE round_up(sizeof(struct _aarch64_ctx), 16) > #define EXTRA_CONTEXT_SIZE round_up(sizeof(struct extra_context), 16) > > -- > 2.43.0 > >