From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBD1BD374B0 for ; Thu, 17 Oct 2024 16:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=trDxmIdDVof/QeHNpYCC6CMkbjPbODseZaO53T1kmVs=; b=yyu9q7MthcXodRGVmRVo/eZiw1 eOBumwmCsxhTUSBH1M0MaYDvS0QQHcEt+TX/lOUm6FoEi3i9MAMUvHHKLB6b2DufgiVw0huT0BETt 9GioM8WvcpxDoI1/jYluuOBFAZ9LCkBdxX58jLubEcU1yedYV7Ty6RpdJ2IPqh94t0a5MJr6voo0u cmyQXnaSIH/+u6IlcXktXMltPSsC6kHav9n1Kivw6SAJE7a1RpT9qKgPIVHS9AIyB5YiARlgexxq7 jxfR17xHG0vwOyhGjrZ62T3ChAQMtVxxtXflPRD+KtdkVvBZy3QEpS9VydYAHXz1I+jDMdPE3ii7n QApWX4Bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1Sww-0000000FOiA-07O3; Thu, 17 Oct 2024 16:02:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1Sl5-0000000FMLZ-32ut for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 15:49:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC8E9FEC; Thu, 17 Oct 2024 08:50:20 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 292723F71E; Thu, 17 Oct 2024 08:49:49 -0700 (PDT) Date: Thu, 17 Oct 2024 16:49:46 +0100 From: Dave Martin To: Kevin Brodsky Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, aruna.ramakrishna@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jeffxu@chromium.org, joey.gouly@arm.com, shuah@kernel.org, will@kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 2/5] arm64: signal: Remove unnecessary check when saving POE state Message-ID: References: <20241017133909.3837547-1-kevin.brodsky@arm.com> <20241017133909.3837547-3-kevin.brodsky@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017133909.3837547-3-kevin.brodsky@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_084955_594044_9D357592 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 02:39:06PM +0100, Kevin Brodsky wrote: > The POE frame record is allocated unconditionally if POE is > supported. If the allocation fails, a SIGSEGV is delivered before > setup_sigframe() can be reached. As a result there is no need to > check that poe_offset has been checked before saving POR_EL0; this > is in line with other frame records (FPMR, TPIDR2). > > Signed-off-by: Kevin Brodsky Reviewed-by: Dave Martin > --- > arch/arm64/kernel/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > index dc998326e24d..f5fb48dabebe 100644 > --- a/arch/arm64/kernel/signal.c > +++ b/arch/arm64/kernel/signal.c > @@ -1092,7 +1092,7 @@ static int setup_sigframe(struct rt_sigframe_user_layout *user, > err |= preserve_fpmr_context(fpmr_ctx); > } > > - if (system_supports_poe() && err == 0 && user->poe_offset) { > + if (system_supports_poe() && err == 0) { > struct poe_context __user *poe_ctx = > apply_user_offset(user, user->poe_offset); > > -- > 2.43.0 > >