From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0A37D3C526 for ; Thu, 17 Oct 2024 18:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aSln1DjEuYx6DG4dmnRws1IgdsZyA57Ta38iFBntaEI=; b=CVQ5Jk7SgaAKaIgCvl91rlqC+y tN4Qvia8KgpvmSbQD0cEE4LsXQO8uEjVSG/UQ6vePiqKV/O0G4cpJfnJ6SGmlEh9nOuaowXAK4LZJ xbHBPVTmO9FWGfrBKai+W02XT9bt88HLW0YMm+109htKpPmM2tvAf2UYl6fPhiMgdoiU+cCyitNfg XOCoSuhnKJKsw3230yVnGoK+U78HKxFQVWKv1/ebeqZD2zCIZcKqjYsyQhxlPBrKK1KgcxhGLW7M/ WGYWahRLqonGulfp5Ph6AYNbrLFU/UJe6AfUJPqrlHIe0ol5eygvZ04rVujdMhHmESj+L/8twlFLO eLudP8KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1Vc4-0000000FvyO-2wdW; Thu, 17 Oct 2024 18:52:44 +0000 Received: from mail-dm6nam10on2060b.outbound.protection.outlook.com ([2a01:111:f403:2413::60b] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1VaV-0000000Fvbr-25eX for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 18:51:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yo43EE0yDcNM6tVOOZUlx6KC/C+iGB88BVhEzxsOWpHOXNwX8Cysgq/7wA1/NX2Hcgbq7600BaTNh4lEgDCuluLofF4D7W2Co1vDui3EQBtqKdkp6TxsH8Cet0kbiw8Y3gmB4XNCuAaHXJeH9NTWQ9QZcppgLr70/ZRwM1z7NyOtVQprmmLNmoGPlX2FGC9qjqeINV/yzq3hf2VZ5TqP06styp2DEAuFhbiaCTdg/6zbtVgG8p2WQ0W8lfGXfZIXqEvhLVAAc6Cy00GJYxsGwGLs+FDCx/UXCms33BktVvlHvqk1rMzRnrwTwuoCRvai4AnOSqUFBAYVJ5beteoB1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aSln1DjEuYx6DG4dmnRws1IgdsZyA57Ta38iFBntaEI=; b=QJmcsBasw0sRVSPwQty9zURvbgGW1QFjuXP5VSKFeN0Sv6CfWZdeuNMj5dx4sP0nZ9H26CR2QA/FFfPceWGaM2zGxbWMIY+ot02AciZjmQetoknYnuMHATL29vM8gWt/09SIx7sjwqMtQ86PRHzgY5zkQiiLzViR2dbZg3HmuEdt0q3VgISXYHzvY+3WKQp+Yr87o3DrvkydLj8v/eI17HA8FLiKThPgXSWNOhSY3gDBlvSVIanpaBYsmaSYl016mfe8WuREjQLna1x1+gedBvxWm79r//Iw/fwYMqAbOF15SES4nS+QCNaM3BSV9mdtbWNa7oFmvk6xq16/HzJkMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aSln1DjEuYx6DG4dmnRws1IgdsZyA57Ta38iFBntaEI=; b=JimVA9g2AmdrYbxUQkgnihyO5O+x9f0czqi6XKHG8zZtmtjgR+VP3rkwAHDTfa1yYem3SGYMeoCXnE5AMVdCHaEEgmy3hQ1kFaaJsKeLCDRy1tJSLnCu/aCuJNfK8OHm2B6OIKTh0tXG55p9w+S5uP08Sa3raciZo6WsGbEM2xNmC+wUmkqv4SffxCKNQqUga9BiwgJTABVs/WaqZvknN5jYG7DmERShVGuXOfSM2+RVERsCNev99E8RKHaxcN1C4zVTp55Rv7XJ0G8aimT7PTya/riFyv2VPuDXW2uvuYLq3/ljV6SxJOlV2DyhSqLMpbF/ARfYxg8xHtGOTplFzA== Received: from SA0PR11CA0037.namprd11.prod.outlook.com (2603:10b6:806:d0::12) by MW4PR12MB8612.namprd12.prod.outlook.com (2603:10b6:303:1ec::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Thu, 17 Oct 2024 18:51:02 +0000 Received: from SN1PEPF00026367.namprd02.prod.outlook.com (2603:10b6:806:d0:cafe::7) by SA0PR11CA0037.outlook.office365.com (2603:10b6:806:d0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.19 via Frontend Transport; Thu, 17 Oct 2024 18:51:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF00026367.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.17 via Frontend Transport; Thu, 17 Oct 2024 18:51:01 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Oct 2024 11:50:47 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Oct 2024 11:50:46 -0700 Received: from Asurada-Nvidia (10.127.8.11) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Thu, 17 Oct 2024 11:50:45 -0700 Date: Thu, 17 Oct 2024 11:50:44 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 02/16] iommufd/viommu: Add a default_viommu_ops for IOMMU_VIOMMU_TYPE_DEFAULT Message-ID: References: <20241017184729.GR3559746@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241017184729.GR3559746@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00026367:EE_|MW4PR12MB8612:EE_ X-MS-Office365-Filtering-Correlation-Id: 2307b559-3695-4631-bb37-08dceedca57e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vfdFkVuTGx1b/nZknUz5QvDl4i/GmiVr5l2a1t/V7/guuM/RXRRrpoACuI2W?= =?us-ascii?Q?g3ThRrEE/1TEzeD9I8S4OSTUGKWrf9lJrjCka+IHZOPMYTfp1TRTxsJ5+A/H?= =?us-ascii?Q?glhQBh8ZElf84Yty366aSs1ufGHJQh0NM1zjduHRdASlarCBrSe63j9jGWMb?= =?us-ascii?Q?ia3J2oC1V6URqnnuZo4RzYSjMzRJ6XjCUVQgo/foX6lzX9pZCISaTc6M8EpE?= =?us-ascii?Q?gZZW/NSI9ZnQdBZilI8wwAfafMH0Y2ZigGZJ9kzjxi5dV3PEHAwq7Dng8BQ4?= =?us-ascii?Q?dvJwEHfFLXC2hZdfYB05R7Ujq1aFwO1fCdcGL31Uj0eFTBjEwPpUi2LWcUWt?= =?us-ascii?Q?EOUW9FF829GhEO4JCcTMJtWoOxnIK9Ls4YsBxJzueD9mEWKu3v00yjvBJbaR?= =?us-ascii?Q?kwJOzXX00tg3ykOPGbIzV9WHaRGXbjOL66qrZKf0isTS/IYq4eKAN9Q2YUUP?= =?us-ascii?Q?ZGT0eq2Ktx+9egTFMBWApPeVm7fghSLTZynXBng4aTkhZVSXTjWK1iZtmnzz?= =?us-ascii?Q?XEf4RxTfZkGDDsOZS6rYfsdqVX8YhcIXKJVsg0i146zqGuPLEf1Hmfk0XYNg?= =?us-ascii?Q?Yp9WafTeXZaGfcrxh82lbaoxUr+6L4900Ibv+Xu1IDJWD3FIC2HeFh7HZbrE?= =?us-ascii?Q?1mh/KNZA1U4gQuHp2yDgsxNPbccBv9J9k6cy0Sogw+SBLVyybU866e0n7T5Y?= =?us-ascii?Q?k4MBNMRd0vA8szu/v4H7VwhE2rZg/PVsZHMZ0Ft+L8Z7nnTGM0HdQ6rzt+r+?= =?us-ascii?Q?BH015ResaahTOh0TXEhDn4xiirNJekzFxfuylQtnOG8sEsB4N/UnPCp+Oe1e?= =?us-ascii?Q?jTwO5Ltoz7DZ1L4tjDoIguDHO4s24m3crIEYsNb7zqsFCh2gaiS2+FE/yLAD?= =?us-ascii?Q?lBL7mHxgMpaFyg88xvRZdQep1+fTOoG0zpXRrSe4cH29sQfgNOZbhGCVnbzU?= =?us-ascii?Q?QGFTfeJN5nyRXzQAVT/lIHRl0ujAED4kwvuAJZ3ycJDmjcCtDGElWpFyOdxy?= =?us-ascii?Q?sQd0sHnHaX5+Ye+0Y1vjAXo30k1V7ODfiODd+AUF/myhBmwnB2bmbkngaRRa?= =?us-ascii?Q?8ECTeIx0Aj+6E+94k74cJnaQGPJbLYgymspaK8jqTD+J1vJMzZcmLZijx2Du?= =?us-ascii?Q?hoFQaNL8xrbybb2YTAdSm96utQRRCrSCb3k5u/Qeu8NoyHeLfG1ATNI94eF+?= =?us-ascii?Q?u2tME2h4hzhOXYtDLuB/Llp47NSE/2ewC/DrTZ2EK3XSJ28pxpx2ulYJfHqb?= =?us-ascii?Q?A6iShMGN6227Kori+gufdaMbS3wTmJ0T7jfFujpVxK1/AMXxjhCpl1/7eXPY?= =?us-ascii?Q?eACB8PexgVwiLmRAmE26T/jpl1e9Zlp3k4CdP9WbKzVhEJR29o7u+l3agex0?= =?us-ascii?Q?ojQ5Tth4/TNxzvxQzbmpK7Wcdgw6Wi/KGGtDFkFq8Ej0KKXu0A=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2024 18:51:01.5279 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2307b559-3695-4631-bb37-08dceedca57e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00026367.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB8612 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_115107_563776_A69338A7 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 03:47:29PM -0300, Jason Gunthorpe wrote: > On Wed, Oct 09, 2024 at 09:38:14AM -0700, Nicolin Chen wrote: > > An IOMMU_VIOMMU_TYPE_DEFAULT doesn't need a free() op since the core can > > free everything in the destroy(). Now with the new vDEVICE structure, it > > might want to allocate its own vDEVICEs. > > > > Add a default_viommu_ops for driver to hook ops for default vIOMMUs. > > Why? arm_smmu is now creating its own viommu object, so who will use > this? > > Do we have any use for the default mode? It is already a bit > confusing, can we just drop it? Hmm, that would make the default model completely useless.. Should we unsupport a default viommu allocation? Nicolin