From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DA15D3C53F for ; Fri, 18 Oct 2024 03:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yEk24EEbUheM26KZ9Y5UZSg71Glq65ticUsqrmiR49g=; b=JtbuC/lZbzOkgcwAogQjZGpB6B 72ZUjxfgyf7mDCqULO+O9AhO/AWw+GuLyTAHvMjc7NnMpDES0ObcpGp836QY3bBLBwV3JDKDnKGEr 6ze+xpesYkSUSs4SiSUmKfXRko6rW7r7V8V+WpF1FBCwDu5VMmfcQQPbKbkXfwOX/Z2Ks9KoBIAj1 81fEYrWOLFswEPQdiFZbTSall3ZQz3vdvkRFPc/jkJmszqZnuFp7hosSoDUkc7L9/ZuZ2nOPA17/l 7zWmmKlUGZX6OWDEFwINL0x5vW/Kmz81Vqjw5w3UgYpb+TRqajoT0GD8Suu7RYI2mMyCxy7m9A+PB Cs7kjtlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1dVt-0000000GlVZ-1Kt1; Fri, 18 Oct 2024 03:18:53 +0000 Received: from mail-m16.yeah.net ([220.197.32.17]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1dUO-0000000GlJ8-2rEF for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 03:17:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=yEk24EEbUheM26KZ9Y5UZSg71Glq65ticUsqrmiR49g=; b=qdvBHEWTAB+JUPEtaDPM9Ll5UYrYHsKf2aglfn8A8DYK3g/+bg9RLAP2SFu8zV K8LyrJbdtjWsYTWWXHbGXSvCgg3NuzKiraACCIZjvWAaMpaUb6PCRNZAZP4/swcs 7kUKoDJDUzoPNTwfR0WDf+Da6MVQYZ45p02+Seixsnj8U= Received: from dragon (unknown []) by gzsmtp2 (Coremail) with SMTP id Ms8vCgC3Acab0hFnc11BAA--.2050S3; Fri, 18 Oct 2024 11:14:37 +0800 (CST) Date: Fri, 18 Oct 2024 11:14:34 +0800 From: Shawn Guo To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, kernel@dh-electronics.com, AngeloGioacchino Del Regno , Arnd Bergmann , Fabio Estevam , Jeff Johnson , Neil Armstrong , Pengutronix Kernel Team , Saravana Kannan , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] soc: imx8m: Probe the SoC driver as platform driver Message-ID: References: <20240929184930.73049-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240929184930.73049-1-marex@denx.de> X-CM-TRANSID: Ms8vCgC3Acab0hFnc11BAA--.2050S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww1UtF4kZry3uF4DZryftFb_yoW8KFy3pF 4fJr17CF4kGr47Aw17Ar45Ar45tayUA3W8Xr1xJr18uF15Cr1UAF1xtFWxGryDArWjqFn3 tF1qq3y8tF4rJaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j2NtsUUUUU= X-Originating-IP: [117.62.23.175] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiAhh8ZWcRl-6bMQABs3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_201721_056335_6794CE18 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 29, 2024 at 08:49:16PM +0200, Marek Vasut wrote: > With driver_async_probe=* on kernel command line, the following trace is > produced because on i.MX8M Plus hardware because the soc-imx8m.c driver > calls of_clk_get_by_name() which returns -EPROBE_DEFER because the clock > driver is not yet probed. This was not detected during regular testing > without driver_async_probe. > > Convert the SoC code to platform driver and instantiate a platform device > in its current device_initcall() to probe the platform driver. Rework > .soc_revision callback to always return valid error code and return SoC > revision via parameter. This way, if anything in the .soc_revision callback > return -EPROBE_DEFER, it gets propagated to .probe and the .probe will get > retried later. > > " > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 1 at drivers/soc/imx/soc-imx8m.c:115 imx8mm_soc_revision+0xdc/0x180 > CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0-next-20240924-00002-g2062bb554dea #603 > Hardware name: DH electronics i.MX8M Plus DHCOM Premium Developer Kit (3) (DT) > pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : imx8mm_soc_revision+0xdc/0x180 > lr : imx8mm_soc_revision+0xd0/0x180 > sp : ffff8000821fbcc0 > x29: ffff8000821fbce0 x28: 0000000000000000 x27: ffff800081810120 > x26: ffff8000818a9970 x25: 0000000000000006 x24: 0000000000824311 > x23: ffff8000817f42c8 x22: ffff0000df8be210 x21: fffffffffffffdfb > x20: ffff800082780000 x19: 0000000000000001 x18: ffffffffffffffff > x17: ffff800081fff418 x16: ffff8000823e1000 x15: ffff0000c03b65e8 > x14: ffff0000c00051b0 x13: ffff800082790000 x12: 0000000000000801 > x11: ffff80008278ffff x10: ffff80008209d3a6 x9 : ffff80008062e95c > x8 : ffff8000821fb9a0 x7 : 0000000000000000 x6 : 00000000000080e3 > x5 : ffff0000df8c03d8 x4 : 0000000000000000 x3 : 0000000000000000 > x2 : 0000000000000000 x1 : fffffffffffffdfb x0 : fffffffffffffdfb > Call trace: > imx8mm_soc_revision+0xdc/0x180 > imx8_soc_init+0xb0/0x1e0 > do_one_initcall+0x94/0x1a8 > kernel_init_freeable+0x240/0x2a8 > kernel_init+0x28/0x140 > ret_from_fork+0x10/0x20 > ---[ end trace 0000000000000000 ]--- > SoC: i.MX8MP revision 1.1 > " > > Signed-off-by: Marek Vasut Applied all, thanks!