From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3E00D2127B for ; Fri, 18 Oct 2024 08:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/6yd32eCbtlLyyhJU30GZ0XFgAZYNVzp9z45d5h+EaM=; b=CG/8MCgBb5QEuyq5bfFgwri2ZG zaSe7zsuDmKLs3S14vBhboIU8NliwaXUuJUzBBssNr5BeWJtPYhUAl4yyWBROxr8Q163IDrMwKcrl d+xdNnMGuEe+4BlpC9bdxYM3R3dH3QlNeBsOYlGrLgXuKTY8iLD+vg9aPHGqgML+aPlK6PKgPRJnz rhjr0r8M07FVcdD47l46xK5nkzgXPrpm5aU73tMSuUZY9poujkQnfQV1BW52e2hwjrez0WTAwsNqm 3CagybbX7JmU9qVUQbGLyUDldamKjpOqtdzgx/2CQIIzyMMQ4fLYrhHw4XETY3orxfrOTpXixIwQA ze9uJ7fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1idx-000000002LR-22t9; Fri, 18 Oct 2024 08:47:33 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1iUb-0000000Ha5K-0wU1 for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 08:37:54 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-37ed3bd6114so84348f8f.2 for ; Fri, 18 Oct 2024 01:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729240668; x=1729845468; darn=lists.infradead.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/6yd32eCbtlLyyhJU30GZ0XFgAZYNVzp9z45d5h+EaM=; b=cjpvb9qxBihMTOSe/EBe+4gPGfPAr6NFLPBNBnEseoGr69PV2NskuNldKCrMIAW3f2 RXj7V3K+xLf/+C5Cx3enBmuaemWxyNZutkkxpGSvQWHS1EbHUvh1ohIhecMHSF6xjOgz 0xv0vK4pj1W7+yJ0+x6wYpCDAZJ322AAideoZIScHZ+EbbccD1tilsTlRLYYNK3s8IsK MWPvWec9FM3taTeRi3q+bAZnJAymgFXNn+OPiewSENFgP3zzOXzAHJuAN1e62D4istmp X7GQce+MuVnDnzekyNp7W4V7J8Hu+4iUM99oMe4p3Z5ARPszcRyvixYysoP1a2ULSvhl U68Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729240668; x=1729845468; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/6yd32eCbtlLyyhJU30GZ0XFgAZYNVzp9z45d5h+EaM=; b=s+1Z2Fz43689y/THixz1NOSJNal6fpbpMnES1nuUnQdDMkdJyBB5k7UEl2KIRkpJGI 9WM4ZM7YAvwHYeVa7IOGK4QjW53bRh3TOiY/C8CWdwW1PeL7A9RkuWvOU1oB5hFZiwpK 0xNCaZaWOqOYq3o5zc8tMlEkbY29JGm9/Kc/u12EGlltEfTlJvOttULb9/XOp0s2ycl7 dETxWYQQi3zhyZUAoNMVfl6uq+BlrEG81x0fTBUHOPTOVCTuGuGN7yUl7cOr2c+zWCrq 0yVesNqqANtCViTyVUbfsSuvvZzVabcvGf5oTw9cBXJN2mM/JJodEb4C0QYlctBgnVfE k9Kg== X-Gm-Message-State: AOJu0YyKQBCZqPKwbf1sOAKafR7O+7j2RS5MHsm4yuLnmKi14109PM05 DdAQIGiUydVxxdtMZdqPnavskC++FVy2c2PaVCBixFBL7uv6bRCdeMnUEhJpYA== X-Google-Smtp-Source: AGHT+IG6tqZDU5vuqQ/8yfzFcSKBZocIYfOFr93kFxBpgu3aGBq28pRnxztUk2dWRxXkAl85RTtSSA== X-Received: by 2002:adf:f744:0:b0:37d:5103:8896 with SMTP id ffacd0b85a97d-37eab4ed1ddmr1058788f8f.41.1729240667888; Fri, 18 Oct 2024 01:37:47 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:5ff5:1ffe:9d80:ada1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ecf027d90sm1323673f8f.8.2024.10.18.01.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 01:37:47 -0700 (PDT) Date: Fri, 18 Oct 2024 10:37:41 +0200 From: Marco Elver To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, kernel-team@android.com, linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com, glider@google.com, kasan-dev@googlegroups.com, Andrey Konovalov , Mark Rutland , syzbot+908886656a02769af987@syzkaller.appspotmail.com, Andrew Pinski Subject: Re: [PATCH] kasan: Disable Software Tag-Based KASAN with GCC Message-ID: References: <20241014161100.18034-1-will@kernel.org> <172898869113.658437.16326042568646594201.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <172898869113.658437.16326042568646594201.b4-ty@kernel.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_013753_304881_4D5AF000 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 01:39PM +0100, 'Will Deacon' via kasan-dev wrote: > On Mon, 14 Oct 2024 17:11:00 +0100, Will Deacon wrote: > > Syzbot reports a KASAN failure early during boot on arm64 when building > > with GCC 12.2.0 and using the Software Tag-Based KASAN mode: > > > > | BUG: KASAN: invalid-access in smp_build_mpidr_hash arch/arm64/kernel/setup.c:133 [inline] > > | BUG: KASAN: invalid-access in setup_arch+0x984/0xd60 arch/arm64/kernel/setup.c:356 > > | Write of size 4 at addr 03ff800086867e00 by task swapper/0 > > | Pointer tag: [03], memory tag: [fe] > > > > [...] > > Applied to arm64 (for-next/fixes), thanks! > > [1/1] kasan: Disable Software Tag-Based KASAN with GCC > https://git.kernel.org/arm64/c/7aed6a2c51ff I do not think this is the right fix. Please see alternative below. Please do double-check that the observed splat above is fixed with that. Thanks, -- Marco ------ >8 ------ >From 23bd83dbff5a9778f34831ed292d5e52b4b0ee18 Mon Sep 17 00:00:00 2001 From: Marco Elver Date: Fri, 18 Oct 2024 10:18:24 +0200 Subject: [PATCH] kasan: Fix Software Tag-Based KASAN with GCC Per [1], -fsanitize=kernel-hwaddress with GCC currently does not disable instrumentation in functions with __attribute__((no_sanitize_address)). However, __attribute__((no_sanitize("hwaddress"))) does correctly disable instrumentation. Use it instead. Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117196 [1] Link: https://lore.kernel.org/r/000000000000f362e80620e27859@google.com Link: https://lore.kernel.org/r/ZvFGwKfoC4yVjN_X@J2N7QTR9R3 Link: https://bugzilla.kernel.org/show_bug.cgi?id=218854 Reported-by: syzbot+908886656a02769af987@syzkaller.appspotmail.com Cc: Andrew Pinski Cc: Andrey Konovalov Cc: Mark Rutland Cc: Will Deacon Signed-off-by: Marco Elver --- include/linux/compiler-gcc.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index f805adaa316e..cd6f9aae311f 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -80,7 +80,11 @@ #define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) #endif +#ifdef __SANITIZE_HWADDRESS__ +#define __no_sanitize_address __attribute__((__no_sanitize__("hwaddress"))) +#else #define __no_sanitize_address __attribute__((__no_sanitize_address__)) +#endif #if defined(__SANITIZE_THREAD__) #define __no_sanitize_thread __attribute__((__no_sanitize_thread__)) -- 2.47.0.rc1.288.g06298d1525-goog