From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C0A7D2FFEC for ; Fri, 18 Oct 2024 11:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DQRhCLpH6jRWDz35x/sxqE/ieU89FU9VoVdFVZbZFGY=; b=y4CwgMKax/CCi361qIdk2JbzoG p91oi/L7uibvkUb/0lFN1Sl8GI2nZrnTgp3DRStAdh2J8+CfcstHAVdD1iOIhqA475KZH73HbBQGK LG6GJTvUdnojdCbGx8FftA/88QCoP2I3Q7u+rmlF4bGeY5a8YvFY7BIQdLOSxOUiGod/wQhK757Rn SEhgFg+RG4v4PKwGykGJlYG0kD8Bp5zKIZ2mfX7OUZ1IxiWxL/cGdETWB/7/Vja3rxtZqCjsQdija s/IgE8jpOzIWU0Tzz2YGZinjSpH5EFYXVHe0Orpa9hfuzIivgGTKNJ+yfCbNmOUCBRM45PFTTSKXp OooP4kAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1ksc-00000000VNP-1Hon; Fri, 18 Oct 2024 11:10:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1kr9-00000000V4Z-2EWN for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 11:09:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E874FEC; Fri, 18 Oct 2024 04:09:48 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95CD43F58B; Fri, 18 Oct 2024 04:09:17 -0700 (PDT) Date: Fri, 18 Oct 2024 12:09:04 +0100 From: Cristian Marussi To: Xinqi Zhang Cc: Sudeep Holla , Cristian Marussi , linux-arm-msm@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] firmware: arm_scmi: fix slab-use-after-free in scmi_bus_notifier() Message-ID: References: <20241016-fix-arm-scmi-slab-use-after-free-v2-1-1783685ef90d@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016-fix-arm-scmi-slab-use-after-free-v2-1-1783685ef90d@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_040919_630204_E565B954 X-CRM114-Status: UNSURE ( 6.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 16, 2024 at 02:13:38PM +0800, Xinqi Zhang wrote: > The scmi_dev->name is released prematurely in __scmi_device_destroy(), > which causes slab-use-after-free when accessing scmi_dev->name in > scmi_bus_notifier(). So move the release of scmi_dev->name to > scmi_device_release() to avoid slab-use-after-free. LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian