From: Dave Martin <Dave.Martin@arm.com>
To: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org,
anshuman.khandual@arm.com, aruna.ramakrishna@oracle.com,
broonie@kernel.org, catalin.marinas@arm.com,
dave.hansen@linux.intel.com, jeffxu@chromium.org,
joey.gouly@arm.com, shuah@kernel.org, will@kernel.org,
linux-kselftest@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/5] arm64: signal: Remove unused macro
Date: Mon, 21 Oct 2024 14:44:55 +0100 [thread overview]
Message-ID: <ZxZa13heTXFwiQXM@e133380.arm.com> (raw)
In-Reply-To: <7793ba63-1d3c-44b0-8daf-10c4a7b79bc9@arm.com>
On Mon, Oct 21, 2024 at 12:05:30PM +0200, Kevin Brodsky wrote:
> On 17/10/2024 17:49, Dave Martin wrote:
> > On Thu, Oct 17, 2024 at 02:39:05PM +0100, Kevin Brodsky wrote:
> >> Commit 33f082614c34 ("arm64: signal: Allow expansion of the signal
> >> frame") introduced the BASE_SIGFRAME_SIZE macro but it has
> >> apparently never been used.
> > Nit: Should there be a statement of what the patch does?
> >
> > Same throughout the series.
> >
> > (Yes, I know it's in the subject line, but Mutt doesn't think that's
> > part of the message body, so I can't see it now that I'm replying...
> > and submitting-patches.rst and e.g., maintainer-tip.rst seem to take
> > the same policy, albeit without quite stating it explicitly.)
>
> Ah good point, I didn't consider that. Will make it explicit in patch 1
> and 2.
Thanks.
(I have a patch for submitting-patches.rst knocking about to propose
making this more explicit, but I didn't dare to post it so far...)
Cheers
---Dave
next prev parent reply other threads:[~2024-10-21 14:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 13:39 [PATCH 0/5] Improve arm64 pkeys handling in signal delivery Kevin Brodsky
2024-10-17 13:39 ` [PATCH 1/5] arm64: signal: Remove unused macro Kevin Brodsky
2024-10-17 15:49 ` Dave Martin
2024-10-21 10:05 ` Kevin Brodsky
2024-10-21 13:44 ` Dave Martin [this message]
2024-10-21 13:01 ` Catalin Marinas
2024-10-17 13:39 ` [PATCH 2/5] arm64: signal: Remove unnecessary check when saving POE state Kevin Brodsky
2024-10-17 13:52 ` Mark Brown
2024-10-17 15:49 ` Dave Martin
2024-10-21 13:02 ` Catalin Marinas
2024-10-17 13:39 ` [PATCH 3/5] arm64: signal: Improve POR_EL0 handling to avoid uaccess failures Kevin Brodsky
2024-10-17 15:53 ` Dave Martin
2024-10-21 10:06 ` Kevin Brodsky
2024-10-21 13:43 ` Dave Martin
2024-10-22 12:34 ` Kevin Brodsky
2024-10-22 12:38 ` Dave Martin
2024-10-21 14:38 ` Dave Martin
2024-10-17 13:39 ` [PATCH 4/5] selftests/mm: Use generic pkey register manipulation Kevin Brodsky
2024-10-17 13:39 ` [PATCH 5/5] selftests/mm: Enable pkey_sighandler_tests on arm64 Kevin Brodsky
2024-10-17 15:48 ` [PATCH 0/5] Improve arm64 pkeys handling in signal delivery Dave Martin
2024-10-21 10:06 ` Kevin Brodsky
2024-10-21 13:31 ` Dave Martin
2024-10-21 15:30 ` Catalin Marinas
2024-10-21 17:19 ` Will Deacon
2024-10-22 10:45 ` Catalin Marinas
2024-10-22 9:31 ` Pierre Langlois
2024-10-22 10:40 ` Stephen Röttger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxZa13heTXFwiQXM@e133380.arm.com \
--to=dave.martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=aruna.ramakrishna@oracle.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=jeffxu@chromium.org \
--cc=joey.gouly@arm.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).