From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E9B1D15D98 for ; Mon, 21 Oct 2024 14:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mNju7tFPsetcKm0jbr+D/LEtFqhxotOSm3et0YgjEhM=; b=Y9eTNfLcKBq9jut5kccIzudNEH 7uEm2QMx+xqiukk/WJBRrPy6aeA9pZnmx5BuicU3xCRo82k8J5N90VNpZmnIx5GIqoylq9OzZPqge 873dryDCPM1FA+Di8R0Lfkw6idmTJW0qEcWueYtVnJY+Lvj7F6R+g1SHYgNl3vGtbtLxdNcGz560/ 7rhzm5K+XO32xqIAh7v9T4H+NnrBWkemLRfKqfcMd9yf3NLN6CI0i4Qb1OXCMj4zVTwGVxwpmKUuf nXS/otgGC7L814OlSxCFPOItSEjsst3Rw+CfRMY8CxlPgH4w62IyQz8FYiRHNTtVODQFtGke1bwWA 7klu+8HQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2tAT-00000007a8N-1RwS; Mon, 21 Oct 2024 14:13:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2sia-00000007TUA-2cEP for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 13:45:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F32DDA7; Mon, 21 Oct 2024 06:45:30 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 87EF33F73B; Mon, 21 Oct 2024 06:44:58 -0700 (PDT) Date: Mon, 21 Oct 2024 14:44:55 +0100 From: Dave Martin To: Kevin Brodsky Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, aruna.ramakrishna@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jeffxu@chromium.org, joey.gouly@arm.com, shuah@kernel.org, will@kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/5] arm64: signal: Remove unused macro Message-ID: References: <20241017133909.3837547-1-kevin.brodsky@arm.com> <20241017133909.3837547-2-kevin.brodsky@arm.com> <7793ba63-1d3c-44b0-8daf-10c4a7b79bc9@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7793ba63-1d3c-44b0-8daf-10c4a7b79bc9@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_064508_820816_3F98BD19 X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2024 at 12:05:30PM +0200, Kevin Brodsky wrote: > On 17/10/2024 17:49, Dave Martin wrote: > > On Thu, Oct 17, 2024 at 02:39:05PM +0100, Kevin Brodsky wrote: > >> Commit 33f082614c34 ("arm64: signal: Allow expansion of the signal > >> frame") introduced the BASE_SIGFRAME_SIZE macro but it has > >> apparently never been used. > > Nit: Should there be a statement of what the patch does? > > > > Same throughout the series. > > > > (Yes, I know it's in the subject line, but Mutt doesn't think that's > > part of the message body, so I can't see it now that I'm replying... > > and submitting-patches.rst and e.g., maintainer-tip.rst seem to take > > the same policy, albeit without quite stating it explicitly.) > > Ah good point, I didn't consider that. Will make it explicit in patch 1 > and 2. Thanks. (I have a patch for submitting-patches.rst knocking about to propose making this more explicit, but I didn't dare to post it so far...) Cheers ---Dave