From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10137D0E6C5 for ; Mon, 21 Oct 2024 17:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hcXzjvy5rNk8Smj7d8LrRJ3nwUvDMj7I3OcqOBHbeGk=; b=JtTYBqK3vXfx1Uc01aNnw+pC/x NaeY4OcdvTFpl2ch0CC0x/69U+9+3eWugSnyEsNqU7ayrz8leYcsCMyJ0kan8GnnbHm6SnPmEMEGG xf6bzzwcsx8vZiOEergQhAYuCgJDIkD8UlbK6+yp1BQQwrk1n/5JQQpYePXXeEbgtP8mtT6CGmbaq J7pcqRYiMiaolgldOYFIP+jI5trkGZ6iRH0FMX1+YEWc3vV7WceykU+/+LGwGBVP03myLtqpR6imn 8qtRz9hlfZEe1dMOj+vEBdpbMJoBMzP3+lWmUCpxss0mYimkrGpIzaHXgWfmMDdq7HnvPICnMjtGI xcsfOCBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2w7V-000000086vT-3njz; Mon, 21 Oct 2024 17:23:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2vy3-0000000857c-2KBM for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 17:13:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF4FBDA7; Mon, 21 Oct 2024 10:13:47 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E0CC3F528; Mon, 21 Oct 2024 10:13:16 -0700 (PDT) Date: Mon, 21 Oct 2024 18:13:07 +0100 From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Cc: broonie@kernel.org, catalin.marinas@arm.com, mbenes@suse.cz, puranjay12@gmail.com, will@kernel.org Subject: Re: [PATCH] arm64: preserve pt_regs::stackframe during exec*() Message-ID: References: <20241021164456.2275285-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241021164456.2275285-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_101319_656262_5950C484 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2024 at 05:44:56PM +0100, Mark Rutland wrote: > When performing an exec*(), there's a transient period before the return > to userspace where any stacktrace will result in a warning triggered by > kunwind_next_frame_record_meta() encountering a struct frame_record_meta > with an unknown type. This can be seen fairly reliably by enabling KASAN > or KFENCE, e.g. [...] > This zeroing wasn't a problem prior to commit: > > 0f0b9a3f6a50fa36 ("arm64: stacktrace: unwind exception boundaries") Sorry, that's the commit ID from my arm64/stacktrace/metadata branch. The version queued in the arm64 for-next/stacktrace branch has a different ID, and this should say: c2c6b27b5aa14fa2 ("arm64: stacktrace: unwind exception boundaries") [...] > Fixes: 0f0b9a3f6a50fa36 ("arm64: stacktrace: unwind exception boundaries") ... and likewise that should be: Fixes: c2c6b27b5aa14fa2 ("arm64: stacktrace: unwind exception boundaries") Mark.