From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E208D17123 for ; Mon, 21 Oct 2024 18:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B4nB5AD8jm9woOflkJu9LaOALYzY3FWUJ+pKW1FSB8o=; b=N42/+F3r3HjuZP3onHSeUh4yWI 7e6+9JX7wKxVu37P+HHYiBGoCf8UF9rfSJxuq6IBuBbgCoaUd93hu01gtT53RVL4h/qDBomuCYdx/ D/SmGeOIDTL2wzYSoff4S1IsHSmj79/DsHCKc4yab3P0UdUWThW19dv56G4PJgzhv4Ghre7WcEIXP t2h8gdwdanyGSbAr6ZCjFpb32A2biFXOkfehz02qJQ7k/W3nlaviTaDHTomL8sRrt2hwNf604zueg Oa98JiSU8dagr3nDQDONMbtHmLkQ4nFyeAoRi43rV3Z1MDLG3v6x5bQLHh53ZqlWxHkIZrZgOpsVB k1+oMaiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2wtO-00000008GRj-42Rq; Mon, 21 Oct 2024 18:12:34 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2wpp-00000008FMH-0dbQ for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 18:08:54 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-2e2eb765285so6068138a91.1 for ; Mon, 21 Oct 2024 11:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729534131; x=1730138931; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=B4nB5AD8jm9woOflkJu9LaOALYzY3FWUJ+pKW1FSB8o=; b=YSkuKNr9XgZadGB/RBBFR2K0sSL70gInVXYWFvXhRhvUKfnuBEW0BriKh+0Iw3eczO QagL/9US/5P5yrStdvvqBLPm/AkOwTdkbpuuGDX5WdC4meftFvtKarodDGSnME0lMIOZ gTzp+olETvutspnk1F/WH/oBN5E53NbBIiTWaGPVEbiDCZQUfGG63TgKYxnVf7hT2tDq ZM0GyKOjhQCYgjLa6VlpBb9/8DHtP20+CNoAzFptyfVVp/KgupeO1cwu5j+gr/F4VnJI Rcn/V7SQ+lekX5f+Pa1LRgf3qr6Gk5GNQr16Il5i/L/kJTZnOgxtVPBel1+SnXG85s/o gtUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729534131; x=1730138931; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B4nB5AD8jm9woOflkJu9LaOALYzY3FWUJ+pKW1FSB8o=; b=tQOhrlfs5wmlLfpvfVDmd8qP89x3f3aHtPzsaPStKeYnWSMKUBb8u2424JPa0AzLDH 6T+C0JhCxEOHh9j7EPx9wagHkxymxqeWWTGRw6n1u4B78PZDh6/5BKSUnawArRwc4kzr kmmnLExnWfAfozbJ4sL2S8OE8Ol6qVniMdjwsTSEgDoYyiaqKIWv8uCN0urkcxJyNh2P uUTw+uA5f63MwcgpxI2PSW44EdLtJsIw7mRQin4WJ737izT6fpHkLwTjZUk4tPbxVJtO zXhT0iHlo4QkQkMxRywahvXkeGpzebHT4netcjNSWesLhp2wY1Y4SdZBNJZKZ0KS6l87 RpUQ== X-Forwarded-Encrypted: i=1; AJvYcCWmLzNoY+qY5hyi//HCvi6f4UhJ61cS4C/0eICiVYjhkl6g/JCVmPFUOU7qM3Z7mtoFaQQzOxfYLPl3txjcV1c6@lists.infradead.org X-Gm-Message-State: AOJu0YykZUrTTixucDSEeoM2rgaWst1c6+qFm66OKruZ8WdaY58OfbBy CxUjGmg2ANfT4idk7qWesPliHm84iRVCPTM8zUDup70yWz8pC/Uf8yI381fWWaUArM87M2uTUth g3Q== X-Google-Smtp-Source: AGHT+IHz/sqxbIaZMzAhwQE+KHAQ50pc4vGOx7OQ/MlEMfrpYKQ16K4ySzEgLcCV5+myw9EmSbX31Z6uvf4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a17:90a:e147:b0:2d8:a9c2:2f3a with SMTP id 98e67ed59e1d1-2e5616d8f42mr22750a91.3.1729534130899; Mon, 21 Oct 2024 11:08:50 -0700 (PDT) Date: Mon, 21 Oct 2024 11:08:49 -0700 In-Reply-To: Mime-Version: 1.0 References: <20241010182427.1434605-1-seanjc@google.com> <20241010182427.1434605-20-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 19/85] KVM: Introduce kvm_follow_pfn() to eventually replace "gfn_to_pfn" APIs From: Sean Christopherson To: Yan Zhao Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, "Alex =?utf-8?Q?Benn=C3=A9e?=" , David Matlack , David Stevens , Andrew Jones Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_110853_236670_59F4396F X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2024, Yan Zhao wrote: > On Thu, Oct 10, 2024 at 11:23:21AM -0700, Sean Christopherson wrote: > > --- a/virt/kvm/pfncache.c > > +++ b/virt/kvm/pfncache.c > > @@ -159,6 +159,12 @@ static kvm_pfn_t hva_to_pfn_retry(struct gfn_to_pfn_cache *gpc) > > kvm_pfn_t new_pfn = KVM_PFN_ERR_FAULT; > > void *new_khva = NULL; > > unsigned long mmu_seq; > > + struct kvm_follow_pfn kfp = { > > + .slot = gpc->memslot, > > + .gfn = gpa_to_gfn(gpc->gpa), > > + .flags = FOLL_WRITE, > > + .hva = gpc->uhva, > > + }; > Is .map_writable uninitialized? Nope, per C99, "subobjects without explicit initializers are initialized to zero", i.e. map_writable is initialized to "false".