From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8512D17123 for ; Mon, 21 Oct 2024 18:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m/AMYvkrWkvtYGVWRPRo1Bt/DfTS42ENqBwBTRp80W4=; b=CUScnvVhkvXhF6F1XIucZaS9ex ZSdQ7KmBCtzaZoadRvtBtz8Wuys+/gp4ltEsmy8id6iiIpmzmIJapz5AOXIDCJX9t0F56fbyyX81C nMRpIemysssC9M9EeX7saoiBa152KpPag4aIeDg2gHMzhDZhjqK3JAzDO5LUgtWU3w9HwMy9pdduM tyLmgmc1e225M9ffhfXe4GMlgmVcxmr1E2Sow7LWwmL8njiMdPNGYKVQa9VWSrK7lYxc3YIDYKlef baUT6taNro0QBWTCP8QZk5IaRbD7CMQE2SGqQ5g1BvdnTLKwm/4Fp1Ryd1kNAIFEFDEwdfG0PUwBW nLR7cWig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2x7W-00000008IhK-3POu; Mon, 21 Oct 2024 18:27:10 +0000 Received: from mail-dm6nam12on20618.outbound.protection.outlook.com ([2a01:111:f403:2417::618] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2x62-00000008IX9-2ZZj for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 18:25:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OaWYEsNJbPn/VNFTcWdvH9hwoU8s8iEiOUAoNzVzqIMohpKDkmRjkXOvn4KJbBn0LAmYTKg14A/2hV/RVxOfWJFIgIk8IuAB1tUkKqJACAE3z7dyI36d/mKZe5YSXdWJEOBCF0Ihe9h/4CFdJIWsBZOF0ecLid8EVvLfnrSt3V+nk5hqmlEr38Qs7hQoaznVCCI0LK9rkdcp2GMpAYRBq22AZMXJW+F4/UdOyJzy1kcn8Tvsvi5IGt98hyZy5dk8k3qeOQfCse9IsHSko3TX4DJmeAQ4alg0HgAiTeu2nbCzfGP+Lp17nW5z2VhI0Ek6oEolZNUjUbYEy0ajyQfGfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m/AMYvkrWkvtYGVWRPRo1Bt/DfTS42ENqBwBTRp80W4=; b=kuOPRF42N2WZqYuSf/jRaw5mHCiKva6HugqjQRCx5NYCn9iJ0f5oMhNPhB1oStCUVa12pApHac4+FMysvE5uPiTJyHSjfF3Sy9EE3/gfq3OVwAWWK8fLoAOszVC9EPdXhBgX7hQ3+9a4GumdLll/X+ElDWrxNCXYfUGdxtHfjvbHzdZy5WrJxPtJ8hO1xS+LUbpOnOIlJKEB6miWriE7XjWtBdoIDqJLOqVeb04zgWu718o4gzf1Vo2LsO5w9uQE9iFr7JNVqZOmukLFvejrCbegezLwj9Zk1239YbmrKdjjSmmKCBkZe9CorZ/4Vx7CtBNelQueHq0P6GGs0p1k3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m/AMYvkrWkvtYGVWRPRo1Bt/DfTS42ENqBwBTRp80W4=; b=VIE6YMRwaD7YaJeqTk7/zXwBzH7YjFXV5BsYfewl/KLz8i+1DdJaIFT6yKa7ZQXtMiIazoueCs43PR5KNy1bjAA07RuXtzSremMbqdEIE/+vxAoXE51TuhG55tIxzCepzGQuFWWfQ/Jjcbo1FAxTGmvn/Zo7H5DuR9UN/m8ixtsHIJCHxJrycj/XLIGTwi6Q+f8iSfeYKEub04FIGy5N3E5ekY79I2wTHMfMAa1V4NksdM9TAq+Z+/8FnaOpC8cOkX+pGvrtaUoYHYcaYMVDjUyXgPgWTYyMxTAH5mawKSacGd4BupSCY/RRZaC4FxdGcEbAYBt+zJW6tUctBNQnUg== Received: from SA1P222CA0072.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::28) by SJ2PR12MB8806.namprd12.prod.outlook.com (2603:10b6:a03:4d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Mon, 21 Oct 2024 18:25:33 +0000 Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:2c1:cafe::b7) by SA1P222CA0072.outlook.office365.com (2603:10b6:806:2c1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.29 via Frontend Transport; Mon, 21 Oct 2024 18:25:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Mon, 21 Oct 2024 18:25:33 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 21 Oct 2024 11:25:11 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 21 Oct 2024 11:25:10 -0700 Received: from Asurada-Nvidia (10.127.8.9) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 21 Oct 2024 11:25:09 -0700 Date: Mon, 21 Oct 2024 11:25:08 -0700 From: Nicolin Chen To: Alexey Kardashevskiy CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 09/11] iommufd/selftest: Add IOMMU_VIOMMU_ALLOC test coverage Message-ID: References: <320e7f6a93f50d00d7273ad8a2f06be928a6ed35.1728491453.git.nicolinc@nvidia.com> <7f808273-a920-4937-9693-68d4a1557491@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7f808273-a920-4937-9693-68d4a1557491@amd.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|SJ2PR12MB8806:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f2e143a-f1c4-45a0-a348-08dcf1fdc04b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+itt/0fA7h6/RJtE+ph9Ery0FQwcjj9vEjsoFMtzkstwXL2X4fAF4YRI0f7z?= =?us-ascii?Q?oIc87m2F/puSqCtX+s14nfWUrRBfHeGLXGAnyEXWYifjH4E5h5yCFiUgkWF1?= =?us-ascii?Q?L7yUHNri9j5oDcoJYMa5JmU3oJZpa0A1gMT9+mHzpdfOo39QoXK03xINx7Zn?= =?us-ascii?Q?YYYqHTCrwgOILdtjVKMdmxQZT84TVHlrbDfeZhf28Ne27uE4M6DkpRFTRPQs?= =?us-ascii?Q?kXIu8cP8paS/mOhm/jo7Xx4EAMRa6uXV/T2MiKiYwGSCFQvlolLOiZldn6ZO?= =?us-ascii?Q?TA/vmizNyuFLrJglgAd7khKCYMNZKnR6Bpf/7hMkjizCDqnZtcSt5ohWaa6j?= =?us-ascii?Q?u1sMmVG0BZWP4bES0HdjFGG4N+Q3djmKlHFTt8ZeUOG2UdxXQt7FBtH6M4RT?= =?us-ascii?Q?s0x9a+a/ilNDhEyY6c8cf41SIdHjompavgzJsgvGFAaBZnkYig6FYqkA8u4H?= =?us-ascii?Q?DsJFtaK+UOQfYtpHz7Klv0P5zreE1JPOfduSGqlZVcY2vtxcOXNpnTncDA6S?= =?us-ascii?Q?EFpgQA7tQwuP0k8m6PdPdUc+2kqjwE1ddafkz3R+SpJG4pIsV9JBNrV0FkyH?= =?us-ascii?Q?mDA/gaqZi08UEc6bagoFH6xcALlY/FeKoL+/9vpcHWVQQCGN7DYc0vZl2BDA?= =?us-ascii?Q?nttUigl+rjYQspDVEZC7/puKQl5uQWF8Jn8SHCLkhQfrxl5lo/NVw4swBDlP?= =?us-ascii?Q?Hpkqu8vh2eMM6QmzpWojKiaMOmdx7LNBuLk5vkydvdDR2GhL+6nWGO6zUM9S?= =?us-ascii?Q?MeFLohKhIscSXClwncb0vn/EmzyMXrh6w7jRxPBgm5IMuKjQ3YO4/m/N+5qs?= =?us-ascii?Q?SbMGVmWSclicF8j/+tm6GM9ix5czgnDHF9edF6KlPxXJpZtW5m3z3EYViHKf?= =?us-ascii?Q?esQTT0UrvMgvif35kotht63VgWEEtLjt2kwStK5L1Cbve9b+51LA7TUFZZcg?= =?us-ascii?Q?tY1iKn+gBgz3iLDAPi5MAKtzRknA8ukpViS8y7/DsixqDj0xH46TjNB9TYmx?= =?us-ascii?Q?tmb24faLfvpTe/QR+Ks+xQz+GCCH5x8GscO0hInwlt/3Vjx56VPY4VahLS0C?= =?us-ascii?Q?yiNkQ6P4Ih/MuetFu35exsGtyKFoJ2Po98XrZ3NdD20F8Fgr1yakw9w3opkg?= =?us-ascii?Q?yUP17da+U0vFYMHF1J90don54a3FSAQ49YjHw1aHnI6xIzH2YEsys98zMa6f?= =?us-ascii?Q?ceiKrhf960tgF5V9V41JgNxbNrqxIfQcZLzmVrkNREOBWG5v45FjPyS+2fkA?= =?us-ascii?Q?Y2utQlMHMvNByEdPktjz/Bg1vZu2+nVJA+7lhd9FBT/C+lJfrcDgSoGspEmc?= =?us-ascii?Q?p9ZJunYcjByYxW/paOEkxL/zB+KfcW2OGzVpbMFesS4fTwiN3tDUzkictz1P?= =?us-ascii?Q?pTCkM+Z2S++kgx1gpK+L8Msm6emSmlXnp2RMecr2BIUYGKLo7Q=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2024 18:25:33.2782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2e143a-f1c4-45a0-a348-08dcf1fdc04b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8806 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_112538_685144_AFE32EFC X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2024 at 07:30:57PM +1100, Alexey Kardashevskiy wrote: > On 10/10/24 03:38, Nicolin Chen wrote: > > Add a new iommufd_viommu FIXTURE and setup it up with a vIOMMU object. > > > > Any new vIOMMU feature will be added as a TEST_F under that. > > > > Signed-off-by: Nicolin Chen > > --- > > tools/testing/selftests/iommu/iommufd_utils.h | 28 +++++++ > > tools/testing/selftests/iommu/iommufd.c | 84 +++++++++++++++++++ > > 2 files changed, 112 insertions(+) > > > > diff --git a/tools/testing/selftests/iommu/iommufd_utils.h b/tools/testing/selftests/iommu/iommufd_utils.h > > index 40f6f14ce136..307d097db9dd 100644 > > --- a/tools/testing/selftests/iommu/iommufd_utils.h > > +++ b/tools/testing/selftests/iommu/iommufd_utils.h > > @@ -762,3 +762,31 @@ static int _test_cmd_trigger_iopf(int fd, __u32 device_id, __u32 fault_fd) > > > > #define test_cmd_trigger_iopf(device_id, fault_fd) \ > > ASSERT_EQ(0, _test_cmd_trigger_iopf(self->fd, device_id, fault_fd)) > > + > > +static int _test_cmd_viommu_alloc(int fd, __u32 device_id, __u32 hwpt_id, > > + __u32 type, __u32 flags, __u32 *viommu_id) > > +{ > > + struct iommu_viommu_alloc cmd = { > > + .size = sizeof(cmd), > > + .flags = flags, > > + .type = type, > > + .dev_id = device_id, > > + .hwpt_id = hwpt_id, > > + }; > > + int ret; > > + > > + ret = ioctl(fd, IOMMU_VIOMMU_ALLOC, &cmd); > > + if (ret) > > + return ret; > > + if (viommu_id) > > "if" can be dropped as viommu_id is always non-null in this test. Thanks, I will change those negative tests to pass in NULL then.. Thanks Nicolin