* [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings
@ 2024-10-21 18:32 Andreas Kemnade
2024-10-22 3:34 ` Shawn Guo
2024-10-22 7:08 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Andreas Kemnade @ 2024-10-21 18:32 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Cc: Andreas Kemnade
Fix anatop thermal related dtbs_check warnings about node name
and missing thermal-cells property.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
index ddeb5b37fb78b..85fe2a4ab97a0 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
@@ -525,7 +525,7 @@ reg_3p0: regulator-3p0@20c8120 {
anatop-enable-bit = <0>;
};
- tempmon: temperature-sensor {
+ tempmon: tempmon {
compatible = "fsl,imx6sll-tempmon", "fsl,imx6sx-tempmon";
interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
interrupt-parent = <&gpc>;
@@ -533,6 +533,7 @@ tempmon: temperature-sensor {
nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
nvmem-cell-names = "calib", "temp_grade";
clocks = <&clks IMX6SLL_CLK_PLL3_USB_OTG>;
+ #thermal-sensor-cells = <0>;
};
};
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings
2024-10-21 18:32 [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings Andreas Kemnade
@ 2024-10-22 3:34 ` Shawn Guo
2024-10-22 6:46 ` Andreas Kemnade
2024-10-22 7:08 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2024-10-22 3:34 UTC (permalink / raw)
To: Andreas Kemnade
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> Fix anatop thermal related dtbs_check warnings about node name
Can we be clear what the warning about the node name is, too long?
Shawn
> and missing thermal-cells property.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> index ddeb5b37fb78b..85fe2a4ab97a0 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> @@ -525,7 +525,7 @@ reg_3p0: regulator-3p0@20c8120 {
> anatop-enable-bit = <0>;
> };
>
> - tempmon: temperature-sensor {
> + tempmon: tempmon {
> compatible = "fsl,imx6sll-tempmon", "fsl,imx6sx-tempmon";
> interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gpc>;
> @@ -533,6 +533,7 @@ tempmon: temperature-sensor {
> nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
> nvmem-cell-names = "calib", "temp_grade";
> clocks = <&clks IMX6SLL_CLK_PLL3_USB_OTG>;
> + #thermal-sensor-cells = <0>;
> };
> };
>
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings
2024-10-22 3:34 ` Shawn Guo
@ 2024-10-22 6:46 ` Andreas Kemnade
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2024-10-22 6:46 UTC (permalink / raw)
To: Shawn Guo
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Am Tue, 22 Oct 2024 11:34:58 +0800
schrieb Shawn Guo <shawnguo2@yeah.net>:
> On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> > Fix anatop thermal related dtbs_check warnings about node name
>
> Can we be clear what the warning about the node name is, too long?
>
soc/imx/fsl,imx-anatop.yaml explicitely specifies the names of
allowed subnodes and mandates the name tempmon.
Regards,
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings
2024-10-21 18:32 [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings Andreas Kemnade
2024-10-22 3:34 ` Shawn Guo
@ 2024-10-22 7:08 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-10-22 7:08 UTC (permalink / raw)
To: Andreas Kemnade
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> Fix anatop thermal related dtbs_check warnings about node name
> and missing thermal-cells property.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-22 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 18:32 [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings Andreas Kemnade
2024-10-22 3:34 ` Shawn Guo
2024-10-22 6:46 ` Andreas Kemnade
2024-10-22 7:08 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).