From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B6D1D0C5EB for ; Fri, 25 Oct 2024 09:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BKU9eGjiGpcEW9DhjB7Jaj0ZFVcpGNTSeTnuNH8OLnM=; b=aI4GMC1sSOu2yHtUQ7vCgKySsV p3+pGQhGaJL5T0Kvupn/eAvPMSCKzwSFhRVxGMBPiYew9UQRrdZruxQcTwYHTEgT4dLZKf4bVIjRE p1IlCO+RPADRD5iJoAv9BMVEzPt19l/EoyGv8lOiXqc4ohpUFkccwJjaSrOOYETa152UMXMP0qi35 USBESPDPRc4kyybAdc3n7sO3sL0WY8oHbX7IxGL+dFmRJ9yenxqobl3vcuAM/27XBTwBG3D6gHFhc ej0RM3xiXYTlHkaGUgsUPOYNR0pjpNTKWuBsMmEPk6zRPwZItTt3zaRSUFXfDdy+g6acsuNaasx4V tfLPEYeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4GBb-000000035C4-1WB7; Fri, 25 Oct 2024 09:00:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4G8Q-0000000344D-3ILa for linux-arm-kernel@lists.infradead.org; Fri, 25 Oct 2024 08:57:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93963339; Fri, 25 Oct 2024 01:57:59 -0700 (PDT) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9815C3F528; Fri, 25 Oct 2024 01:57:27 -0700 (PDT) Date: Fri, 25 Oct 2024 09:57:25 +0100 From: Sudeep Holla To: Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Sudeep Holla , Conor Dooley , Cristian Marussi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE" , justin.chen@broadcom.com, opendmb@gmail.com, Florian Fainelli , kapil.hali@broadcom.com, bcm-kernel-feedback-list@broadcom.com, Arnd Bergmann Subject: Re: [PATCH v4 2/2] firmware: arm_scmi: Support 'reg-io-width' property for shared memory Message-ID: References: <20240827182450.3608307-1-florian.fainelli@broadcom.com> <20240827182450.3608307-3-florian.fainelli@broadcom.com> <20240903154000.GA2080277@bogus> <04050b73-eb16-440f-acd7-986b1f39a6c9@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04050b73-eb16-440f-acd7-986b1f39a6c9@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241025_015730_933340_206A60C3 X-CRM114-Status: GOOD ( 35.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 24, 2024 at 09:45:25AM -0700, Florian Fainelli wrote: > On 10/24/24 04:05, Sudeep Holla wrote: > > Gentle ping! Not sure if my earlier email got into spam or didn't land > > in lore/ML. Just thought of checking again. > > You did not land in spam, just being quite busy. > Ah good, at times our email server acts up, so there is always some doubt about it 😄. > > > > On Fri, Oct 18, 2024 at 01:57:09PM +0100, Sudeep Holla wrote: > > > On Tue, Sep 03, 2024 at 04:40:00PM +0100, Sudeep Holla wrote: > > > > On Tue, Aug 27, 2024 at 11:24:50AM -0700, Florian Fainelli wrote: > > > > > Some shared memory areas might only support a certain access width, > > > > > such as 32-bit, which memcpy_{from,to}_io() does not adhere to at least > > > > > on ARM64 by making both 8-bit and 64-bit accesses to such memory. > > > > > > > > > > Update the shmem layer to support reading from and writing to such > > > > > shared memory area using the specified I/O width in the Device Tree. The > > > > > various transport layers making use of the shmem.c code are updated > > > > > accordingly to pass the I/O accessors that they store. > > > > > > > > > > > > > This looks good to me now, much simpler. I will push this to -next soon, > > > > but it won't be for v6.12. I have already sent PR for that. I want this > > > > to be in -next for longer just to see if anyone has any comments and > > > > doesn't break any platform(which it shouldn't anyways). > > > > > > > > Just hoping if anyone looks at it and have feedback once it is in -next. > > > > I will apply formally at v6.12-rc1 and report back if no one complains > > > > until then. > > > > > > > > > > Hi Florian, > > > > > > Just thought I will check with you if the content is -next are fine as I now > > > recall I did the rebase as this patch was original posted before the rework > > > of transport as modules were merged. Please confirm if you are happy with the > > > rebase as you see in -next. I also had to rebase it on recent fixes that > > > Justin added as there were trivial conflicts. > > > > > > Another thing I wanted to check is if [1] series has any impact on this. > > > IIUC no, but it would be good to give a go in terms of testing just in case > > > that as well lands in -next. > > linux-next as of today (2024-10-24) still works good on the affected > platform, thanks for asking! Thanks, though note that I am not sure if the series [1] I mentioned in queued yet or not. -- Regards, Sudeep [1] https://lore.kernel.org/all/20241010123627.695191-1-jvetter@kalrayinc.com