From: Johan Hovold <johan@kernel.org>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
ulf.hansson@linaro.org, jassisinghbrar@gmail.com,
dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, konradybcio@kernel.org,
linux-pm@vger.kernel.org, tstrudel@google.com, rafael@kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH V4 3/4] pmdomain: core: Fix debugfs node creation failure
Date: Fri, 25 Oct 2024 16:11:45 +0200 [thread overview]
Message-ID: <ZxunIcSZDoO3ph64@hovoldconsulting.com> (raw)
In-Reply-To: <72a0b7b5-4209-f969-0726-e411b5a74e01@quicinc.com>
On Fri, Oct 25, 2024 at 07:36:16PM +0530, Sibi Sankar wrote:
> On 10/25/24 19:23, Johan Hovold wrote:
> > Also seems to do the trick:
> >
> > Tested-by: Johan Hovold <johan+linaro@kernel.org>
> >
> > But perhaps you could consider starting enumerating the duplicate
> > domains from 2 (or 1) instead of 0?:
> >
> > NCC_1 on 0
> > NCC_0 on 0
> > NCC on 0
>
> We are just trying to make sure node names are unique and
> can't ensure the pd-name correctness since ida starts its
> number generation from 0 and I didn't want to shape the
> fix just to cater to our specific case. The firmware fix
> will be in charge of ensuring pd-name correctness.
Ah, it's a global number space? I didn't really look at the
implementation...
Johan
next prev parent reply other threads:[~2024-10-25 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 10:21 [PATCH V4 0/4] firmware: arm_scmi: Misc Fixes Sibi Sankar
2024-10-23 10:21 ` [PATCH V4 1/4] firmware: arm_scmi: Ensure that the message-id supports fastchannel Sibi Sankar
2024-10-25 13:39 ` Johan Hovold
2024-10-25 14:07 ` Sibi Sankar
2024-10-23 10:21 ` [PATCH V4 2/4] firmware: arm_scmi: Skip opp duplicates Sibi Sankar
2024-10-23 10:21 ` [PATCH V4 3/4] pmdomain: core: Fix debugfs node creation failure Sibi Sankar
2024-10-25 13:53 ` Johan Hovold
2024-10-25 14:06 ` Sibi Sankar
2024-10-25 14:11 ` Johan Hovold [this message]
2024-10-30 12:52 ` Sibi Sankar
2024-10-28 13:28 ` Ulf Hansson
2024-10-30 12:50 ` Sibi Sankar
2024-10-23 10:21 ` [PATCH V4 4/4] mailbox: qcom-cpucp: Mark the irq with IRQF_NO_SUSPEND flag Sibi Sankar
2024-10-25 14:02 ` [PATCH V4 0/4] firmware: arm_scmi: Misc Fixes Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxunIcSZDoO3ph64@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tstrudel@google.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).