From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52487D3A67A for ; Tue, 29 Oct 2024 18:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V5/m98SCsuWyhGETBfSTsJ23RKI9RIUIQKPTQpndJ3w=; b=Y5P464mblkHFIgilIyeNtMHb3V bIthek3YaVrSU4fRAB6fP//CjfuJ2f6RtJyv8SXDIFgVOE4AQn3KBhy0FHkQAQY+hfVDJMh9Fi4RV QoXgtWkXeY8MjA7BCSxjO7YLpGbPoluPqkDbtBIVoZtvHVKexB6Rrb213S3DFkbX9AKXB+vRv2Juy mvNOgALTG7wLiNRamPZXNJrsfdj4BVmQRF2LXAxenHjyEoN6JHiTXxmEs0BfYo44/kyi+H8ib9u/0 aRz0Ej9GHXNDjMmPH/oH1uq95THD0HQzurIiJqXddWA40E31H00j+mO7MbKSdvAXBF2VcyE48+pW7 Snbq6e9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t5qjp-0000000FSsH-0uM9; Tue, 29 Oct 2024 18:14:41 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t5q5V-0000000FGqS-405o for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2024 17:33:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 239B0A43130; Tue, 29 Oct 2024 17:31:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76539C4CECD; Tue, 29 Oct 2024 17:32:58 +0000 (UTC) Date: Tue, 29 Oct 2024 17:32:56 +0000 From: Catalin Marinas To: Lorenzo Stoakes Cc: Vlastimil Babka , Linus Torvalds , "Liam R. Howlett" , Mark Brown , Andrew Morton , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Will Deacon , Aishwarya TCV Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Message-ID: References: <0b64edb9-491e-4dcd-8dc1-d3c8a336a49b@suse.cz> <1608957a-d138-4401-98ef-7fbe5fb7c387@suse.cz> <2759d754-9bd7-4bc0-a4a3-42f733fb2596@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2759d754-9bd7-4bc0-a4a3-42f733fb2596@lucifer.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241029_103302_083511_EF6C3714 X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 29, 2024 at 05:28:49PM +0000, Lorenzo Stoakes wrote: > On Tue, Oct 29, 2024 at 05:02:23PM +0000, Catalin Marinas wrote: > > That's what I meant (untested, on top of -next as it has a MAP_HUGETLB > > check in there). I don't think it's much worse than your proposal, > > assuming that it works: > > Right sorry misread. Yeah this is better, let me do a quick -v4 then! Thanks! > Cheers, sorry pretty tired at this stage, was looking at this all last > night... No worries. The way we handle MTE is pretty convoluted. Happy to simplify it if we find a better way. -- Catalin