From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74A0BD7495C for ; Wed, 30 Oct 2024 04:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rsVyI1VUpqBk+pGl3kmQOl+bBeTI0C/Yl62jkn772wo=; b=ign+V6FXri3XRV+qFX3iyJRELy suCAVC1hhC8tznKwegJBoaX8t6hGfACGAsmqXy+X029eR/YcC+EhfUuoaDs1zX3jO82o2Sad7DR1Q MOEErTvNb+kHHJyx6rOwN5oMlRVh4uBS4gAf8fyyDL2ET7BttNRX4IwMdNlT/b9bvhcBLdhbRcmkF FM77UqpD/koCCte68KbH2JGQU9iuYv9gOsdG19tGnYgUi/VDek1tboWBp5ZeZT01F6fHFkf5dPkz7 FocHPNUzD/mbapkaAiv0MmfzD9Hp5ZiYMjnQdfcQv4bz94XSnAOMlSVkM5FqEX1rv7d8WD1ff9nJz RxDdkv3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t603I-0000000GeSm-1uuw; Wed, 30 Oct 2024 04:11:24 +0000 Received: from mail-bn8nam04on2060e.outbound.protection.outlook.com ([2a01:111:f403:2408::60e] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t600i-0000000GeFK-0HTx for linux-arm-kernel@lists.infradead.org; Wed, 30 Oct 2024 04:08:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dar8nzGohmpUqS0/fMPN+81HbdDyXdFZKfnItKTpbLtoxDre02UtLyTwBVIPhD7W8kb6RmQhonb2CdoNYCH+axdZBd7Prs7by0e35iGwIojS6qES4SJqYOhh6+DLQNw7A3zuk9EwlmlfZrny1+9SVeHPJU3j9rQwySUKC1iL3qz5LvFWwN2HcknZqnqZyk3evypgDond6VMwXn6mS+49a2oAwAniA7OZj+YJ4SDZUZH9PROFY2CWlQuWmlK8PGL0QDs3y/izZCHMfPidtjACPm5hkHbS93qyy/uih+vckmDYeXw3nB/MznQKPRsAvsXNQOVPGRcUttRkE1dDpDho3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsVyI1VUpqBk+pGl3kmQOl+bBeTI0C/Yl62jkn772wo=; b=nllHGFsjLQ45VJS5hjbOEKL/lW7jz23pAUjdk9iJFvjcsEsMvGCyTX7C7r60KKx0wQ4UQHpkfKofpceceXgWCTB4RrgkuEqRtETKSlZF2q14a+wPgI5GCw4BCZMRJwYeeAbZcjNIQWnFkBAXPCJrbyRoBz6yLV40MEbJSj/fwOJs5OkZPPKCjpr7wOwJuIvVKBZYpR/fUyXzaf3RX2a+/3brI4Ujt1ljqv6jnorLuFpQYv9N74jYSp6+vpsks/Llk/Q8xzBrxO3XZzIK9iymfuhKuQMsbYP5Jn4Xp3pYAhwzsjA/oRbCzuwZ3UAcTVzFGz5LaqdAKoreAdsNDwp5eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rsVyI1VUpqBk+pGl3kmQOl+bBeTI0C/Yl62jkn772wo=; b=cion+yf4XLFRbmOSeD9l5vDU4e1Ik7T4yrSooBQ+cYp4p6yfGQIMFtePC3TQ2Et7yeR1gRCjfu4DTBdW1TlFDoVEGKabpI8YlahzYbePCG2gfBoIPMnM8SS5FEXnb4CTjxUG4fts7ZaMUBas1vHlP+PPswZzmIZwGzpMoKVd+YNVjK60UaeDoJMQRIxiP9ns68hB7MQVyz4+DO7GL1ojMMdy+k+J+ZyXJ3xC7GEWPBlN4IrFlr2GWS/jQf8kqjcxanyneL5ZDBn6+ufPQVXUz3t3yC4VdyFLUOr+z+J5d/cn3PQYZNRRJrxXRlTBQubWAOPFT7aozBgseJZ0N4YVSg== Received: from DS7P220CA0043.NAMP220.PROD.OUTLOOK.COM (2603:10b6:8:224::8) by CY8PR12MB8410.namprd12.prod.outlook.com (2603:10b6:930:6d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.32; Wed, 30 Oct 2024 04:08:32 +0000 Received: from DS3PEPF0000C37A.namprd04.prod.outlook.com (2603:10b6:8:224:cafe::f2) by DS7P220CA0043.outlook.office365.com (2603:10b6:8:224::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.17 via Frontend Transport; Wed, 30 Oct 2024 04:08:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF0000C37A.mail.protection.outlook.com (10.167.23.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.16 via Frontend Transport; Wed, 30 Oct 2024 04:08:32 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 29 Oct 2024 21:08:18 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 29 Oct 2024 21:08:17 -0700 Received: from Asurada-Nvidia (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Tue, 29 Oct 2024 21:08:16 -0700 Date: Tue, 29 Oct 2024 21:08:14 -0700 From: Nicolin Chen To: "Tian, Kevin" CC: "jgg@nvidia.com" , "will@kernel.org" , "joro@8bytes.org" , "suravee.suthikulpanit@amd.com" , "robin.murphy@arm.com" , "dwmw2@infradead.org" , "baolu.lu@linux.intel.com" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "eric.auger@redhat.com" , "jean-philippe@linaro.org" , "mdf@kernel.org" , "mshavit@google.com" , "shameerali.kolothum.thodi@huawei.com" , "smostafa@google.com" , "Liu, Yi L" , "aik@amd.com" , "zhangfei.gao@linaro.org" , "patches@lists.linux.dev" Subject: Re: [PATCH v5 06/13] iommu: Add iommu_copy_struct_from_full_user_array helper Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37A:EE_|CY8PR12MB8410:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b3775fe-a618-4ce2-c427-08dcf89884cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UOak1QH5eecSXgkJecRzeA8JAg/J1gYjOFiuTbTpzTSUYT/DfKRxuNjksvha?= =?us-ascii?Q?quZVLrd2Jq7RKFejplbDfvdjCaH+OrObfuZL3T1StDt8ZuSjgHSYRDBDsVLZ?= =?us-ascii?Q?plFZKGQOi3kBs7Jr05AFEdxvwOhHVkQzU99L9AclvOFe5ltyvLDxiuPZXZ6r?= =?us-ascii?Q?2jSFjUkSuLzomB2LGPqZ4cN6mmoXdRIFAWzWGKJIEKJfCVCG4NM6w6R7xqW+?= =?us-ascii?Q?AVwQwmUS21ax7OG615h75iiMyHF1oLq/42MnTjv1eFmFH2OrxsC0wXAoJm0x?= =?us-ascii?Q?2s2zSqAEvxyMAVepWuDKXYsS3V4nj7vTYi7usIdpBjeTUYqU9P+NonxSgvwf?= =?us-ascii?Q?ExopoXPF0CVFcqwZe4EE0/SVoj5a96J30oYYJ3Cd70bWHG3TlOrU1wUc1hlZ?= =?us-ascii?Q?yRGay/QE3QDLGCtdeplKCl20N5OQ8C7uRLUM/E01T7MLOWLa624frart7DMd?= =?us-ascii?Q?pl7nsXBiEB2eCX3ScZpEPPB2vpRK7fgLoWPt7OyhYU7AOjcl2PcouhplKiG+?= =?us-ascii?Q?pOODVK+51QKjdEnMO3/B/znHGcEmTEo3+D6WaEyjSfIGQOBPdK+NRWI1iqoW?= =?us-ascii?Q?ckLDp0JY+GlV6LaZqOVFbb0XQkWHPXK2h8qe1q/X3u3eoM3/H0JsXdRRHGlo?= =?us-ascii?Q?ezDNzRpOZtB68rGXzwkADXqik1CEpIWSr6qrzykL8YhxbMn1Lgodl5Xtx58v?= =?us-ascii?Q?u2GJe8fEUAiTmF4tiuVELUZjBEEivrgaDZAeDhNDiOqJbHt5vF289Ab8wC3S?= =?us-ascii?Q?XE054k3vqOtGWPPQq+U+6CH9k7fYq88ewImPz0P+Rmy2kqHf3SztNmbVFbAX?= =?us-ascii?Q?lpvEp2hgaTZVSnvzSqb1sUKG35vlEcUUT18rWC3UERylNz0XP/qYgcCh7Agk?= =?us-ascii?Q?Hmtqs5Au05dO8a1UdDfDZ8reqUDqUFLP1fC6Sj63xOJMCHR++15KqlCZom+n?= =?us-ascii?Q?r7r3FeUMRia+KSw1vrkDvTUEIPGgfN4tXQ/0MgftVhly/PtnnItef22iujF5?= =?us-ascii?Q?exHFbjGUAL4nD6s7c7vqtXlPw5r5dZNV11JppaOpnxKFlPqq7Mx00EbOZmlv?= =?us-ascii?Q?dczQdzvAz/3tjufMWAwqD0suYpdyfitlbXwgxw3bquDgqkD3EkDEV+yFMwkw?= =?us-ascii?Q?B90EP1eDFpMoXPjb7fqE8R42bHIeTC1ev3j4l1GCM/11/8fr6wQOvqnmdedB?= =?us-ascii?Q?XJJCXKbvUThcbvnN7aM6efdfehnSvzpfeXYl6AY3z+bGpfS+q3orLfZjXKBt?= =?us-ascii?Q?iyVqezP2PwyeLZqjnThLhLYqr2mZ0GTPNHXjxjeEs5MelCoRxDf1a3Ik4zcV?= =?us-ascii?Q?P0vOq/GaUabGstVRHT1/jfsdsal7i7Ol1T+JZOMKISaxhNw/0749k+x/62Yx?= =?us-ascii?Q?9ap1AnwVBHLfaTWezifYjlvHgrjzDzgKtS82aukF7khBkydf3w=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(36860700013)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2024 04:08:32.5131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3775fe-a618-4ce2-c427-08dcf89884cf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8410 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241029_210844_117668_7D4B782E X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 29, 2024 at 08:24:52AM +0000, Tian, Kevin wrote: > > From: Nicolin Chen > > Sent: Saturday, October 26, 2024 7:51 AM > > > > From: Jason Gunthorpe > > > > The iommu_copy_struct_from_user_array helper can be used to copy a > > single > > entry from a user array which might not be efficient if the array is big. > > > > Add a new iommu_copy_struct_from_full_user_array to copy the entire user > > array at once. Update the existing iommu_copy_struct_from_user_array > > kdoc > > accordingly. > > what about: > > iommu_copy_struct_from_user_array_single() > iommu_copy_struct_from_user_array_full() I am okay with that, yet might prefer that in a separate patch? As I am trying to reduce the number of changes in the series since we are likely merging three series at once :) Thanks Nicolin > > Signed-off-by: Jason Gunthorpe > > Signed-off-by: Nicolin Chen > > Reviewed-by: Kevin Tian