* [PATCH v1 1/1] arm64: dts: layerscape: remove en25s64 and only keep jedec,spi-nor compatible string
@ 2024-10-23 20:11 Frank Li
2024-11-01 10:14 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Frank Li @ 2024-10-23 20:11 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
moderated list:ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
In jedec,spi-nor.yaml:
SPI NOR flashes compatible with the JEDEC SFDP standard or which may be
identified with the READ ID opcode (0x9F) do not deserve a specific
compatible. They should instead only be matched against the generic
"jedec,spi-nor" compatible.
en25s64 already in drivers/mtd/spi-nor/eon.c. So remove it safely and fix
below warning:
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: flash@2: compatible: 'oneOf' conditional failed, one must be fixed:
['en25s64', 'jedec,spi-nor'] is too long
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 2 +-
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
index bbdf989058ff7..ce59b94d8c228 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
@@ -87,7 +87,7 @@ flash@1 {
flash@2 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "en25s64", "jedec,spi-nor";
+ compatible = "jedec,spi-nor";
spi-cpol;
spi-cpha;
reg = <2>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index a1d9102ff32be..736722b58e77f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -69,7 +69,7 @@ flash@1 {
flash@2 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "en25s64", "jedec,spi-nor";
+ compatible = "jedec,spi-nor";
spi-cpol;
spi-cpha;
reg = <2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: layerscape: remove en25s64 and only keep jedec,spi-nor compatible string
2024-10-23 20:11 [PATCH v1 1/1] arm64: dts: layerscape: remove en25s64 and only keep jedec,spi-nor compatible string Frank Li
@ 2024-11-01 10:14 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2024-11-01 10:14 UTC (permalink / raw)
To: Frank Li
Cc: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
moderated list:ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Wed, Oct 23, 2024 at 04:11:28PM -0400, Frank Li wrote:
> In jedec,spi-nor.yaml:
> SPI NOR flashes compatible with the JEDEC SFDP standard or which may be
> identified with the READ ID opcode (0x9F) do not deserve a specific
> compatible. They should instead only be matched against the generic
> "jedec,spi-nor" compatible.
>
> en25s64 already in drivers/mtd/spi-nor/eon.c. So remove it safely and fix
> below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: flash@2: compatible: 'oneOf' conditional failed, one must be fixed:
> ['en25s64', 'jedec,spi-nor'] is too long
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-01 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 20:11 [PATCH v1 1/1] arm64: dts: layerscape: remove en25s64 and only keep jedec,spi-nor compatible string Frank Li
2024-11-01 10:14 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).