From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EF4CE6F06D for ; Fri, 1 Nov 2024 15:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MDBDtrud5eJtuuxZyPOJXE2RSRr8v+TyeHi88AUx8RA=; b=oZlmBivPc44JgbM8roMH8/ECws pnPMd5QGK8NKtOavpktwiCl/L8GvDgPHCEWGGEXoSAWzrobyDTd/7ExYnF85NDz7f160yoA5enC5Y TwzjQAJ/z39jOzK4llV+CFRpsZHG6KF8/yfTUGjnkNpXtduhYjaVZOGTv4zrWnMffr+ixxsdEzv32 WcxL4c6PdXRF65440zIBuQAKMOMHzIWas0Vj1JIacja7BuyGXMwYovEOTf+oKBuPYQPT9tfc4hXjL Gm/mEZW6WZmRP07q3ntp+V6wtMkrDS5k2xLgGLZHq4eBOotYhmLVf6WlsYs0sC5KwwP5CD2M+kWRH 2jD3/5AA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6tzm-00000007Zik-2PO5; Fri, 01 Nov 2024 15:55:30 +0000 Received: from out-183.mta0.migadu.com ([91.218.175.183]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6tjp-00000007XJ9-1JWl for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2024 15:39:04 +0000 Date: Fri, 1 Nov 2024 08:38:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730475537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MDBDtrud5eJtuuxZyPOJXE2RSRr8v+TyeHi88AUx8RA=; b=PClTnFcdIrcZ78W4jSshcODMfnNiSvNFtWKdgQXgVaJZCwGgQF3dDPomr/MvL2yA9B2Cwx sIxnO1FBfdPS2fhSPK5ZXdGtgALWc9G1JWP6xyny1RXUjNkwgAnqURsd9JAi0B3Jon4w0B kiA/rkElVf8i8EK1b4eQnPfLrgKPky8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sean Christopherson Cc: Mark Brown , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , James Houghton , David Woodhouse , linux-next@vger.kernel.org Subject: Re: [PATCH v3 03/14] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param Message-ID: References: <20241009154953.1073471-1-seanjc@google.com> <20241009154953.1073471-4-seanjc@google.com> <39ea24d8-9dae-447a-ae37-e65878c3806f@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241101_083901_820285_79544073 X-CRM114-Status: GOOD ( 26.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey, On Fri, Nov 01, 2024 at 07:48:00AM -0700, Sean Christopherson wrote: > On Fri, Nov 01, 2024, Mark Brown wrote: > > On Wed, Oct 09, 2024 at 08:49:42AM -0700, Sean Christopherson wrote: > > > Return a uint64_t from vcpu_get_reg() instead of having the caller provide > > > a pointer to storage, as none of the vcpu_get_reg() usage in KVM selftests > > > accesses a register larger than 64 bits, and vcpu_set_reg() only accepts a > > > 64-bit value. If a use case comes along that needs to get a register that > > > is larger than 64 bits, then a utility can be added to assert success and > > > take a void pointer, but until then, forcing an out param yields ugly code > > > and prevents feeding the output of vcpu_get_reg() into vcpu_set_reg(). > > > > This commit, which is in today's -next as 5c6c7b71a45c9c, breaks the > > build on arm64: > > > > aarch64/psci_test.c: In function ‘host_test_system_off2’: > > aarch64/psci_test.c:247:9: error: too many arguments to function ‘vcpu_get_reg’ > > 247 | vcpu_get_reg(target, KVM_REG_ARM_PSCI_VERSION, &psci_version); > > | ^~~~~~~~~~~~ > > In file included from aarch64/psci_test.c:18: > > include/kvm_util.h:705:24: note: declared here > > 705 | static inline uint64_t vcpu_get_reg(struct kvm_vcpu *vcpu, uint64_t id) > > | ^~~~~~~~~~~~ > > At top level: > > cc1: note: unrecognized command-line option ‘-Wno-gnu-variable-sized-type-not-at > > -end’ may have been intended to silence earlier diagnostics > > > > since the updates done to that file did not take account of 72be5aa6be4 > > ("KVM: selftests: Add test for PSCI SYSTEM_OFF2") which has been merged > > in the kvm-arm64 tree. > > Bugger. In hindsight, it's obvious that of course arch selftests would add usage > of vcpu_get_reg(). > > Unless someone has a better idea, I'll drop the series from kvm-x86, post a new > version that applies on linux-next, and then re-apply the series just before the > v6.13 merge window (rinse and repeat as needed if more vcpu_get_reg() users come > along). Can you instead just push out a topic branch and let the affected maintainers deal with it? This is the usual way we handle conflicts between trees... > That would be a good oppurtunity to do the $(ARCH) directory switch[*] too, e.g. > have a "selftests_late" or whatever topic branch. The right time to do KVM-wide changes (even selftests) is *early* in the development cycle, not last minute. It gives us plenty of time to iron out the wrinkles. > Sorry for the pain Mark, you've been playing janitor for us too much lately. +1, appreciate your help on this. -- Thanks, Oliver