linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address
@ 2024-10-25  1:08 Fabio Estevam
  2024-10-25  1:08 ` [PATCH 2/3] ARM: dts: imx6sx: Fix tempmon description Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-10-25  1:08 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, imx,
	Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

According to imx-thermal.yaml, the anatop regulators should not
contain unit-address/reg entries.

Change it accordingly.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
index 85fe2a4ab97a..0fc22c03ccea 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
@@ -507,12 +507,9 @@ anatop: anatop@20c8000 {
 				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
-				#address-cells = <1>;
-				#size-cells = <0>;
 
-				reg_3p0: regulator-3p0@20c8120 {
+				reg_3p0: regulator-3p0 {
 					compatible = "fsl,anatop-regulator";
-					reg = <0x20c8120>;
 					regulator-name = "vdd3p0";
 					regulator-min-microvolt = <2625000>;
 					regulator-max-microvolt = <3400000>;
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ARM: dts: imx6sx: Fix tempmon description
  2024-10-25  1:08 [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Fabio Estevam
@ 2024-10-25  1:08 ` Fabio Estevam
  2024-10-25  1:08 ` [PATCH 3/3] ARM: dts: imx6sl: Pass tempmon #thermal-sensor-cells Fabio Estevam
  2024-11-02  3:26 ` [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-10-25  1:08 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, imx,
	Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

According to imx-thermal.yaml, the valid compatible string
for i.MX6SX is just: compatible = "fsl,imx6sx-tempmon".

Also pass #thermal-sensor-cells = <0> as it is a required property.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
index b386448486df..a4abaee771eb 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
@@ -715,13 +715,14 @@ reg_soc: regulator-vddsoc {
 				};
 
 				tempmon: tempmon {
-					compatible = "fsl,imx6sx-tempmon", "fsl,imx6q-tempmon";
+					compatible = "fsl,imx6sx-tempmon";
 					interrupt-parent = <&gpc>;
 					interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
 					fsl,tempmon = <&anatop>;
 					nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
 					nvmem-cell-names = "calib", "temp_grade";
 					clocks = <&clks IMX6SX_CLK_PLL3_USB_OTG>;
+					#thermal-sensor-cells = <0>;
 				};
 			};
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] ARM: dts: imx6sl: Pass tempmon #thermal-sensor-cells
  2024-10-25  1:08 [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Fabio Estevam
  2024-10-25  1:08 ` [PATCH 2/3] ARM: dts: imx6sx: Fix tempmon description Fabio Estevam
@ 2024-10-25  1:08 ` Fabio Estevam
  2024-11-02  3:26 ` [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-10-25  1:08 UTC (permalink / raw)
  To: shawnguo
  Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, imx,
	Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

According to fsl,imx-anatop.yaml, #thermal-sensor-cells is a required
property.

Add it to fix the following dt-schema warning: 

tempmon: '#thermal-sensor-cells' is a required property

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
index 6aa61235e39e..6c98670a44ff 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
@@ -631,6 +631,7 @@ tempmon: tempmon {
 					nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
 					nvmem-cell-names = "calib", "temp_grade";
 					clocks = <&clks IMX6SL_CLK_PLL3_USB_OTG>;
+					#thermal-sensor-cells = <0>;
 				};
 			};
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address
  2024-10-25  1:08 [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Fabio Estevam
  2024-10-25  1:08 ` [PATCH 2/3] ARM: dts: imx6sx: Fix tempmon description Fabio Estevam
  2024-10-25  1:08 ` [PATCH 3/3] ARM: dts: imx6sl: Pass tempmon #thermal-sensor-cells Fabio Estevam
@ 2024-11-02  3:26 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-11-02  3:26 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
	imx, Fabio Estevam

On Thu, Oct 24, 2024 at 10:08:53PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to imx-thermal.yaml, the anatop regulators should not
> contain unit-address/reg entries.
> 
> Change it accordingly.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied all, thanks!



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-11-02  3:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-25  1:08 [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Fabio Estevam
2024-10-25  1:08 ` [PATCH 2/3] ARM: dts: imx6sx: Fix tempmon description Fabio Estevam
2024-10-25  1:08 ` [PATCH 3/3] ARM: dts: imx6sl: Pass tempmon #thermal-sensor-cells Fabio Estevam
2024-11-02  3:26 ` [PATCH 1/3] ARM: dts: imx6sll: Remove regulator-3p0 unit address Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).