From: Beata Michalska <beata.michalska@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>,
Sumit Gupta <sumitg@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org,
catalin.marinas@arm.com, rafael@kernel.org,
yang@os.amperecomputing.com, lihuisong@huawei.com,
zhanjie9@hisilicon.com, linux-tegra <linux-tegra@vger.kernel.org>,
Bibek Basu <bbasu@nvidia.com>
Subject: Re: [PATCH v7 3/4] arm64: Provide an AMU-based version of arch_freq_avg_get_on_cpu
Date: Mon, 4 Nov 2024 08:58:49 +0100 [thread overview]
Message-ID: <Zyh-uVSW-0d0r8oB@arm.com> (raw)
In-Reply-To: <20241029065319.zto3wlvceec3fjym@vireshk-i7>
On Tue, Oct 29, 2024 at 12:23:19PM +0530, Viresh Kumar wrote:
> On 10-10-24, 13:08, Beata Michalska wrote:
> > That is a fair point but I am not entirely convinced using '0' instead makes
> > things any more clearer as this is in no way a valid CPU frequency.
> > As long as we document the expected behaviour keeping the interface well
> > defined, both options should be fine I guess.
> >
> > @Viresh: what is your opinion on that one ?
>
> Failing to get frequency for the CPU shouldn't be represented by 0,
> even if it is confusing for the user.
We still need to decide whether provide a more descriptive way of informing
about such cases (whether it be 'unknown' or 'idle' ) or to simply return
an appropriate error and leave the userspace with dealing with that.
---
Thanks
Beata
>
> --
> viresh
next prev parent reply other threads:[~2024-11-04 8:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:29 [PATCH v7 0/4] Add support for AArch64 AMUv1-based average freq Beata Michalska
2024-09-13 13:29 ` [PATCH v7 1/4] cpufreq: Introduce an optional cpuinfo_avg_freq sysfs entry Beata Michalska
2024-09-25 8:58 ` Jie Zhan
2024-09-26 10:42 ` Beata Michalska
2024-10-29 7:04 ` Viresh Kumar
2024-10-29 11:31 ` Rafael J. Wysocki
2024-11-04 8:01 ` Beata Michalska
2024-11-04 13:26 ` Rafael J. Wysocki
2024-11-04 8:00 ` Beata Michalska
2024-11-08 6:28 ` Viresh Kumar
2024-09-13 13:29 ` [PATCH v7 2/4] arm64: amu: Delay allocating cpumask for AMU FIE support Beata Michalska
2024-09-13 13:29 ` [PATCH v7 3/4] arm64: Provide an AMU-based version of arch_freq_avg_get_on_cpu Beata Michalska
2024-09-17 12:11 ` Sumit Gupta
2024-09-26 10:34 ` Beata Michalska
2024-09-26 23:21 ` Vanshidhar Konda
2024-10-03 21:39 ` Beata Michalska
2024-10-03 21:54 ` Vanshidhar Konda
2024-10-10 11:08 ` Beata Michalska
2024-10-11 16:29 ` Vanshidhar Konda
2024-10-14 17:46 ` Sumit Gupta
2024-10-16 20:45 ` Beata Michalska
2024-10-29 6:53 ` Viresh Kumar
2024-11-04 7:58 ` Beata Michalska [this message]
2024-09-13 13:29 ` [PATCH v7 4/4] arm64: Update AMU-based freq scale factor on entering idle Beata Michalska
2024-10-16 10:59 ` [PATCH v7 0/4] Add support for AArch64 AMUv1-based average freq Catalin Marinas
2024-10-16 20:51 ` Beata Michalska
2024-10-27 18:16 ` Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyh-uVSW-0d0r8oB@arm.com \
--to=beata.michalska@arm.com \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=lihuisong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=sumitg@nvidia.com \
--cc=vanshikonda@os.amperecomputing.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).