From: Shawn Guo <shawnguo2@yeah.net>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: imx8mp: add aristainetos3 board support
Date: Mon, 4 Nov 2024 15:13:06 +0800 [thread overview]
Message-ID: <Zyh0AgJZh1//17Te@dragon> (raw)
In-Reply-To: <5340fb82-bda0-d22f-23df-de620c8d61c3@denx.de>
On Mon, Nov 04, 2024 at 06:33:55AM +0100, Heiko Schocher wrote:
> > > +
> > > + semtech,probe-reset;
> > > + gpio-controller;
> > > + interrupt-controller;
> > > +
> > > + interrupt-parent = <&gpio1>;
> > > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
> > > + };
>
> Should I remove newlines here too?... but looking into the example from
>
> Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
>
> there are this newlines ... so I let this lines in... or?
Not having newlines in middle of property list is just a style that
I prefer for IMX device trees.
Shawn
next prev parent reply other threads:[~2024-11-04 7:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 15:12 [PATCH v2 0/3] arm64: dts: imx8mp: add support for the ABB SoM and carrier Heiko Schocher
2024-10-31 15:12 ` [PATCH v2 3/3] arm64: dts: imx8mp: add aristainetos3 board support Heiko Schocher
2024-11-03 9:41 ` Shawn Guo
2024-11-04 5:33 ` Heiko Schocher
2024-11-04 7:13 ` Shawn Guo [this message]
2024-11-04 7:54 ` Heiko Schocher
2024-11-04 11:15 ` Fabio Estevam
2024-11-04 12:01 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyh0AgJZh1//17Te@dragon \
--to=shawnguo2@yeah.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hs@denx.de \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).