Re: [PATCH v1] ARM: imx_v6_v7_defconfig: enable SND_SOC_SPDIF

Stefan Wahren
2024-11-02T15:37:40Z

Hi Stefan,

Am 02.11.24 um 15:36 schrieb Stefan Eichenberger:
> Hi Shawn,
>
> On Sat, Nov 02, 2024 at 03:21:58PM +0800, Shawn Guo wrote:
>> On Wed, Oct 30, 2024 at 01:21:12PM +0100, Stefan Eichenberger wrote:
>>> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>>>
>>> Enable SND_SOC_SPDIF in imx_v6_v7_defconfig to support SPDIF audio. This
>>> change will fix commit d469b771afe1 ("ARM: dts: imx6: update spdif sound
>>> card node properties") which moves away from the old "spdif-controller"
>>> property to the new "audio-codec" property.
>>>
>>> Fixes: d469b771afe1 ("ARM: dts: imx6: update spdif sound card node properties")
>> It doesn't look a fix to me.
> I agree somehow, it was just that before the referenced commit our test
> succeeds with the imx_v6_v7_defconfig and after that we get the
> following error:
> [ 24.165534] platform sound-spdif: deferred probe pending: fsl-asoc-card: snd_soc_register_card failed
this error should have been in the commit message including the
information which platform/board is affected.

> So maybe it is not a fix in the sense of a bug, but it fixes the error
> message. However, I'm also fine with removing the Fixes tag.
But this patch doesn't look like the real approach.

Could you please clarify the impact of the regression?

Is it just this error message and audio works fine or is audio also broken?

Regards
>
> Regards,
> Stefan
>
>
>