From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] kselftest/arm64: Remove unused ADRs from irritator handlers
Date: Wed, 6 Nov 2024 11:29:57 +0000 [thread overview]
Message-ID: <ZytTNXaOGZkH6rME@J2N7QTR9R3> (raw)
In-Reply-To: <20241023-arm64-fp-stress-irritator-v1-2-a51af298d449@kernel.org>
On Wed, Oct 23, 2024 at 09:38:30PM +0100, Mark Brown wrote:
> The irritator handlers for the fp-stress test programs all use ADR to load
> an address into x0 which is then not referenced. Remove these ADRs as they
> just cause confusion.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> tools/testing/selftests/arm64/fp/fpsimd-test.S | 1 -
> tools/testing/selftests/arm64/fp/sve-test.S | 1 -
> tools/testing/selftests/arm64/fp/za-test.S | 1 -
> tools/testing/selftests/arm64/fp/zt-test.S | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/arm64/fp/fpsimd-test.S b/tools/testing/selftests/arm64/fp/fpsimd-test.S
> index bdfb7cf2e4ec175fda62c1c2f38c6ebb1a1c48bf..9977ffdd758a51a7af67cd607d019a6c54d3a6c6 100644
> --- a/tools/testing/selftests/arm64/fp/fpsimd-test.S
> +++ b/tools/testing/selftests/arm64/fp/fpsimd-test.S
> @@ -142,7 +142,6 @@ function irritator_handler
> str x0, [x2, #ucontext_regs + 8 * 23]
>
> // Corrupt some random V-regs
> - adr x0, .text + (irritator_handler - .text) / 16 * 16
> movi v0.8b, #7
> movi v9.16b, #9
> movi v31.8b, #31
> diff --git a/tools/testing/selftests/arm64/fp/sve-test.S b/tools/testing/selftests/arm64/fp/sve-test.S
> index e3c0d585684df29723a49265f3df6d23817498c7..f1fb9745c681786f686f1fafcb7e1154f3c8e1a3 100644
> --- a/tools/testing/selftests/arm64/fp/sve-test.S
> +++ b/tools/testing/selftests/arm64/fp/sve-test.S
> @@ -299,7 +299,6 @@ function irritator_handler
> str x0, [x2, #ucontext_regs + 8 * 23]
>
> // Corrupt some random Z-regs
> - adr x0, .text + (irritator_handler - .text) / 16 * 16
> movi v0.8b, #1
> movi v9.16b, #2
> movi v31.8b, #3
> diff --git a/tools/testing/selftests/arm64/fp/za-test.S b/tools/testing/selftests/arm64/fp/za-test.S
> index 095b45531640966e685408057c08ada67e68998b..1ee0ec36766d2bef92aff50a002813e76e22963c 100644
> --- a/tools/testing/selftests/arm64/fp/za-test.S
> +++ b/tools/testing/selftests/arm64/fp/za-test.S
> @@ -158,7 +158,6 @@ function irritator_handler
>
> // Corrupt some random ZA data
> #if 0
> - adr x0, .text + (irritator_handler - .text) / 16 * 16
> movi v0.8b, #1
> movi v9.16b, #2
> movi v31.8b, #3
> diff --git a/tools/testing/selftests/arm64/fp/zt-test.S b/tools/testing/selftests/arm64/fp/zt-test.S
> index b5c81e81a37946c1bffe810568855939e9ceb08e..ade9c98abcdafc2755ef4796670566d99e919e5c 100644
> --- a/tools/testing/selftests/arm64/fp/zt-test.S
> +++ b/tools/testing/selftests/arm64/fp/zt-test.S
> @@ -127,7 +127,6 @@ function irritator_handler
>
> // Corrupt some random ZT data
> #if 0
> - adr x0, .text + (irritator_handler - .text) / 16 * 16
> movi v0.8b, #1
> movi v9.16b, #2
> movi v31.8b, #3
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-11-06 12:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 20:38 [PATCH 0/6] kselftest/arm64: Test floating point signal context restore in fp-stress Mark Brown
2024-10-23 20:38 ` [PATCH 1/6] kselftest/arm64: Correct misleading comments on fp-stress irritators Mark Brown
2024-11-06 11:29 ` Mark Rutland
2024-10-23 20:38 ` [PATCH 2/6] kselftest/arm64: Remove unused ADRs from irritator handlers Mark Brown
2024-11-06 11:29 ` Mark Rutland [this message]
2024-10-23 20:38 ` [PATCH 3/6] kselftest/arm64: Corrupt P15 in the irritator when testing SSVE Mark Brown
2024-11-06 11:27 ` Mark Rutland
2024-11-06 12:46 ` Mark Brown
2024-10-23 20:38 ` [PATCH 4/6] kselftest/arm64: Implement irritators for ZA and ZT Mark Brown
2024-11-06 11:31 ` Mark Rutland
2024-10-23 20:38 ` [PATCH 5/6] kselftest/arm64: Provide a SIGUSR1 handler in the kernel mode FP stress test Mark Brown
2024-11-06 11:32 ` Mark Rutland
2024-10-23 20:38 ` [PATCH 6/6] kselftest/arm64: Test signal handler state modification in fp-stress Mark Brown
2024-11-06 11:33 ` Mark Rutland
2024-10-28 14:26 ` [PATCH 0/6] kselftest/arm64: Test floating point signal context restore " Mark Rutland
2024-10-28 15:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZytTNXaOGZkH6rME@J2N7QTR9R3 \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox