* [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly
[not found] <20241118072917.3853-1-wsa+renesas@sang-engineering.com>
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-18 10:34 ` Suzuki K Poulose
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys - " Wolfram Sang
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Suzuki K Poulose, Mike Leach, James Clark,
Alexander Shishkin, coresight, linux-arm-kernel
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
index 66d44a404ad0..559972a00fdf 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
@@ -23,7 +23,6 @@
#include <linux/cpu_pm.h>
#include <linux/coresight.h>
#include <linux/coresight-pmu.h>
-#include <linux/pm_wakeup.h>
#include <linux/amba/bus.h>
#include <linux/seq_file.h>
#include <linux/uaccess.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly Wolfram Sang
@ 2024-11-18 10:34 ` Suzuki K Poulose
2024-11-18 19:34 ` Wolfram Sang
0 siblings, 1 reply; 9+ messages in thread
From: Suzuki K Poulose @ 2024-11-18 10:34 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: Mike Leach, James Clark, Alexander Shishkin, coresight,
linux-arm-kernel
On 18/11/2024 07:29, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 66d44a404ad0..559972a00fdf 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -23,7 +23,6 @@
> #include <linux/cpu_pm.h>
> #include <linux/coresight.h>
> #include <linux/coresight-pmu.h>
> -#include <linux/pm_wakeup.h>
> #include <linux/amba/bus.h>
> #include <linux/seq_file.h>
> #include <linux/uaccess.h>
If you plan to take this as a collection outside of CoreSight tree,
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Otherwise, I can pick this up.
Suzuki
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly
2024-11-18 10:34 ` Suzuki K Poulose
@ 2024-11-18 19:34 ` Wolfram Sang
0 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2024-11-18 19:34 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: linux-kernel, Mike Leach, James Clark, Alexander Shishkin,
coresight, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
> If you plan to take this as a collection outside of CoreSight tree,
>
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Otherwise, I can pick this up.
As stated in the cover letter, please pick it up. There are no
dependencies.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 06/15] Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly
[not found] <20241118072917.3853-1-wsa+renesas@sang-engineering.com>
2024-11-18 7:29 ` [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly Wolfram Sang
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
2024-11-18 7:29 ` [PATCH 13/15] rtc: brcmstb-waketimer: " Wolfram Sang
2024-11-18 7:29 ` [PATCH 14/15] usb: typec: tcpci_mt6370: " Wolfram Sang
3 siblings, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Hans de Goede, Dmitry Torokhov, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, linux-input, linux-arm-kernel,
linux-sunxi
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/input/keyboard/sun4i-lradc-keys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index f304cab0ebdb..9a4fdef2650e 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -24,7 +24,6 @@
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pm_wakeirq.h>
-#include <linux/pm_wakeup.h>
#include <linux/property.h>
#include <linux/regulator/consumer.h>
#include <linux/reset.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 06/15] Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys - " Wolfram Sang
@ 2024-11-20 5:36 ` Dmitry Torokhov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2024-11-20 5:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Hans de Goede, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, linux-input, linux-arm-kernel, linux-sunxi
On Mon, Nov 18, 2024 at 08:29:05AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 13/15] rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly
[not found] <20241118072917.3853-1-wsa+renesas@sang-engineering.com>
2024-11-18 7:29 ` [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h' directly Wolfram Sang
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys - " Wolfram Sang
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-18 13:48 ` (subset) " Alexandre Belloni
2024-11-18 7:29 ` [PATCH 14/15] usb: typec: tcpci_mt6370: " Wolfram Sang
3 siblings, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Alexandre Belloni, Florian Fainelli,
Broadcom internal kernel review list, linux-rtc, linux-arm-kernel
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/rtc/rtc-brcmstb-waketimer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c
index 1a65a4e0dc00..6c7701b24ba5 100644
--- a/drivers/rtc/rtc-brcmstb-waketimer.c
+++ b/drivers/rtc/rtc-brcmstb-waketimer.c
@@ -17,7 +17,6 @@
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pm.h>
-#include <linux/pm_wakeup.h>
#include <linux/reboot.h>
#include <linux/rtc.h>
#include <linux/stat.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: (subset) [PATCH 13/15] rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 13/15] rtc: brcmstb-waketimer: " Wolfram Sang
@ 2024-11-18 13:48 ` Alexandre Belloni
0 siblings, 0 replies; 9+ messages in thread
From: Alexandre Belloni @ 2024-11-18 13:48 UTC (permalink / raw)
To: linux-kernel, Wolfram Sang
Cc: Florian Fainelli, Broadcom internal kernel review list, linux-rtc,
linux-arm-kernel
On Mon, 18 Nov 2024 08:29:12 +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
>
Applied, thanks!
[13/15] rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly
https://git.kernel.org/abelloni/c/5b42edefd733
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 14/15] usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly
[not found] <20241118072917.3853-1-wsa+renesas@sang-engineering.com>
` (2 preceding siblings ...)
2024-11-18 7:29 ` [PATCH 13/15] rtc: brcmstb-waketimer: " Wolfram Sang
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-19 15:53 ` Heikki Krogerus
3 siblings, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Heikki Krogerus, Greg Kroah-Hartman,
Matthias Brugger, AngeloGioacchino Del Regno, linux-usb,
linux-arm-kernel, linux-mediatek
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
index 9cda1005ef01..bc5fd2557e6f 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
@@ -11,7 +11,6 @@
#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
#include <linux/pm_wakeirq.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 14/15] usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 14/15] usb: typec: tcpci_mt6370: " Wolfram Sang
@ 2024-11-19 15:53 ` Heikki Krogerus
0 siblings, 0 replies; 9+ messages in thread
From: Heikki Krogerus @ 2024-11-19 15:53 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Greg Kroah-Hartman, Matthias Brugger,
AngeloGioacchino Del Regno, linux-usb, linux-arm-kernel,
linux-mediatek
On Mon, Nov 18, 2024 at 08:29:13AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 9cda1005ef01..bc5fd2557e6f 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -11,7 +11,6 @@
> #include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/pm_wakeup.h>
> #include <linux/pm_wakeirq.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> --
> 2.39.2
--
heikki
^ permalink raw reply [flat|nested] 9+ messages in thread