From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14255D3ABFA for ; Mon, 11 Nov 2024 22:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FFGJr08QbUH77iRYXHLZw6jy0LQbBzLG89bnZrMoR60=; b=xanM/ble1pjUr5n2QLRFT7EX5k D+MouQ9Gde3z9IFpwTkFiQWYDhieq248HbeuId+Zuwvdyj0UabIqG/+hHdbybTeQ0RnmxemEfvLN9 OaUiAGhU7TxqDJCCMNrh3TSTzpyR1uDo6G0AIhejtnzG+Rsg66wKxseNrTjHZH8eWinJJVN0SpxXG FH/0bjjJwW4RRo3BwFCOKaLRgGMJEWhL6BrL0X7pd0rl8pkOqWLbSAsk3+zrhhjtdK1hTka5Xxl3h VE6LLU6T0ywE79AkDJtMPLHvjRq2VH9xOYDyD4EAbFh5rpBmyNgxvFLDWVBLmn3FU0QgomzkzlLfw uODu78hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAcTw-00000001R7q-1pqU; Mon, 11 Nov 2024 22:02:00 +0000 Received: from mail-db5eur02on20626.outbound.protection.outlook.com ([2a01:111:f403:2608::626] helo=EUR02-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAcS9-00000001Qwr-05CF for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2024 22:00:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SdULudpxprT+lxncZJ8wqEhIFlzNTspDFsc8q9Vkl/86OOAFu6GOiv9h+RVnXmyqunNxyMXOMjzqwzMBdSgrH+fCfn89YF9Elyesj3SFtSkhkB3KqhWayZ0HyICodUgicWnBJ5NKWD5WwwvJDU699wM35LPb502N1p2p6BejrjuJJmJaEBAMv2rSNrNdgWbF+gJfZeA5fpggsJFjvR5IeBNfbDBYF7xvhjCZPC8u+MevmNNVwGWEjjSHEg0mrqtBhZK228uuETufUVLETm+12cWA8WPHg1+xKL4xJfW7GE8+lEyT7E+hbe5raCYTN1pgiUM2nXJ9XamLzm8qGe+fsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FFGJr08QbUH77iRYXHLZw6jy0LQbBzLG89bnZrMoR60=; b=pklY+LZpGVMLqJdeknF1piBAzy2oneM3Yt6v/Uehi50b+ga+QlD1dbGbHic38vtwZWk0c1tK7vzftDBVBE4k1IUz3T5RWCS+XWxGUsNnbY+LbgOccraxMUjPS6arSJdUuYToaLOsJ96MzcbzUx3uxip5XNuPYjAGWFNUh/KKkJQVQove1rxTEyXo5xhOfNOWqkGGG5vx0TMIl+jQi3kMZEESKRTgoZvVygkLDVZeS5OhvajmuIY/RFQ74k+DmuitSnWZYvSG15i3xlDIajMdWXoAbLVbYOae8xatn1SKUZ6EQ1XithMQcHxIOIa1pTWoeH4kIhc4XCejQcWUBXaUEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FFGJr08QbUH77iRYXHLZw6jy0LQbBzLG89bnZrMoR60=; b=AiAGiDhYwCmXNF5/PbyGoUqDnn3x00ZeSaJGtLS2ic2x1zvYpexqwZkqf3vDShurB5By3nRCzL+zK5PfKIRWcjvhaBp0q3HSvgXUIsXBaP4LLJ5qmOXyfAxcYFi3iO9X9T7dNVrZn7Cmu+vdUI9hUrxH8KAn0EY1wBgIwalybhv2BXISkKFVi/Gmidj8+Mpp+gJL0QX7uQTO5gc53ycGpdk/ettbUHKEjLGjpc5gFGkd8z2IQ/PGsHTrbwdwID2GoPlkVblL+askMC+9GA+1vALegdeBVo9fsgoF2ii6DfRKYQ9e2Ds2fxnnG92IapzCpCt8NPQios2Iadg21fpjYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8192.eurprd04.prod.outlook.com (2603:10a6:102:1cd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 22:00:04 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 22:00:04 +0000 Date: Mon, 11 Nov 2024 16:59:55 -0500 From: Frank Li To: Guenter Roeck Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jean Delvare , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , linux-hwmon@vger.kernel.org Subject: Re: [PATCH v3 3/5] hwmon: tmp108: Add helper function tmp108_common_probe() to prepare I3C support Message-ID: References: <20241111-p3t1085-v3-0-bff511550aad@nxp.com> <20241111-p3t1085-v3-3-bff511550aad@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BYAPR03CA0035.namprd03.prod.outlook.com (2603:10b6:a02:a8::48) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8192:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bbd545b-3fb4-45f5-7974-08dd029c3296 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|366016|376014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?M24PRYGuOM7lRX79aREOrgcha5rVYCIMGpCBG7Key/ZE3gYj752ywjO1yApB?= =?us-ascii?Q?FP6sHlqTo6hczawJTaClxrsnr+wTBy5UKj/SDWLjhCdZ4ANAbkk0TWIqfhc4?= =?us-ascii?Q?SOuYGEPc0ofhWN87fIe0939eX3IyDMR7+7Zu7gzDWartaiMMR887x/FWa9uU?= =?us-ascii?Q?7cJxdOAL+bgocoMvmvMId86CIThecyYtKsiBOaOktViFh5SXQ3mXNJdJQQj6?= =?us-ascii?Q?3aY+0Lf7tpsK+/rr2sC6v0gqFbDDokzK0P8QGpBBcMLHzamPKtZf3aV0QiO7?= =?us-ascii?Q?Zbn4rECa4QM1kgfw13utjDPub7m5hxVIYQ68Qsg+X8H/HCE2yQmg25ckmDIR?= =?us-ascii?Q?TKQ04GxdNS2a8yh755EyrbjtgoaR4kBBruHAJyK3g1H5xY9s0U9PyIkKkAYp?= =?us-ascii?Q?C95knQQw8WOhpON6qBVz3O2NJ/fGSYhM9Wj4l3cKTS5iiJGl+TeceogU7RUC?= =?us-ascii?Q?pfHqljQE1vyLKxaUfjNMz03aWLjrfRC0nZaSZ7QJnGzYQw3Aatn8ZcF8A0Wm?= =?us-ascii?Q?dBUikod7gr++o9IBz4qnv1/lUtWyn7nBoWVP9n8HtrbzCxCrLnHsgBofrq+w?= =?us-ascii?Q?E1PuMzc7cFMQ1s5olN0gXwDY+jP5UTwWAr6ADLx2tjYG43kMsJtTIa5sW105?= =?us-ascii?Q?78XQsUh4xl2eLg2wHrtPT6gcbP2s51MZbt4+YK3++FXnXx85kv2W0Q8OL2tW?= =?us-ascii?Q?2xVOWDcX1pMDEgHAng+ebHeaGqjk2UWlPXH8NLiUKhKqlBeUcsFXqXatsaRO?= =?us-ascii?Q?H9GLXVKLWdPdMRywN9oc174TdfiYBUAp4BB456kaewO0U3QdqmViSB+qc0Np?= =?us-ascii?Q?IQl4h7xrO/KgdOdy67B2ZKomDLbVIxCv7KRDyX3/IO2ou6fVBNpXs8iR+Tih?= =?us-ascii?Q?2ohbvTuQYsEleu+xOsKJxWXnZiTm54UgpAdimlx8FanLV4dzyBzQgzsnbZU1?= =?us-ascii?Q?Hk16iOTqsrM1klw0h3Jh2KK8yKDeXVzGZhA6CuV/xlezoBOMRHb7pjJY4UVu?= =?us-ascii?Q?V++RnjF8evyght0lPzxaIUaNpmbk5q+phUECM020gHEn2BaxvOUfQifVUB0q?= =?us-ascii?Q?FHSNA/eupW8D90cLAGCus53/6JzMMT1DgfaFnw02otukYwWXpSlmpdsLNVSA?= =?us-ascii?Q?xGO8BTN1YkJfPCEZP3kUNjkbLl3+B4LcYQUAkBany0J3sIEGIaVcqU/0KDV0?= =?us-ascii?Q?RMuowVpWA/g53u94LPzNd4bk3fu/7Xhl0hxBNsvEOrSr+G22/iTKz1+r4Hw+?= =?us-ascii?Q?N57wXYJTq3bEbbUA1bbaqONiKkOlIRmmios2VtiUtU1f8rCOPUaBm0UMEVpb?= =?us-ascii?Q?35EThSDEXewy5+6PJJfoc7aZ9GeJAlp04/qABT/GnMnYoIpiu+3fdNibXcwb?= =?us-ascii?Q?uMj7muw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(366016)(376014)(7416014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kfjg9tbFHQoag926pW3IFGmpaxz5ccMOTQGVc1a42jydIN92cOYj5OZ8RIfI?= =?us-ascii?Q?rO+hBINKsNC1q0PUA91+FGe3qRlTGVtLpSFtrsgnZriFuaYMXEFcg95054iS?= =?us-ascii?Q?lSIRFQ4B1qhN543/gx70SFZJb+w/oNy9NixODSfYe+ZQHhzmzORydzFbiVGa?= =?us-ascii?Q?ZpJq1GOJ7rx7ak2PKrOWKSqe5RA6EnXz5ZHjnXmk83/lsdNp7H+3pF4HlXeS?= =?us-ascii?Q?xwKmhmTfbvLa2int0PanubrqDbVPrYkafXG2hczMH9nw+KVMISdC687GjjO4?= =?us-ascii?Q?jh6TxYAwPSdoxL489UuZRNilIiD1R2NBjzxmad1F4idLBYOKSE3xLgbRawbk?= =?us-ascii?Q?STeYuUjIwdGmEc8sTmxEydNSucjGM8EhVZWno2BRFFOF77wkmnFVw9pZ26i4?= =?us-ascii?Q?7ZC9sGJC+eoST3le+ZOYehV3qGjDFyS66uvJmLOKlpcLOmxiEOgNb6NGEsKB?= =?us-ascii?Q?9vYEj6r+D84yGLvylVFLNPvLkOJ0Sm5m6yyr5OME1VsCGX1KLZjNijrIQGf8?= =?us-ascii?Q?3kb88y7NOz2EUw+ZPdohBmyHygxMo3OCFotiW6STK9jDUPNRitkVr4th5Azo?= =?us-ascii?Q?ibRNcaH2m/0Aiboo8szK6UiSDaDpm1erX+PH3nVBJqjy/N8kGURnMcTbqy9a?= =?us-ascii?Q?983cRTPgN9g7laBpVwvOLHrq7bgbOMLrQVhIvQKRgcstmZyvmzY/qXyHqgD1?= =?us-ascii?Q?1Pur6ARq9yPtEUDOeRK3ENXjM3XU9UJKBiT6/TtgW0y8AB9vEZz+/wv+Gl5v?= =?us-ascii?Q?vGhgYz7/WivT82doj2lap05i/+likY7Qf4JtEIgpydG8Nx1ut2kqBRb62dzr?= =?us-ascii?Q?aJGPo70K+qk67pYecEVcIJhJQ6rUJvxOYDDutKp3R253jm7rVFM6JOxK/nJR?= =?us-ascii?Q?GJu3E6/xK/czBb+v9q9YjCIEVavUdajZRera2hv2PO3qmRS3+mP5+NJnmdb3?= =?us-ascii?Q?GvJC5ZhJ+Je4uBQMVFEYYgcKXbf2NfA15Ohzh6FoyLOIgEFfuC+qeMWJUUF5?= =?us-ascii?Q?aY3vlMMvGrMBy1H0bFyzxgmes97H1r/L81TScG1iKy8swY+gCLPszn5dHy/V?= =?us-ascii?Q?8D18xxlRHgyEQnggbAjTnJXNnJbqD4eO2hWJAKvU/wlWx0UkR28XKq8QJ/NX?= =?us-ascii?Q?EKAFFeMEThb8nqnmcXm4qCP+fgGKGYqQxgW50C8ua+ofIgK4tK8I09POOePS?= =?us-ascii?Q?H9WyjLHVdwZ6AZetqhWnFtFj6eznMLc/a0OQPEroUAWnG6/voHwZmD6KK8y4?= =?us-ascii?Q?KjXh88UeAYF61rFmyfCoL3gFCIaeEX63dJbJ+WhEQXWERbEhsFpPG5gFJ39f?= =?us-ascii?Q?uLt2BhQ2T+vTDQj0e7ttYzzkg4JFV+mh7ljQ9nY665kcwH/i1safeM2kNqhK?= =?us-ascii?Q?EZgFsiHG2+aELyS8C6AdRsY8bxrqXEU1AUgR4nM9DyURmnUdxk6D321di7v4?= =?us-ascii?Q?wEWzbEI0goDuHl8WcpvZmstuo76UTnodW+wvbepRVed7cQwNHXQNjUSGWOeE?= =?us-ascii?Q?nmRJbobSq/XVU7DCajyL7JgB+F6ITRku6nKXQJpovUdDztLTmm5+bmvlJQHl?= =?us-ascii?Q?Y1RgmSFyKnaa9d404wg19h+KNUCjibXPrpnYzHYQ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bbd545b-3fb4-45f5-7974-08dd029c3296 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 22:00:04.5644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EUpkiiiR0EWqU7u67ciIUQ6uNfb5sab/QZGdz1C5yJx3ID87Z9/RPxOvNERsoo8bSoEuRrhHpwESY+ETN2AQ9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8192 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241111_140009_111885_4AA56D03 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 11, 2024 at 11:44:08AM -0800, Guenter Roeck wrote: > On 11/11/24 09:32, Frank Li wrote: > > Add help function tmp108_common_probe() to pave road to support i3c for > > P3T1085(NXP) chip. > > > > Use dev_err_probe() to simple code. > > > > Signed-off-by: Frank Li > > I applied the first two patches of the series, but I am holding back this > and the subsequent patches since I don't know how the kernel handles having > two drivers in a single module, and one of them fails to instantiate. I did > not find a matching example elsewhere in the kernel. We may have to use > the method used by the st_lsm6dsx driver - essentially splitting the driver > into three parts (i2c, i3c, and common). That would be overkill; the alternative > might be something like the approach used by module_i3c_i2c_driver(), but with > a set of #ifdefs around (some of) the i3c code. Thanks, let me think more about this. > > Guenter >