* [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property
@ 2024-11-12 7:20 Jenishkumar Maheshbhai Patel
2024-11-12 9:21 ` Russell King (Oracle)
0 siblings, 1 reply; 2+ messages in thread
From: Jenishkumar Maheshbhai Patel @ 2024-11-12 7:20 UTC (permalink / raw)
To: linux, andrew, gregory.clement, sebastian.hesselbarth, robh,
krzk+dt, conor+dt, linux-arm-kernel, devicetree, linux-kernel
Cc: salee, dingwei, Jenishkumar Maheshbhai Patel
Set reset gpio to active high
Fixes: b83e1669adce ("arm64: dts: marvell: mcbin: add support for PCIe")
Signed-off-by: Jenishkumar Maheshbhai Patel <jpatel2@marvell.com>
---
arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index c864df9ec84d..a8c732a47360 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -181,7 +181,7 @@ &cp0_pcie0 {
pinctrl-0 = <&cp0_pcie_pins>;
num-lanes = <4>;
num-viewport = <8>;
- reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_HIGH>;
ranges = <0x82000000 0x0 0xc0000000 0x0 0xc0000000 0x0 0x20000000>;
phys = <&cp0_comphy0 0>, <&cp0_comphy1 0>,
<&cp0_comphy2 0>, <&cp0_comphy3 0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property
2024-11-12 7:20 [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property Jenishkumar Maheshbhai Patel
@ 2024-11-12 9:21 ` Russell King (Oracle)
0 siblings, 0 replies; 2+ messages in thread
From: Russell King (Oracle) @ 2024-11-12 9:21 UTC (permalink / raw)
To: Jenishkumar Maheshbhai Patel
Cc: andrew, gregory.clement, sebastian.hesselbarth, robh, krzk+dt,
conor+dt, linux-arm-kernel, devicetree, linux-kernel, salee,
dingwei
On Mon, Nov 11, 2024 at 11:20:49PM -0800, Jenishkumar Maheshbhai Patel wrote:
> Set reset gpio to active high
>
> Fixes: b83e1669adce ("arm64: dts: marvell: mcbin: add support for PCIe")
>
> Signed-off-by: Jenishkumar Maheshbhai Patel <jpatel2@marvell.com>
> ---
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> index c864df9ec84d..a8c732a47360 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> @@ -181,7 +181,7 @@ &cp0_pcie0 {
> pinctrl-0 = <&cp0_pcie_pins>;
> num-lanes = <4>;
> num-viewport = <8>;
> - reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_HIGH>;
Is this change due to switching the driver to use the reset controller?
If so, NAK to all the changes - DT files are meant to be forwards
compatible (older DT are supposed to work with newer kernels) and it
would seem this would break that rule.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-12 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 7:20 [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property Jenishkumar Maheshbhai Patel
2024-11-12 9:21 ` Russell King (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).