From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF354D32D9A for ; Tue, 12 Nov 2024 12:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EAcE5oUgAJrkvApezWgjVL4hFwcbHu3FlJoU3lH0Xa8=; b=Afg+LtXl4dTk4n5H9g+U1geuTS XvYx29Uqsmc0/gcSUrSdu2z+5ME/vMMa/1D/UcN1OTK7hImc2PoZWO5Cr4xHQHgpJj3tQDAA2W6rZ G5yWIVWn3Os0fDHy4d6Ao1huwj+pjHQDBunURDm9egZLJkUq31LyCuzaO6vlo9GovDvUwIgeOJtD3 G8TNzPN3U41Ayr1kmhLeP7YH0agHAkqFGVMvTjE/Rpz5SCcKn1BGIT+XPzD6XxxYoNnUCnPiQvVmE TO3rpqTe+S69Gd1tmV8Z0wFDcT56kT6bh15yicvezDX2sl6wF1+ETQpiiycg7zSB7egSN9npbm//p 4BIVab0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tAqKN-00000003Rn8-0wOm; Tue, 12 Nov 2024 12:49:03 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tAqHf-00000003RFN-1cOJ for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2024 12:46:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C07E6A41B4B; Tue, 12 Nov 2024 12:44:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FFECC4CECD; Tue, 12 Nov 2024 12:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731415573; bh=nMAsToNIcVM8JoD6fxjSGbyscGJjSG2b6I49R2ndqy8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ck8YQQJVavF0HxwsvFfVoCb4+GhgMju3ccWHOYSso34WQ689bu3iMeMOcfxa1pHWR /MubC0TWmb/xSzcfnl61EjLghyo+YXana+m0D/HM8cd3bvXXb2vu/BDrd+oVsC+KHa jiXYA9H7yIXtvJsUesu760tX3deoUxoLGsEVR+L2g7n50CElVCjuuccxO9WLFmFJSs xrOY7e003xZ+gVeOOTEm1QChAmTa5jbz1UWaquiScIYYbTCtfnQh3owMTmhkOHgpAz Z6CYgzkEPXJfGTi9iFXsIFmraH5JKb4Sw71hkvr+gZ4EOCPgCiMln6Et0HsoaICOCP +uJj/KsZ/5FYQ== Date: Tue, 12 Nov 2024 13:46:07 +0100 From: Niklas Cassel To: Rob Herring Cc: frank-w@public-files.de, Andrew Lunn , Frank Wunderlich , Damien Le Moal , Krzysztof Kozlowski , Conor Dooley , Gregory Clement , Sebastian Hesselbarth , Russell King , Hans de Goede , Jens Axboe , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 1/3] arm64: dts: marvell: Fix anyOf conditional failed Message-ID: References: <20241109094623.37518-1-linux@fw-web.de> <20241109094623.37518-2-linux@fw-web.de> <9B1A5D20-3DE5-40C1-8B2D-B1C4F53FA5F4@public-files.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241112_044615_590759_870B3783 X-CRM114-Status: GOOD ( 25.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 12, 2024 at 01:36:51PM +0100, Niklas Cassel wrote: > On Mon, Nov 11, 2024 at 10:25:12AM -0600, Rob Herring wrote: > > > > > > > >I don't know the yaml too well, but it is not obvious how adding a few > > > >status = "disabled"; status = "okay"; fixes a "'anyOf' conditional failed". > > > > > > > >Maybe you can expand the explanation a bit? > > > > > > > > Andrew > > > > > > Hi angelo, > > > > > > I guess the dtbs_check only checks required properties from yaml if the node is enabled. > > > > Yes, that is exactly how it works. > > > > Rob > > Hello Rob, > > If we look at e.g. this binding: > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > > We can see that it does not define iommu-map in the binding, > likewise the binding does have: > unevaluatedProperties: false > > > If I apply my patch that adds iommu-map for e.g. the pcie2x1l0 node: > (the patch does not add anything to the binding above): > https://lore.kernel.org/linux-rockchip/20241107123732.1160063-2-cassel@kernel.org/ > > > If look at the pcie2x1l0 node, it is marked as status = "disabled" > in arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi > > but is marked as status = "enabled" > in arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > > If I run CHECK_DTBS for this dts/dtb: > $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CHECK_DTBS=y rockchip/rk3588-rock-5b.dtb > DTC [C] arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb > $ > > No warnings. > > What am I missing? > > Considering the warning in this series where the binding also > had unevaluatedProperties: false > I would have expected the same error for the pcie2x1l0 node. > > (And if I look at most PCI controler bindings, they actually do define > iommu-map, so it seems a requirement for it to be defined if used.) > Or perhaps the question should have been, if iommu-map is an exception, why isn't iommus also an exception? Kind regards, Niklas