From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202E8C2D0DB for ; Thu, 30 Jan 2020 21:42:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D439A2083E for ; Thu, 30 Jan 2020 21:42:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cPm6rJe2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Swwfor2z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D439A2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lnErBYEdPeV5FP46LwOZa4YUoLy+H1MhqlI0CSeuZFs=; b=cPm6rJe2skOcze Ri6JC/abn3MaYb9CPw86j+ldZ7kchIQuqbUkyT+vNKYH3P+tGupSrsJZeSU/AYzMq37CIsuUqG/8o 7B7DSGpRbMhovTy+6QYDVgf/7Hdq4pBJK0uYcVYJwV2JcViNAKxKtdHl3a9DqRhi8lKPxauXY3sZa Bhvj+Cm25tWtflnk1KWbV3bFznbeZr1dVfkz5/Ck2pJkJzuX2oodpyUD9vsuJoyRJktR4ztcjkRsK xMNEYaDUdDP3tqb/2kbsg1i4xuP3B4pNJpE7HQ/tKwzt4iDseYmt8uK3Hwteq7JwOu7VjDs2Yvkad dq/Do0JVGCnszTMfG4FQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixHZb-0007Ov-Di; Thu, 30 Jan 2020 21:42:03 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixHZX-0007Ob-8B for linux-arm-kernel@lists.infradead.org; Thu, 30 Jan 2020 21:42:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580420517; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmqy3sb1CZwLgBrnkTPFWMV+qNGUz38LZj2S40grOqg=; b=Swwfor2z9Gt0WjANaRNAniVT0/uGhpDdzJHHviGi4vigUPtZSb4FXQpvTv9titxPgEmg96 wBZz29MeCLHdag1teEUw8J29/uUPedUZCXug6RRpg+lFOFi0Vmv7S95W/cgoafneVk+buv 1nC5FE+OyhfbJSQFFPP/RKa95zolShs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-KJbFc7vIMhKGM6FFlMdPOg-1; Thu, 30 Jan 2020 16:41:53 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A4B813EC; Thu, 30 Jan 2020 21:41:52 +0000 (UTC) Received: from localhost.localdomain (vpn2-54-25.bne.redhat.com [10.64.54.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D669A60BE1; Thu, 30 Jan 2020 21:41:44 +0000 (UTC) Subject: Re: [PATCH] drivers/firmware/psci: Fix memory leak in alloc_init_cpu_groups() To: Sudeep Holla References: <20200130034938.158504-1-gshan@redhat.com> <20200130110505.GD48466@bogus> From: Gavin Shan Message-ID: Date: Fri, 31 Jan 2020 08:41:34 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20200130110505.GD48466@bogus> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: KJbFc7vIMhKGM6FFlMdPOg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200130_134159_367142_05F55260 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/30/20 10:05 PM, Sudeep Holla wrote: > On Thu, Jan 30, 2020 at 03:00:13PM +1100, Gavin Shan wrote: >> On 1/30/20 2:49 PM, Gavin Shan wrote: >>> The CPU mask (@tmp) should be free'd on failing to allocating the element >>> of @cpu_groups[]. Otherwise, it leads to memory leakage because the CPU >>> mask variable is allocated with CONFIG_CPUMASK_OFFSTACK. >>> >>> Signed-off-by: Gavin Shan >>> --- >>> drivers/firmware/psci/psci_checker.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c >>> index 6a445397771c..d1d6d1135fed 100644 >>> --- a/drivers/firmware/psci/psci_checker.c >>> +++ b/drivers/firmware/psci/psci_checker.c >>> @@ -167,6 +167,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups) >>> topology_core_cpumask(cpumask_any(tmp)); >>> if (!alloc_cpumask_var(&cpu_groups[num_groups], GFP_KERNEL)) { >>> + free_cpumask_var(tmp); >>> free_cpu_groups(num_groups, &cpu_groups); >>> return -ENOMEM; >>> } >>> >> >> I think @tmp has to be free'd either when failing to allocate @cpu_groups. >> However, I'm holding to post v2 until feedback is received on v1. >> > > Ah sorry, problem with sequential mail reading, ignore my reply as you have > already figured this out. > Sudeep, no problem. I'll fold the additional changes into v2. Thanks for your time on this. Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel