From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B83E5C433EF for ; Fri, 20 May 2022 13:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jlzZ/5moVXryC4GPAtCoLCX6F3K6titND2BUb8YB+TE=; b=2iuJ4R+/iIC0T5 vxxKGDGdbBAkhjpvTx/uismgCUsWLTlzSRZuDJxVtonsLMwWBPqLrhVBuli16tVWxYok51C6y3ym1 0FaHrQT2Cl8lf8W5X2R84d5ZmRYDDPQta/kat5KnWs2wMtDj7Vo+7pz5xNiP/ajI2lcBRnfT//xi1 i16EppITZp2c67MxvCm4wSOMErx0h/ycLSPAIS1Uc1D1IxpeP1uYVu2/5dLEYiw7lbIfK2NkBjeDm 4yHCqah0ZZmT3g4KzUcyzQ/EZ+AAQsBiT/s7SKNx23bQ8XmmFBa0MN00goyddyUbTrpfHk0P4MQel EAqREMb/ZsDZKhD+O/CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2zM-00Cjmu-DX; Fri, 20 May 2022 13:48:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2zJ-00CjlF-4S for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 13:48:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3504A1477; Fri, 20 May 2022 06:48:14 -0700 (PDT) Received: from [10.57.8.29] (unknown [10.57.8.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10A803F73D; Fri, 20 May 2022 06:48:12 -0700 (PDT) Message-ID: Date: Fri, 20 May 2022 14:48:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH kvmtool] aarch64: Give up with MTE for AArch32 guest Content-Language: en-US To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, maz@kernel.org References: <20220520123844.127733-1-vladimir.murzin@arm.com> From: Vladimir Murzin In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_064817_314272_A3E492C3 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexandru, On 5/20/22 14:31, Alexandru Elisei wrote: > Hi Vladimir, > > When I run an --aarch32 guest with --debug this is the message that I'm > getting: > > Info: (arm/aarch64/kvm.c) kvm__arch_enable_mte:146: MTE capability not available > > Would you mind elaborating on the merits of the message that you are > proposing: > > Info: (arm/aarch64/kvm.c) kvm__arch_enable_mte:124: MTE is incompatible with AArch32 > > Is it because it explains why the capability is not available? Hmm, without this patch I'm getting lkvm run -k /opt/kvm/guest-0/Image -d /opt/kvm/guest-0/fs.ext2 -c 4 -m 681 --console virtio '--irqchip=gicv3' --params 'console=hvc earlycon swiotlb=1024' --aarch32 --debug + lkvm run -k /opt/kvm/guest-0/Image -m 681 -c 4 --name guest-115 Info: (arm/aarch64/kvm.c) kvm__get_vm_type:76: max_ipa aa8fffff ipa_bits 32 max_ipa_bits 40 Info: (arm/aarch64/kvm.c) kvm__arch_enable_mte:104: MTE capability enabled Info: (arm/kvm.c) kvm__arch_load_kernel_image:118: Loaded kernel to 0x80008000 (17280980 bytes) Info: (arm/kvm.c) kvm__arch_load_kernel_image:134: Placing fdt at 0x8fe00000 - 0x8fffffff Fatal: Unable to initialise vcpu with patch applied lkvm run -k /opt/kvm/guest-0/Image -d /opt/kvm/guest-0/fs.ext2 -c 4 -m 681 --console virtio '--irqchip=gicv3' --params 'console=hvc earlycon swiotlb=1024' --aarch32 --debug + lkvm run -k /opt/kvm/guest-0/Image -d /opt/kvm/guest-0/fs.ext2 -c 4 -m 681 --console virtio '--irqchip=gicv3' --params 'console=hvc earlycon swiotlb=1024' --aarch32 --debug # lkvm run -k /opt/kvm/guest-0/Image -m 681 -c 4 --name guest-114 Info: (arm/aarch64/kvm.c) kvm__get_vm_type:76: max_ipa aa8fffff ipa_bits 32 max_ipa_bits 40 Info: (arm/aarch64/kvm.c) kvm__arch_enable_mte:92: MTE is incompatible with AArch32 Info: (arm/kvm.c) kvm__arch_load_kernel_image:118: Loaded kernel to 0x80008000 (17280980 bytes) Info: (arm/kvm.c) kvm__arch_load_kernel_image:134: Placing fdt at 0x8fe00000 - 0x8fffffff Info: (virtio/mmio.c) virtio_mmio_init:325: virtio-mmio.devices=0x200@0x3000000:36 Info: (virtio/mmio.c) virtio_mmio_init:325: virtio-mmio.devices=0x200@0x3000200:37 Info: (virtio/mmio.c) virtio_mmio_init:325: virtio-mmio.devices=0x200@0x3000400:38 My host and guest kernel is 5.15, maybe I'm just missing some backport? Cheers Vladimir > > Thanks, > Alex > > On Fri, May 20, 2022 at 01:38:44PM +0100, Vladimir Murzin wrote: >> KVM doesn't support combination of MTE and AArch32 guest, so do not >> even try. >> >> Signed-off-by: Vladimir Murzin >> --- >> arm/aarch64/kvm.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arm/aarch64/kvm.c b/arm/aarch64/kvm.c >> index 1b992dd..f3fe854 100644 >> --- a/arm/aarch64/kvm.c >> +++ b/arm/aarch64/kvm.c >> @@ -120,6 +120,11 @@ void kvm__arch_enable_mte(struct kvm *kvm) >> .cap = KVM_CAP_ARM_MTE, >> }; >> >> + if (kvm->cfg.arch.aarch32_guest) { >> + pr_debug("MTE is incompatible with AArch32"); >> + return; >> + } >> + >> if (kvm->cfg.arch.mte_disabled) { >> pr_debug("MTE disabled by user"); >> return; >> -- >> 2.25.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel