From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AABBCC43217 for ; Fri, 21 Oct 2022 13:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FffsxnjCGwUmTzxbGpvmiGz2iV0s7cV/F5pMTqdwMb8=; b=YXVYMQo370wUZt WtW2WEeBcEeQOwcyjhI8hjUrlqFDzZDxIImvb8giHhUmVGCzF3D+/fuBN+X/whjKpWqW0BPKtswho q9ViCE0/gOuuzdWBM3rFm8bAUj1s/cnqBJOKz6UBQHAPPBSAUtcZWw/jlfS1vR9J9rh5hp56IL/I6 pA6p7XtDMuVw8uyYPUW8c5a1seXAUZWQ/HOwP7IVjA0js4m+2jq8KgsmyDhSJ5OaF/NZ5Ao5x5tct cq1MK6UkH5v5r4UrV3ptdqOWZUzVKjasQbuvBSi+VtJKFk84kM7xvAaCtXKuKvhkw/fYxPAJree1H O8MoKwzuO4Q8FlgpBEMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olsEH-0083qU-L1; Fri, 21 Oct 2022 13:38:29 +0000 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olsEE-0083oz-R5 for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2022 13:38:28 +0000 Received: by mail-qv1-xf34.google.com with SMTP id x13so335020qvn.6 for ; Fri, 21 Oct 2022 06:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KSzkkxJmt+63RR1lkwGlnOxYt96Hz8plGKgcG5hGf78=; b=WC1/Vaw070/6Nnw2/72p0FXGDvkc/9JDDi/PrPjA/nbPPFkSpNofj5eiWG2HegS1Iu EZxINnRgbYWJPxzi6N3Htly+fhPZlnnIsk/dvkpvMSci1X7chIX34vE694cH3gNODt84 8sQNDQjRhWpYHsP3/+PnBQh41HYUwuuBCF1M0kbH5adOC8e+Ze0/smvQLB5BwQUmotee lBeGupjIoJYlCiKTMgF1bZGxotJWPOG5LEgfWRNe9NmW4KCPcGYrgyR3Mc5i0JOWQahy 8el//Z5s/Axsfk14aGPP4YsVWB+V+kgBQ8bAY07hiuQKmp7nzm57YuIi0fcftOEB9WK/ L4rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KSzkkxJmt+63RR1lkwGlnOxYt96Hz8plGKgcG5hGf78=; b=WWDjTLKxW6XegwGwTkDPUCLhQzRN4OGiBWYsR4HbfW59Tx94slBWrLyGXU5tGzxEKt zEigDCtDZLQwkBkpYkM2wCyu2fKur8FPlIFx4+ZOa8O+nYByryIMssR61UgH+2Kc8IMn QXFNbZ3jmkoy88yJMnn+MI+qrhgfAMBiX3Dg0OXRbndBAhuBRwdHkH4EAO8cj4pRo1jc NZIi8cM+6cgW2JT32NosQ+8TxK1hQM2yKyiQ+bA++ZyH4nFnuxGKZFBrJ2GEMKjC0p6Q DU3WdZ4kBKv293zPOYPfm88gQg7a5HoL0YQbdawItGHsfb+uUhg2I0Y3TMSAvvPIi0zn tSjQ== X-Gm-Message-State: ACrzQf2X+Pp8hkD4nAMqB0PO2uUEiTkX9AIhcB8ofevRjN5o7bqsq2U6 G60khMGXeKuE7BWs0yj6VHCSoA== X-Google-Smtp-Source: AMsMyM4FZ01IGdKeTxmwj5pLpoUJHwEmgn6/Mp8bmAqg3DRg9Qw431uomUeIF2iTpThwFCvOjuXusg== X-Received: by 2002:a0c:ac02:0:b0:4af:a3b1:3167 with SMTP id l2-20020a0cac02000000b004afa3b13167mr16441073qvb.66.1666359505693; Fri, 21 Oct 2022 06:38:25 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id br32-20020a05620a462000b006e9b3096482sm9522021qkb.64.2022.10.21.06.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 06:38:25 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 09:38:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH net-next v5 2/5] net: ipqess: introduce the Qualcomm IPQESS driver Content-Language: en-US To: Maxime Chevallier , davem@davemloft.net, Rob Herring Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko References: <20221021124556.100445-1-maxime.chevallier@bootlin.com> <20221021124556.100445-3-maxime.chevallier@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20221021124556.100445-3-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_063826_915982_C0F7EEC1 X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/10/2022 08:45, Maxime Chevallier wrote: > The Qualcomm IPQESS controller is a simple 1G Ethernet controller found > on the IPQ4019 chip. This controller has some specificities, in that the > IPQ4019 platform that includes that controller also has an internal > switch, based on the QCA8K IP. Thank you for your patch. There is something to discuss/improve. > diff --git a/MAINTAINERS b/MAINTAINERS > index 5c6ce094e55e..46fdd3c523c5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17037,6 +17037,12 @@ L: netdev@vger.kernel.org > S: Maintained > F: drivers/net/ethernet/qualcomm/emac/ > > +QUALCOMM IPQESS ETHERNET DRIVER > +M: Maxime Chevallier > +L: netdev@vger.kernel.org > +S: Maintained > +F: drivers/net/ethernet/qualcomm/ipqess/ Add also bindings. > + > QUALCOMM ETHQOS ETHERNET DRIVER > M: Vinod Koul > R: Bhupesh Sharma > diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig > index a4434eb38950..a723ddbea248 100644 > --- a/drivers/net/ethernet/qualcomm/Kconfig > +++ b/drivers/net/ethernet/qualcomm/Kconfig > @@ -60,6 +60,17 @@ config QCOM_EMAC > low power, Receive-Side Scaling (RSS), and IEEE 1588-2008 > Precision Clock Synchronization Protocol. > > +config QCOM_IPQ4019_ESS_EDMA > + tristate "Qualcomm Atheros IPQ4019 ESS EDMA support" > + depends on OF I think this is present only on systems where Qualcomm IPQ4019 SoCs is the main SoC (AP)? If so, I propose not to offer this to non-Qualcomm SoC builds, because they cannot use it and it makes life of distro-vendors configurators difficult: depends on ARCH_QCOM || COMPILE_TEST > + select PHYLINK > + help > + This driver supports the Qualcomm Atheros IPQ40xx built-in > + ESS EDMA ethernet controller. > + > + To compile this driver as a module, choose M here: the > + module will be called ipqess. > + > source "drivers/net/ethernet/qualcomm/rmnet/Kconfig" Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel