From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF96BCEBF81 for ; Fri, 27 Sep 2024 08:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7HwX6OI4gIIHbN/hK9fjNZGmVtettbN++9lE7NDiTf8=; b=bV8Oa8F9yKxFLXFyyofmFPA+Tr 6susoWw77D6CUHbXmB+wWRllMBB4B0Ty/vtPO/rplACSi+jOC+nJehkC/JZASNBlYgLpQqVhyEYwv BU3Aggd99r7qJn6hpRLkkiBtvLWdF4xnEa4G7ZKY0woxf3GjVnOqCzVjGnKWIlkfDG8merPpIFewh LHkCR//ueX7ICqh5eeGgmvrE/HXBQtAAHihNoZwXAxhuPgHimiGLfhRiVkZOt8ycfsui10lDt0rVm QINrqIqWcUfalx5ucji5c4Kj0SeJdsMLgDkrCTJEbf8lFwTZMZ9oi2OGn9z4shuu46p+JteF+XxYq Pz21bMnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su5u1-0000000AQJC-1g3D; Fri, 27 Sep 2024 08:00:37 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su5sh-0000000APzr-1HWD; Fri, 27 Sep 2024 07:59:21 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20b411a1d60so139375ad.2; Fri, 27 Sep 2024 00:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727423954; x=1728028754; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7HwX6OI4gIIHbN/hK9fjNZGmVtettbN++9lE7NDiTf8=; b=KLUvfISG56uuuYI+GXDCWfjmXNwpOpuYPDZayIxrJJ8A7vY3+6aY6+2GCZgfnvfUgw czNie+N5fJ2aDWxbFonGbcykTVcCZrDtU1XBuzaJ5Xy2H7uAlQYB9lAE8SsQuM/HWu8f otG5QWqtjWlaDM4nO7I6FMcCmdmpodQ+CoTQRoNXECCTf3QFZ1A9pm1qEHo4GchTmMPZ xwXiJ7TUPvcdaF+4HYyudts3momiGnqLMlzSHir1cu6xyPd9x/r8b/9etpslkL43OnZv oR/m2/HdMpK2TFiovghw8tFPgRCKw1gz2lhVyXdqPxL9NdxP0P4mbOAN4tvDWwQcr0XE n90g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727423954; x=1728028754; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7HwX6OI4gIIHbN/hK9fjNZGmVtettbN++9lE7NDiTf8=; b=a3Z0oLSgqubEIkuurz2RFbRuumQJ7tU7AXVwmi6nu5PjkJcGNBsPc1RlUJ92g0D2Mx GtHGWOcZ9v+DWdOMqaStMHxC8u0fjBAz8dIS/3SldzWO5MpWUNVCBY+OYf/gi/K1m4my SFFTzPjHnCC9E8A85Ne9YeAe5ZxA2YjlgySge3yTNFcjUQIHHYLcQ/qfsv5o1zV5ALPP ZAxsFNK+q59DC/CEz4Xu9mbenIhthW/XpqC9gJCp+6vWWi4UazWwdQyb75uaKZTKb9Am C+mUcMNUzYvWRXKeVNif09hwyZCVVQPcMbuH9BBFxcDJ7xyX22oLl5ElhNrm7ekMf/Mj j4JQ== X-Forwarded-Encrypted: i=1; AJvYcCVBcV33F+6Xw/PkGvmZ3GX8CopEoXPIBqe5EUFNs/ZdV9ci5xhCHFeFUglVTBX8kA1Nq7f9U6ZmoFtnAB4sSq+H@lists.infradead.org, AJvYcCVsU8dZfxThPtvSpVzzK9ohb/cC0Byp0wXvdh42tk3ylY07op16e7muCBZhN+nqZNq1qjT1GSjn4oEyj4RF05U=@lists.infradead.org X-Gm-Message-State: AOJu0YwkgaHn/mnWsgVh5TfsDfMqz0r72XnFp2rpYmFp0YcNNEuAuEn6 odyW61iGWqA5tPVR5z0J2RhNzY89P3xe6TRvdW1+7U2gvhIHc6ZW X-Google-Smtp-Source: AGHT+IE8JYRGGpZv4q306yHVh3sNMzBl8mIZYgoblrNJM7FaZO2kvA7WslMeA3lBcRj9DzjVCS+SCA== X-Received: by 2002:a05:6a00:39a8:b0:714:1bcf:adbe with SMTP id d2e1a72fcca58-71b25dacbdemr1720656b3a.0.1727423954093; Fri, 27 Sep 2024 00:59:14 -0700 (PDT) Received: from [192.168.60.56] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b265249b7sm1060789b3a.148.2024.09.27.00.59.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 00:59:13 -0700 (PDT) Message-ID: Date: Fri, 27 Sep 2024 15:59:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 To: Krzysztof Kozlowski , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, william.wu@rock-chips.com, tim.chen@rock-chips.com, frank.wang@rock-chips.com References: <20240926103223.29538-1-frawang.cn@gmail.com> <7944f4dd-96f0-40df-8c91-523409e3cb20@gmail.com> <4b98196a-c898-4d08-9101-31feb4e59b5c@kernel.org> Content-Language: en-US From: Frank Wang In-Reply-To: <4b98196a-c898-4d08-9101-31feb4e59b5c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_005915_372585_C3364C62 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 2024/9/27 15:30, Krzysztof Kozlowski wrote: > On 27/09/2024 09:01, Frank Wang wrote: >> Hi Krzysztof, >> >> On 2024/9/26 22:19, Krzysztof Kozlowski wrote: >>> On 26/09/2024 12:32, Frank Wang wrote: >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - rockchip,rk3576-usb2phy >>>> + then: >>>> + properties: >>>> + clocks: >>>> + minItems: 3 >>>> + maxItems: 3 >>> Read one more time the example I gave you. Top-level constraints are >>> saying max one clock. >>> >>> Best regards, >>> Krzysztof >>> >> Sorry for overlooking this, I will set both "clocks" and "clock-names" >> to true, and add the else case below the above codes for the "old" SoCs. >> Just like the below. >> >> -  clocks: >> -    maxItems: 1 >> +  clocks: true >> >> -  clock-names: >> -    const: phyclk >> +  clock-names: true > For the third time, read the code I gave you. Do you see something like > this there? Why doing all the time something different than existing code? Refer to the link you sent me that I must add minItems property for clocks, just like the below codes: @@ -35,7 +35,8 @@ properties:      const: 0    clocks: -    maxItems: 1 +    minItems: 1 +    maxItems: 3 That can pass dt_binding and dtb checking, however, "clocks" is the optional property for some old Rockchip PHYs,  I am not sure is it right to force set  minItems as 1 . If just keep maxItems, the dt_binding checking is failure. Best regards, Frank > Best regards, > Krzysztof >