From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA7E1EB64DB for ; Fri, 16 Jun 2023 13:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=inmA89uvc70nXOzwAxZJH9cPEFW/45h4NZ8uq86D5O4=; b=ZRq7leenn6ePfO 2mJEtmz5oAYyCvE/nXCx8wjUVuYp7oq8EHUJ8ljobhqZgLzjTaFzhfv55gL3NSGxcq8rZeJ6N3h7v oFMzlaSIB+suPhtWR+CwrIOAPNpDpqT/77v6yT/A1WFftolZO3OevirZV4YTXvb7CFZhoCcSH7jxE 8z3DopyAy66EBAZQppchVReEJ9Ooi/iJzb/ptNltKvaishyVYW71K3VmoLO0344LIA7bNVYpJtjEM Pxcd0CAEL1rxxxs74L1SvD0mGvTEggkVbxf7QoVuVRFMYv7T3wXyorRrg2NaBrUh63tN5ezYkY5Bf cAzVYoAjbDlDZeiJv9RQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA9O9-000fCG-0Y; Fri, 16 Jun 2023 13:21:17 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA9O5-000fB6-0L for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 13:21:14 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-982c996a193so95211066b.3 for ; Fri, 16 Jun 2023 06:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686921670; x=1689513670; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SI6dl8UqSr36BkzgDyYr2xy1n3KiQ9Y+vgjSNSYf4ZU=; b=UL3epjgrjoqFMfoQARineB80MJ8F7lbZYLcXrJ4j9jcginPg8UqtTIyJEvbrgGztL9 hhRFtpUwvGBOo9IrlWFqFzB/Uk1P1lIDC0y1cSXvdnjjO3vxMGYG8L7LLAviSO+VmRaR z91M6nr2tifNidHQnvY1Qt2bhYvVx2aqLkkI0d88hLlYnDVofosTDHbJcNkm++n4ZUVs mig0UGtelrQBcT1HOd01+yakZUEYc1C4RIy4WkfeFnCfE3WCrKY9H+CcGBkLhdM1bz3u rp6tWbHy/yQLwSrSTr+tq6vQybcuXXJf5JT6t1X5pv9qjT9xnW/duCEDF2p+hr8KghrN UVUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686921670; x=1689513670; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SI6dl8UqSr36BkzgDyYr2xy1n3KiQ9Y+vgjSNSYf4ZU=; b=jcXLCIDpugqUXNUWrd39LY6RSdxaUFZlXzE606S9vKiToWCmY0FGK4OprYv3r6Rf7N /AbzZSxtLewxbgz2mmHZUPbg3DD6ZwrllBNElcZ8bENulcYd7+YJU3eMrVg0em4pjyNE 5xqd+maUButNUtEyRgaP75Zj2E9GyHZq2gbHPFw0ZLBfpV4aLZIEXRv28UppfnW1ZSLr M4+uke1owbUkbbtH+Br82KJO5geDF01UJAYqpcHKrvSONwabNnS6hM4nWFptjmNb5IzR hmhAB79lWGPzXJS4bgWyEGGbLcD8QFPc+pnOs0DP3XRyqDkBaHc8oceS9UMcNQ8NLcXt Zi+g== X-Gm-Message-State: AC+VfDy0qVcBZf2lzTpU11QqLlXghOp7BEpHkn0r3RNsVhMGU0uPH/kl n2gGAgHOl5ChsoI066Bhdn/jWQ== X-Google-Smtp-Source: ACHHUZ5pzFujAPq2eOgIWzR0/4GJkk2JE7bT8npv7ypXkPUIxMHwvcY5Xdq8K8WjxbBqF+S1gs6l0g== X-Received: by 2002:a17:907:1c19:b0:973:e5d9:d6ff with SMTP id nc25-20020a1709071c1900b00973e5d9d6ffmr1863776ejc.66.1686921670119; Fri, 16 Jun 2023 06:21:10 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id w26-20020a17090652da00b00982d0563b11sm1402426ejn.197.2023.06.16.06.21.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 06:21:09 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 15:21:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding doc Content-Language: en-US To: Pankaj Gupta , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gaurav.jain@nxp.com, linux-kernel@vger.kernel.org, Daniel Baluta References: <20230616181144.646500-1-pankaj.gupta@nxp.com> <20230616181144.646500-2-pankaj.gupta@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230616181144.646500-2-pankaj.gupta@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_062113_232415_2B3E59FA X-CRM114-Status: GOOD ( 27.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/06/2023 20:11, Pankaj Gupta wrote: > The NXP i.MX Message Unit enables two processing elements > to communicate & co-ordinate with each other. This driver > is used to communicate between Application Core and > NXP HSM IPs like NXP EdgeLock Enclave etc. > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. > > Signed-off-by: Pankaj Gupta I don't see reply to Daniel's concerns. I don't see improvements here based on the previous review you received. It seems you just ignored everything, right? Limited review follows up because binding is not in the shape for upstream. Do some internal reviews prior sending it. > --- > .../bindings/arm/freescale/fsl,ele_mu.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,ele_mu.yaml > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,ele_mu.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,ele_mu.yaml > new file mode 100644 > index 000000000000..29e309a88899 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,ele_mu.yaml No underscores, filename based on compatibles. > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/freescale/fsl,ele_mu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX EdgeLock Enclave MUAP driver Drop driver. > + > +maintainers: > + - Pankaj Gupta > + > +description: | > + > + NXP i.MX EdgeLock Enclave Message Unit Driver. > + The Messaging Unit module enables two processing elements within the SoC to > + communicate and coordinate by passing messages (e.g., data, status and control) > + through its interfaces. > + > + The NXP i.MX EdgeLock Enclave Message Unit (ELE-MUAP) is specifically targeted > + for use between application core and Edgelocke Enclave. It allows to send > + messages to the EL Enclave using a shared mailbox. > + > + The messages must follow the protocol defined. > + > + Non-Secure + Secure > + | > + | > + +---------+ +-------------+ | > + | ele_mu.c+<---->+imx-mailbox.c| | > + | | | mailbox.c +<-->+------+ +------+ > + +---+-----+ +-------------+ | MU X +<-->+ ELE | > + | +------+ +------+ > + +----------------+ | > + | | | > + v v | > + logical logical | > + receiver waiter | > + + + | > + | | | > + | | | > + | +----+------+ | > + | | | | > + | | | | > + device_ctx device_ctx device_ctx | > + | > + User 0 User 1 User Y | > + +------+ +------+ +------+ | > + |misc.c| |misc.c| |misc.c| | > + kernel space +------+ +------+ +------+ | > + | > + +------------------------------------------------------ | > + | | | | > + userspace /dev/ele_muXch0 | | | > + /dev/ele_muXch1 | | > + /dev/ele_muXchY | > + | > + > + When a user sends a command to the ELE, it registers its device_ctx as > + waiter of a response from ELE. > + > + A user can be registered as receiver of command from the ELE. > + Create char devices in /dev as channels of the form /dev/ele_muXchY with X > + the id of the driver and Y for each users. It allows to send and receive > + messages to the NXP EdgeLock Enclave IP on NXP SoC, where current possible > + value, i.e., supported SoC(s) are imx8ulp, imx93. > + > +properties: > + compatible: > + enum: > + - fsl,imx-ele > + - fsl,imx93-ele > + > + mboxes: > + description: > + A list of phandles of TX MU channels followed by a list of phandles of > + RX MU channels. The number of expected tx and rx channels is 1 TX, and > + 1 RX channels. All MU channels must be within the same MU instance. > + Cross instances are not allowed. The MU instance to be used is S4MUAP > + for imx8ulp & imx93. Users need to ensure that used MU instance does not > + conflict with other execution environments. > + items: > + - description: TX0 MU channel > + - description: RX0 MU channel > + > + mbox-names: > + items: > + - const: tx > + - const: rx > + > + fsl,ele_mu_did: No underscores. Drop all properties not related to hardware. > + description: > + Owner of message-unit, is identified via Domain ID or did. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [0, 1, 2, 3, 4, 5, 6, 7] That's not the syntax you can find. Open example-schema and rewrite your bindings. > + > +examples: > + - | > + ele_mu: ele_mu { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "fsl,imx93-ele"; > + mbox-names = "tx", "rx"; > + mboxes = <&s4muap 2 0 > + &s4muap 3 0>; > + fsl,ele_mu_id = <1>; > + fsl,ele_max_users = <4>; > + fsl,cmd_tag = /bits/ 8 <0x17>; > + fsl,rsp_tag = /bits/ 8 <0xe1>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel