From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B48CCFA05 for ; Fri, 7 Nov 2025 07:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qtwNZ51TOe1KmMbJGFmq0uDZnSOTzBAwW5XE8OEKres=; b=X1uxchuyG10kqWJ2utWSjKU5nq MTwJjCKOu79gKXNl7PfNcxPQGnl3raJMW8tavmx5hUf87cXrC54zmUg2vOOn+xEyK+DNIG+OP7o1C 2hDrQRrE7K7qynjWAcoBsjHCS+FHKXpjzMJ4HFM8yomI/mupYhZVNDm++zOziHnQDUxtiqlegMAOf vZzFVivypxoGWAgjfyxD46esiAnb0ke5Sf3DTxgl1Q5KiDGgGiRsAeviKshmvVQT0KBHCWYWT/8Ys akFwjxkwn/wpWPjdcIfDH1zWT0HrlDMyWaXaJ9xIdMbo1DAb7SUb/owAY1sUKXMSZeyux4Pw+GA7P /ucDqLZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHGaL-0000000Glkr-0kTp; Fri, 07 Nov 2025 07:08:37 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHGaI-0000000GlkA-1JeO for linux-arm-kernel@lists.infradead.org; Fri, 07 Nov 2025 07:08:35 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-429b6e25316so57287f8f.1 for ; Thu, 06 Nov 2025 23:08:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762499312; x=1763104112; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=qtwNZ51TOe1KmMbJGFmq0uDZnSOTzBAwW5XE8OEKres=; b=HkZ9rE66+fczi3WT5/nlLBM2vDpygkSZbPaPAryNzwa5ej/Rpv128o9WrQD+UUA9MQ 6lYn7G4QNUHM881SXRXvttKZGuZ/QBQPwFcDaSqk/FRn4Lkf6LsEZBfyfW7fPuyqSO+L 1Cj4ESqw13GWwVBl7TdsH42AcmOiPNMacm7gFqfoTKfpo7pxDCrryPhJQAK0lFrenXmb oAISSA9hT/Wh4q/LhIL3R2tIk31gcrjg+8o3bEJY9Hx8cNYURWJ5EA3XG5UpFwzw1dOb /gRNAkqbei1QU4gPwxhbHci/kcEggT+xoZhwcXAe2TwEOXqGd1IWxXOleRuo7kBUxtMM tQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762499312; x=1763104112; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qtwNZ51TOe1KmMbJGFmq0uDZnSOTzBAwW5XE8OEKres=; b=MjGx3l2neLc/dc9opdtAda6hprU+11KUBcmrL9NU1OcwG9yj9sf8vQzAjP0CcSA5Ea ZXIcxAdt00s7jnWZVDSWSnmD3T2CMc5HhpVbx1EhN+Kf4dJsOI1FVmDyv5hGFDnT5l3b JwBGtQaiRk4Wx9B/OJ3LpLH0GU2wCpE2P8T8j9CaW7chiMtlulKn54ocFgstVGcKDooo aypwyP1vrm6L5mZA1j/Tkg/oF4DE/Ka/P5KPZRlEis1jJhh/1FjHp79f/nn33fsbKqoS UrnLWO6mqLAX0hfOKgIzNk5bn/1BN/PxK9YPOm9QMdTAajPylbYD+UfAUcd378OZViXS A69w== X-Forwarded-Encrypted: i=1; AJvYcCUkBGWH5YgPzXZ50hNk7dKaXtq6qlhm3XDXi8YyPDUyHUnDRKDHTV2Hid35RAALBfD2G28WONz1WOgLsGJR5GA/@lists.infradead.org X-Gm-Message-State: AOJu0Yy/CtHe3GvhBR3P5nsxoVqIWWwkpC7VuXcMpxXAEJjORzMZxGYW t14Sop+DLpeiYjRkagGgiTKfwDDEYXs6GRUdOsAKy689oOiGtWI87luZKOFxdMGlq+Y= X-Gm-Gg: ASbGncvA00PNoU908vTUS8i2D1jaQ6ZqKWlMV8HOQgjL6eGZi8By0YU26+uaojzVct4 T1U6H0sgyBH0F5e4F4bSxowPMJI7NzJMqAVn2oVYjNz4zC1TXV7Mll7NcnsTxQ3TXhax1L2R35X mM4VT2MDTSZ5ex+y1xMbLYh0rrRg4IX8EUPMObhV+ego+ZNDv1rVAQ6QueXAMhjWM/3Lk/g+pfK TxhZ/R6xS8S74uW9syiF4SGF3m/DkSqjmB5rF3kTtYlo/5otKaH43MCgY+qLj/tk3kbZIZYf+GM 0hSNphC9+hyLQlUNcoFTh8/PPwiMdQxQPG5hFirJ+RUWIFDSvUqorXkmAqwUm6hg9TjG/xP7VdK iCzP1FhpdcTI/QzrECMY+hODmCTewjhuySwqJ+9pGdO6GOFMy5ckCtADVOdcc84bzW2zs0s8zq8 YaKAFXOok1rlSAXGeF/aVxTNjbT/jUoR8= X-Google-Smtp-Source: AGHT+IE77T5dGr6wx+Zi4AgBBU0bj3shUSkAGD10kNklEOoD/4TJ7x49hYuoTtpTUQ6bFauuSPanLw== X-Received: by 2002:a05:600c:46c6:b0:477:54cd:2019 with SMTP id 5b1f17b1804b1-4776bc81647mr9463155e9.1.1762499312082; Thu, 06 Nov 2025 23:08:32 -0800 (PST) Received: from [192.168.1.29] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42abe62bf40sm3513388f8f.9.2025.11.06.23.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Nov 2025 23:08:31 -0800 (PST) Message-ID: Date: Fri, 7 Nov 2025 08:08:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/13] soc: qcom: Simplify with of_machine_get_match_data() To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Rob Herring , Saravana Kannan , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Lorenzo Pieralisi , Daniel Lezcano , Bjorn Andersson , Konrad Dybcio , Thomas Gleixner , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Maximilian Luz , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Daniel Lezcano , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-tegra@vger.kernel.org References: <20251106-b4-of-match-matchine-data-v1-0-d780ea1780c2@linaro.org> <20251106-b4-of-match-matchine-data-v1-11-d780ea1780c2@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251106_230834_435177_5196322B X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/11/2025 08:02, Krzysztof Kozlowski wrote: > On 07/11/2025 04:19, Dmitry Baryshkov wrote: >> On Thu, Nov 06, 2025 at 08:07:18PM +0100, Krzysztof Kozlowski wrote: >>> Replace open-coded getting root OF node, matching against it and getting >>> the match data with new of_machine_get_match_data() helper. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> Depends on the first OF patch. >>> --- >>> drivers/soc/qcom/qcom_pd_mapper.c | 17 ++--------------- >>> 1 file changed, 2 insertions(+), 15 deletions(-) >>> >>> diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c >>> index 1bcbe69688d2..07198d44b559 100644 >>> --- a/drivers/soc/qcom/qcom_pd_mapper.c >>> +++ b/drivers/soc/qcom/qcom_pd_mapper.c >>> @@ -613,25 +613,12 @@ static void qcom_pdm_stop(struct qcom_pdm_data *data) >>> static struct qcom_pdm_data *qcom_pdm_start(void) >>> { >>> const struct qcom_pdm_domain_data * const *domains; >>> - const struct of_device_id *match; >>> struct qcom_pdm_data *data; >>> - struct device_node *root; >>> int ret, i; >>> >>> - root = of_find_node_by_path("/"); >>> - if (!root) >>> - return ERR_PTR(-ENODEV); >>> - >>> - match = of_match_node(qcom_pdm_domains, root); >>> - of_node_put(root); >>> - if (!match) { >>> - pr_notice("PDM: no support for the platform, userspace daemon might be required.\n"); >>> - return ERR_PTR(-ENODEV); >>> - } >>> - >>> - domains = match->data; >>> + domains = of_machine_get_match_data(qcom_pdm_domains); >>> if (!domains) { >>> - pr_debug("PDM: no domains\n"); >>> + pr_notice("PDM: no support for the platform or no domains, userspace daemon might be required.\n"); >>> return ERR_PTR(-ENODEV); >>> } >> >> Here you are mixing two cases: >> - There is not match in the table (in which case the driver should print >> a notice) >> >> - There is a match in the table, but the data is NULL (the platform >> doesn't have PDM domains). In this case there should be no notice. > > > Why? Existing code printed notice in both cases. Why refactoring which > tries to keep code functionally equivalent should change it? Ah, you mean there was a debug before. Well, then I am a bit confused because table has entries without data (so expected condition) but old code returned ERRNO in such case - so unexpected condition. Wail failing the probe on expected condition? Unless it is not really expected and notice in second case is valid as well. Best regards, Krzysztof