From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF5E2C4707B for ; Thu, 18 Jan 2024 15:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=964IZDKYqom2EtqPR2woz5D40T0xpCd5KRcNxsN+xiI=; b=Fv7nc1/Y6n2DNH VtMv6s3I/r6dpXGehr2oowB8Uay2dM2fvBBGKWkxyxAprRb8vq6z/LPVrn8r5nlzTLoUS2uPvr0hd IKYAhHs6Ozg9G6tOoXhiIBTqJnJbBMYGDmA4c2/jk6KSpncHBAD68TlfR8DX2b8vc0zxG7+MyFEqV PjTbKNcvml1Pr1fcBsNl5+ascFA6oTNz/N9udqhkT0Hrm0WYju60Mv2x359KW6r/JFytj0lOHUlOZ C7G3VyWAHa0c5fiQQA4566ilYP782vBRlgz71CL8i1ua9i4nGgufQfxQpyJLMBO88ersfvx86i6F6 DRwAQRzLRK60gWDasBVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQUXr-0038ai-2o; Thu, 18 Jan 2024 15:43:07 +0000 Received: from mx4.securetransport.de ([178.254.6.145]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQUXo-0038a0-2Q for linux-arm-kernel@lists.infradead.org; Thu, 18 Jan 2024 15:43:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1705592552; bh=gvYAY6pmLImg/jmaH+JmkmYfG3Jb3vB98VAGPVricOM=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=qXR9BMclBxtfEw8EMtDPgGHWDtIiSNyWW4HUBstZuxu+pvsotObvrfRLQ+QbhbI82 GUNHTbg6/ck48g2BG4yowQLhzGCXCs0DFmx/k3lYdI/ETxfb/zH5ZMxjEaxOWTDrhv ekFE29Fcy3tb+52VWXp8yhh6PjFG0Q/a87HekEE95XtvYp0Y1ntomNvmED1hCmSzXE vSo3GEMYMJO6bERwPt+X8skKbTFlnhmnwz9YgTtd5tqkbVzyRpXL5avz2A7gXOZ8XI Gl6T4wsVJXW2VQXzw/FyCKcnIV1xC8HIsCn3MJGvkdRailOOyaFscW/+VgGNNlBoj/ KrLKSUoJc1/DA== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Greg Kroah-Hartman CC: "linux-serial@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Crescent CY Hsieh , Jiri Slaby , Lukas Wunner , Lino Sanfilippo Subject: RE: [PATCH] tty: serial: Fix bit order in RS485 flag definitions Thread-Topic: [PATCH] tty: serial: Fix bit order in RS485 flag definitions Thread-Index: AQHaSgwRrhJOv1ZSDE6d0xFG0slKQ7DfjZ+AgAAnyrA= Date: Thu, 18 Jan 2024 15:42:30 +0000 Message-ID: References: <20240118124350.3772-1-cniedermaier@dh-electronics.com> <2024011827-bagful-connector-9b36@gregkh> In-Reply-To: <2024011827-bagful-connector-9b36@gregkh> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_074305_013777_2FB61983 X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Greg Kroah-Hartman > Sent: Thursday, January 18, 2024 3:19 PM > On Thu, Jan 18, 2024 at 01:43:50PM +0100, Christoph Niedermaier wrote: >> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the >> meaning of some variables"), the definition for bit 3 has been removed. >> But with the switch to bit shift marcos in commit 76ac8e29855b ("tty: >> serial: Cleanup the bit shift with macro"), this gap wasn't preserved. >> To avoid a break in user/kernel api of the system skip bit 3 again and >> add a placeholder comment. >> >> Signed-off-by: Christoph Niedermaier >> --- >> Cc: Greg Kroah-Hartman >> Cc: Crescent CY Hsieh >> Cc: Jiri Slaby >> Cc: Lukas Wunner >> Cc: Lino Sanfilippo >> To: linux-serial@vger.kernel.org >> To: linux-arm-kernel@lists.infradead.org >> --- > > Shouldn't this have a Fixes: tag in it? I will fix that in Version 2. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel